67.37 KB, text/html
R.J. Keller: review-
Full stop restored. Changed: Disable cookies -> Block cookies (a few lines above the missing fullstop). Checked in (trunk/branch).
43.98 KB, patch
Giacomo Magnini: review+
Ian Neal: approval-seamonkey1.0+
|Details | Diff | Splinter Review|
bug 225857 menu items for both Cookie Manager and Image Manager have been changed. Need to update Help content.
Created attachment 138665 [details] [diff] [review] patch cookie info update. also convert page to xhtml
Created attachment 140099 [details] preview Lots of changes. I might have accidentally removed some IDX anchors; I will recover 'em later
Chris and timeless, got time to review the changes?
Comment on attachment 140099 [details] preview /me defers to dwitte.
dwitte asked me to review this. Since there isn't a diff version, I'm doing a general review on the documentation. spelling nit: Persistant should be persistent. Sites in the Cookie Sites dialog always override the default prefs. This means that even if Disable Cookies is selected, allowed sites will still set cookies. The pref panel rewrite will address this to some extent. (See bug link below). This should also reflect the following bugs: bug 230624 (updates to cookie dialogs) bug 64336 (accept session cookies silently) bug 232744 (remove pref "limit lifetime to n days") bug 222561 (prefs panel update to reflect the above two bugs). The mailnews cookie pref will probably be hidden, so you don't need to document it. The bits covered specifically by this bug look okay, you're trying to hit a moving target right now, which is why some open bugs are listed above. Don't take the pref panel wording as final, but that'll be the general gist unless someone comes up with some sort of showstopper.
Comment on attachment 140099 [details] preview Daniel, don't have multiple TOC's in your document. I know that there are some areas in help that do this, but shouldn't. What we should have: <h1>doc title</h1> <div id="contents">...</div> <h2>TOC topic 1</h2> <p>doc</p> <h3>subtopic of TOC topic 1</h3> Basically you need to change all of your <h1> tags (except for the first one) to <h2> and change all your old <h2> tags to <h3>. You also need to remove the extra TOCs.
Created attachment 202362 [details] [diff] [review] Updated to current situation Used Daniel's patch as a base to update the content, with a few renaming of buttons and options which occurred in the meantime, and update the (c) line.
Comment on attachment 202362 [details] [diff] [review] Updated to current situation >Index: extensions/help/resources/locale/en-US/using_priv_help.xhtml >=================================================================== >@@ -65,34 +65,64 @@ . . >+ <li>Choose one of the following item: items instead of item. . . . . >+ nothing about it. If the <q>Ask for each cookie</q> option is selected in >+ the Cookies preferences panel, you will be again be warned when the website >+ you removed from this list requests permission to set a cookie.</p> Is this correct or should be any website not in the list? I've also noticed the help keeps changing from using site to website and back again. It should probably be site throughout because, as far as I am aware, Cookies are used by applications other than Navigator (mailnews being one).
Created attachment 203105 [details] [diff] [review] Addressed Ian comments (maybe...) - item->items - website->site (only for the cookie part of the file) - rewrote the phrase about Ask for each cookie - bonus: fixed a style nit around the end of the file Is it any better Ian?
Created attachment 203125 [details] [diff] [review] As discussed on IRC.
Comment on attachment 203125 [details] [diff] [review] As discussed on IRC. sr=me if you add text for the "Allow for session" button in the cookie dialog.
Created attachment 203947 [details] [diff] [review] Fixed Neil comment. I've also fixed some wrong items in preferences description and removed some wrongly <strong>ed words... Will carry over sr flag only after Ian has given this another look.
See also bug 311330.
Comment on attachment 203947 [details] [diff] [review] Fixed Neil comment. I thought there was something wrong by the size of this diff compared the previous one, you seemed to have lost half the changes that were in the last patch.
Created attachment 205533 [details] [diff] [review] Hopefully not truncated patch... (21381 bytes)
Created attachment 205641 [details] [diff] [review] Found the problem: the changes website->site were reverted...
Created attachment 205648 [details] [diff] [review] Hopefully restored original patch, plus fixes.
Comment on attachment 205648 [details] [diff] [review] Hopefully restored original patch, plus fixes. >Index: extensions/help/resources/locale/en-US/using_priv_help.xhtml >=================================================================== >+ <li><strong>Accept for current session only:</strong> Select this to delete >+ the cookie the next time you exit your browser.</li> >+ <li><strong>Accept cookies for __ days:</strong> Select this if you >+ want to limit the length of time any cookie can remain on your computer, >+ then type the number of days.</li> >+ <li><strong>Ask for each cookie:</strong> Select this if you want >+ Cookie Manager to warn you each time a site is about to store a cookie Is there a full stop missing after cookie? >+ In addition, you can choose <strong>except for session cookies:</strong> so >+ that &brandShortName; will not warn you if the site is setting cookies >+ which will be deleted when you exit your browser.</li> > </ul> r/a=me with that possible change
Created attachment 205805 [details] [diff] [review] Full stop restored. Changed: Disable cookies -> Block cookies (a few lines above the missing fullstop). Checked in (trunk/branch). Patch ready for checkin.
Checked in (trunk/branch) by Standard8.