remove identical prefs from all.js, rename it to firebird.js, fix installer

RESOLVED FIXED in Firefox0.9

Status

()

Firefox
Build Config
--
major
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Steffen Wilberg, Assigned: Steffen Wilberg)

Tracking

unspecified
Firefox0.9
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

30.31 KB, patch
Brian Ryner (not reading)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
Bug 224578 made modules/libpref/src/init/all.js application independent. It now
 gets exported to bin/greprefs/all.js. So we can remove all identical prefs from
Firebird's all.js (exported to bin/defaults/pref/).

We should rename Firebird's all.js to firebird.js to avoid confusion, as
suggested in bug 207315 comment 22.

Firebird's all.js overrides the grepfrefs/all.js by the way.
(Assignee)

Comment 1

15 years ago
The installer needs to know where to find all.js, security-prefs.js and
xpinstall.js now that they're moved to greprefs.
Summary: remove identical prefs from all.js and rename it to firebird.js → remove identical prefs from all.js, rename it to firebird.js, fix installer
(Assignee)

Comment 2

15 years ago
Created attachment 139241 [details] [diff] [review]
first shot

The all.js, now firebird.js, shrinks down from 30k to 9k.
Also fixes bug 214857. Also relicensing.
(Assignee)

Comment 3

15 years ago
Comment on attachment 139241 [details] [diff] [review]
first shot

You've got to rename mozilla/browser/app/profile/all.js to firebird.js after
applying the patch.
Attachment #139241 - Flags: review?(bryner)

Comment 4

15 years ago
Dup of bug 231170.

Comment 5

15 years ago
*** Bug 231170 has been marked as a duplicate of this bug. ***
(Assignee)

Updated

15 years ago
Blocks: 231176

Comment 6

15 years ago
From bug 224578 comment 21, this is not merely a perf improvement... the
platform-specific overrides are being overridden by the app-level all.js .  This
is mostly my fault, but I would love to see this land soon, to avoid a bunch of
platform-specific firebird bugs.
Severity: normal → major
(Assignee)

Updated

15 years ago
Depends on: 224578
(Assignee)

Comment 7

15 years ago
pref("print.use_native_print_dialog", false); can now be removed as well, see
bug 231298 comment 4.
Comment on attachment 139241 [details] [diff] [review]
first shot

I'll take care of the rename and checkin.
Attachment #139241 - Flags: review?(bryner) → review+
... though I'd like to see many of these prefs moved out of the master all.js
(things specific to mailnews, for example)

Comment 10

15 years ago
Is there a midas-prefs.js for when Midas is built?  Or were they in editor.js?
I also removed two more prefs that were not needed:

nglayout.widget.mode
nglayout.initialpaint.delay

and checked in the patch.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Assignee)

Updated

15 years ago
Target Milestone: --- → Firebird0.9

Comment 12

15 years ago
Can someone ascertain if this caused bug 231338? The *nixian middlemouse prefs
contentLoadURL, paste and scrollbar all seem to have recently been set to false
from their previous state of true.

Comment 13

15 years ago
people, please don't forget to import settings from beos.js too.
and dont forget to include there
settings from already landed patch

as Seamonkey people did:
http://bugzilla.mozilla.org/show_bug.cgi?id=224578#c24
(Assignee)

Comment 14

15 years ago
Sergei, there's no need to do anything on our side because we use
mozilla/modules/libpref/src/init/all.js as well; it gets exported to
bin/greprefs/all.js. So fixing all.js fixed Firebird too.
You need to log in before you can comment on or make changes to this bug.