233574 - Installing extensions crashes Firefox 0.8

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Chris Dolan]

User-Agent:       
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.6) Gecko/20040206 Firefox/0.8

Attempting to download and installing the latest XPI package from
livehttpheaders.mozdev.org (v0.8) in Firefox v0.8 crashes the browser.  This
same XPI works fine in Mozilla v1.6

Reproducible: Always
Steps to Reproduce:
1. Go to http://livehttpheaders.mozdev.org/installation.html
2. Click the first link ("Install version 0.8 of LiveHTTPHeaders now")


Actual Results:  
Download manager appears, then Firefox crashes

Expected Results:  
Download and install XPI, or fail with error message

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

if it works in mozilla, it is extremely unlikely that it's a mozilla bug. 
-> firebird

Comment 2

[Chris Dolan]

ACK, sorry.  Bugzilla reported that "Sorry; you do not have the permissions
necessary to enter a bug against the Firebird product." so I added to Mozilla.

Comment 3

[Benjamin Smedberg]

Need stacktrace or other log data.

Comment 4

[Chris Dolan]

Attachment: OSX Crash log

Comment 5

[Benjamin Smedberg]

Ick... crash occurs during delayed symbol lookup:

 #1   0x8fe106b4 in link_in_need_modules
 #2   0x8fe102d0 in bind_lazy_symbol_reference
 #3   0x8fe00ec0 in stub_binding_helper_interface
 #4   0x05031578 in nsNativeCharsetConverter::UnicodeToNative(unsigned short
const**, unsigned*, char**, unsigned*)
 #5   0x05031ae4 in NS_CopyUnicodeToNative(nsAString const&, nsACString&)

Comment 6

[Jacob Kaplan-Moss]

Attachment: Another crash log

For me, this crash is happening every time I try to install any XPI
extensions... I've included another crash log (hope it helps) from when I tried
to install JSLib, but I've tried a number of extensions and they all cause a
crash.

For the record, I've got a PowerBook G4/400 running 10.2.8; I'm also running
Firefox 0.8.

Comment 7

[Benjamin Smedberg]

This needs some loving... dbaron/brendan/cls, any suggestions?

Comment 8

[cls]

How timely.  We were just discussing adding flags to force symbols to be
resolved at link time since -Bsymbolic no longer does that with GNU ld.  I
didn't see this problem when I was testing last night but it turns out that I
wasn't building xpinstall either (or firefox for that matter).

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What symbol is missing?

Comment 10

[Stefan [:stefanh]]

Appears to worksforme with the Firefox latest nightly (20040214) on Mac OS 10.2.8. 

Comment 11

[Jacob Kaplan-Moss]

Seems to work in the latest nightly (16-Feb-04) for me as well (on 10.2.8)

Comment 12

[Stefan [:stefanh]]

*** Bug 233843 has been marked as a duplicate of this bug. ***

Comment 13

[Stefan [:stefanh]]

*** Bug 234510 has been marked as a duplicate of this bug. ***

Comment 14

[Stefan [:stefanh]]

From bug 233843, comment #7:

"To sum it up: Installing extensions works in: 
1. build from source tarball
2. build from FIREFOX_0_8_RELEASE checkout
3. build from FIREBIRD_0_8_BRANCH checkout
It does not, however, work with the official build."

From bug 233843, comment #13:

> Component Manager: attempting to find symbols in a component alias of type
> (regR/carP/x!bt)
> ## Component Manager: attempting to find symbols in a component alias of type
> (regR/carP/x!bt)
> dyld: /Applications/Firefox.app/Contents/MacOS/firefox-bin Undefined symbols:
> /Applications/Firefox.app/Contents/MacOS/libxpcom.dylib undefined reference to
> _wcrtomb expected to be defined in /usr/lib/libSystem.B.dylib

"When I replace "libxpcom.dylib" with the one from my build (same options as the
official, just built under 10.2.8), everything works fine."

Comment 15

[Wayne Woods]

*** Bug 236032 has been marked as a duplicate of this bug. ***

Comment 16

[Wayne Woods]

*** Bug 235838 has been marked as a duplicate of this bug. ***

Comment 17

[Wayne Woods]

Note that the latter duplicate reported the bug on both OS X AND Linux on the
PowerPC (like bug 234489, which hasn't been set as a dupe of this one yet,
presumably because it's Linux-only).

Comment 18

[Misty De Meo]

In PowerPC Linux, this is *not* fixed when building from CVS source (March
10th), unfortunately.

Comment 19

[Daniel Markham]

Attachment: Three or Four Crashes worth!

Hopefully just adding to the pool of info

Comment 20

[Asa Dotzler [:asa]]

unable to access testcase. Please reopen if you can still reproduce and can
attach or point to a working testcase.

Comment 21

[Asa Dotzler [:asa]]

oops, wrong bug. sorry.

Comment 22

[Julian Squires]

This works when built on 10.2.8, but not in the official build, because the
official build was probably on 10.3, where HAVE_WCRTOMB is defined -- but 10.2
does _not_ HAVE_WCRTOMB.  So, maybe (at least in
xpcom/io/nsNativeCharsetUtils.cpp) this should be conditionalized not just on
HAVE_WCRTOMB, but on whether we're building for OS X or not?

Comment 23

[cls]

Ugh.  This again.  We already have hooks to avoid certain function calls when
targetting a lower version of OS X.  We're going to have to add the wchar
functions to the list.

Comment 24

[cls]

Attachment: make tests for wcrtomb/mbrtowc conditional

Comment 25

[Daniel Veditz [:dveditz]]

Comment on attachment 146302 [details] [diff] [review]
make tests for wcrtomb/mbrtowc conditional

a=dveditz for 1.7

Comment 26

[cls]

The wchar patch has been checked in on the trunk.

Comment 27

[cls]

The patch has been checked in on the 1.7 branch.

Comment 28

[Martin Creutziger [:MMx]]

Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7)
Gecko/20040426 Firefox/0.8.0+ (MMx2000)

I just successfully installed "LiveHTTPHeaders" in my MOZILLA_1_7_BRANCH Firefox
build. (pulled from CVS at around 6:00UTC this morning) 
I built this build in 10.3.3 and tested in 10.2.8. (The OS combination that was
causing the problem)

So I can confirm this as "fixed".

Comment 29

[Misty De Meo]

I've built CVS under LinuxPPC, the other OS causing a problem, and although it
no longer crashes I was still unable to install extensions.

Comment 30

[Misty De Meo]

This bug is *not* fixed under the current version. I have tested in Firefox
0.9.1 under PowerPC Linux, and extensions and themes still cannot be installed.
Clicking "install" simply causes the installer menu to disappear without
installing anything.

Comment 31

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

If it no longer crashes, please file a new bug with details of your problem. 
(Especially interesting will be any errors you get in the process, and a copy of
the extension in question.  Also, testing with a fresh build from the aviary
branch would be helpful.)

Comment 32

[Chris Dolan]

Misty,  This bug is for Mac OSX, not Linux.  I'm the reporter of this bug and
it's fixed for me as of 0.9 and 0.9.1 so I say it remains closed.  Please report
under a different bug if you continue to have problems with Linux.

Comment 33

[Misty De Meo]

(In reply to comment #32)
> Misty,  This bug is for Mac OSX, not Linux.  I'm the reporter of this bug and
> it's fixed for me as of 0.9 and 0.9.1 so I say it remains closed.  Please report
> under a different bug if you continue to have problems with Linux.

I was replying to this bug because my own bug report, reporting this in Linux
(on PowerPC), was closed and referred to this one. I assumed that it meant that
this bug was for Linux as well as Mac OS X.