234259 - new attachment bug comment screwed up when attachment name includes the string "attachment 123456"

Status: RESOLVED DUPLICATE of bug 232861

(Bugzilla :: Attachments & Requests, defect)

Description

[Darin Fisher]

new attachment bug comment screwed up when attachment name includes the string
"attachment 123456 [details] [diff] [review]"

see this bug comment:

http://bugzilla.mozilla.org/show_bug.cgi?id=124029#c190

the HTML appears to have a HREF for "attachment 123456 [details] [diff] [review]" encoded in it, but that
results in a mess with extra quotes, etc. that really screws up the HTML.

Comment 1

[Darin Fisher]

Attachment: screenshow showing the erroneous comment and tooltip text

Comment 2

[Bradley Baetz (:bbaetz)]

caillon, this was from bug 153853.

What happens if an attachment's description cantains 'bug 123'? That breaks too...

I think that we need do do the @things stuff. Replacement text in those regexps
cannot ever expand to somethign that would be matched by a larger regexp.

You can't use @things itself, because then we can't put it back - you need to
use a new array/substitution bit.

Comment 3

[Dave Miller [:justdave]]

*** This bug has been marked as a duplicate of 232861 ***