237136 - Add bookmark dialog changes position on screen when clicking "Show all the bookmarks folders" button

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Hiro]

Even if it pushes the icon of the triangle mark in an add Bookmark dialog, a
bookmark folder list is not displayed.
A push on this button displays the following error messages on Java Script Console.

Error: uncaught exception: [Exception... "Cannot find interface information for
parameter arg 0 [nsIXULTreeBuilder.getIndexOfResource]"  nsresult: "0x80570006
(NS_ERROR_XPC_CANT_GET_PARAM_IFACE_INFO)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarksTree.xml :: selectResource :: line
286"  data: no]

Mac OS X 10.3.2
Use Default theme.
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.7b) Gecko/20040311
Firefox/0.8.0+

Comment 1

[Hiro]

There is no problem for the same reason as bug 237305.
However, if it changes a display / un-displaying, the display position of a
dialog screen will not become settled uniformly.

Comment 2

[Hiro]

Reproducible: Always
Steps to Reproduce:
1.Select "Add Bookmarks..."
2.The button which displays all bookmark folder lists(The button to which the
triangular icon was attached) is pushed.
3.Again, a button is pushed.

Actual Results: 
The display position of a dialog screen changes constantly.

Expected Results: 
The display position of a dialog screen is always fixed.

It is Checking by 2004-03-15 hightly build.

Comment 3

[Hiro]

*** This bug has been marked as a duplicate of 246175 ***

Comment 4

[HARUNAGA Hirotoshi]

reopening.

Comment 5

[HARUNAGA Hirotoshi]

*** Bug 246175 has been marked as a duplicate of this bug. ***

Comment 6

[HARUNAGA Hirotoshi]

changing summary and marking new.
regression.

Comment 7

[jhp (no longer active)]

This is still a problem on Firefox 0.9.  Do any of the firefox developers have
access to a Mac?  This is quite an annoying bug.

Comment 8

[jhp (no longer active)]

I found the expandTree() function in addBookmarks2.js that shows/hides the
directory tree.  Unfortunately, the javascript debugger doesn't seem to work for
Firefox, so I can't debug it on the fly.  If someone can tell me what to look
for, I can take a look at this bug.

Comment 9

[HARUNAGA Hirotoshi]

*** Bug 247724 has been marked as a duplicate of this bug. ***

Comment 10

[Mitch Keller]

Please note that the Bug 247724 (which I filed because I never thought of
"changes position" as the magic words that had previously been used to describe
this behavior when querying bugzilla) includes comments regarding this
moving/jumping/position changing behavior not only for Add Bookmarks but also
Opening <filename> and Customize Toolbar, so debugging this issue probably
shouldn't be restricted to Add Bookmark.

Comment 11

[Mike Connor [:mconnor]]

its mac only, so should be blocking1.0mac

and yeah, this is a pretty obvious blocker

Comment 12

[jhp (no longer active)]

Why is there a separate blocking1.0 flag for mac?  Why not for the other
platforms, also?

Comment 13

[Mike Connor [:mconnor]]

Because Mac 1.0 is going to ship later than Win/Linux 1.0

Comment 14

[jhp (no longer active)]

Attachment: patch

We were zooming in, even when we weren't zoomed out (maximized).

Comment 15

[jhp (no longer active)]

Comment on attachment 155858 [details] [diff] [review]
patch

This patch seems to fix all of the cases I know of, except for the Customize
Toolbar dialog (which has other major problems).

Comment 16

[Asaf Romano (gone)]

CCing Simon,

any progress with the review request?

Comment 17

[Asaf Romano (gone)]

Comment on attachment 155858 [details] [diff] [review]
patch

Javier, can you please ask review from someone else, sfraser is on vacation

(maybe pinkerton?)

Comment 18

[Mike Pinkerton (not reading bugmail)]

i don't follow this at all. first the description talks about a missing
interface. the patch, however, fixes zooming in when we weren't zoomed out.
also, it handle the reverse case (zooming out when we weren't zoomed in). why not?

Comment 19

[jhp (no longer active)]

I don't know about the error in the original description.  That may have been
unrelated.

As for not handling the other case: nsSizeMode_Minimized is handled at the top
of that function (returns NS_ERROR_UNEXPECTED), so the only possible values are
nsSizeMode_Maximized and nsSizeMode_Normal.  I don't know if that function would
ever get nsSizeMode_Maximized when the window is already maximized;  but if it
did, I don't think it would do anything bad to maximize it again.  If you want,
I could just add some code to only maximize the window if the previous state was
nsSizeMode_Normal.

Comment 20

[Asaf Romano (gone)]

CCing Pinkerton, so he'll read your comment...

Comment 21

[jhp (no longer active)]

peterv, can you take a look at this when you get the chance?

Comment 22

[Peter Van der Beken [:peterv]]

Comment on attachment 155858 [details] [diff] [review]
patch

>Index: nsMacWindow.cpp
>===================================================================

>+    nsBaseWidget::GetSizeMode(&previousMode);
>     rv = nsBaseWidget::SetSizeMode(aMode);
>     if (NS_SUCCEEDED(rv)) {

Yeah, so this could be |if (NS_SUCCEEDED(rv) && aMode != previousMode)| and the
rest wouldn't need to change (I think). Either way, r=peterv.

>       if (aMode == nsSizeMode_Maximized) {
>         CalculateAndSetZoomedSize();
>         ::ZoomWindow(mWindowPtr, inZoomOut, ::FrontWindow() == mWindowPtr);
>-      } else
>-        ::ZoomWindow(mWindowPtr, inZoomIn, ::FrontWindow() == mWindowPtr);
>+      } else {
>+        // Only zoom in if the previous state was Maximized
>+        if (previousMode == nsSizeMode_Maximized)

If you do keep this, please make it |else if {|.

Comment 23

[Asaf Romano (gone)]

Simon, can you review?

No separate 1.0mac anymore, nominating for 1.0.

Comment 24

[Asa Dotzler [:asa]]

Comment on attachment 155858 [details] [diff] [review]
patch

too late for 1.0

Comment 25

[jhp (no longer active)]

Checked in to trunk.

Comment 26

[Mitch Keller]

This bug needs to be reopened. I'm running Firefox 1.0.4 on Mac OS 10.4 and Add
Bookmark and Customize Toolbar are both jumping around the screen again.

Comment 27

[José Jeria]

(In reply to comment #26)
> This bug needs to be reopened.

Mitch, please read the 2 above comments. This didnt make it to 1.0.x, but will
be available in Firefox 1.1

Comment 28

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change