Upgrade libical to the most recent version in their CVS

RESOLVED FIXED

Status

RESOLVED FIXED
15 years ago
12 years ago

People

(Reporter: mostafah, Assigned: mostafah)

Tracking

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

15 years ago
 

Comment 1

15 years ago
Created attachment 145195 [details] [diff] [review]
Remove icalcstp*

This removes the following files from our libical which have been removed from
libical CVS and are unused:

icalcstp.c
icalcstp.h
icalcstpclient.c
icalcstpclient.h
icalcstpserver.c
icalcstpserver.h

Updated

15 years ago
Attachment #145195 - Flags: first-review?(mostafah)
(Assignee)

Updated

15 years ago
Attachment #145195 - Flags: first-review?(mostafah) → first-review+

Comment 2

15 years ago
First patch checked in.

Removing icalcstp.c;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstp.c,v  <--  icalcstp.c
new revision: delete; previous revision: 1.5
done
Removing icalcstp.h;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstp.h,v  <--  icalcstp.h
new revision: delete; previous revision: 1.3
done
Removing icalcstpclient.c;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstpclient.c,v  <-- 
icalcstpclient.c
new revision: delete; previous revision: 1.7
done
Removing icalcstpclient.h;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstpclient.h,v  <-- 
icalcstpclient.h
new revision: delete; previous revision: 1.2
done
Removing icalcstpserver.c;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstpserver.c,v  <-- 
icalcstpserver.c
new revision: delete; previous revision: 1.5
done
Removing icalcstpserver.h;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstpserver.h,v  <-- 
icalcstpserver.h
new revision: delete; previous revision: 1.2
done
Checking in objs.mk;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/objs.mk,v  <--  objs.mk
new revision: 1.3; previous revision: 1.2
done
To do this we need to keep local patches, that are not in libical cvs. I tried
to collect the bugs where the patches are from.
bug 259956, bug 239435, bug 241961, bug 165963, bug 191447
Depends on: 273447
(Assignee)

Comment 5

14 years ago
I'll be upgrading libical soon. I'll test the build on windows,linux and Mac.
Please let me know if the upgrade breaks your build.
Status: NEW → ASSIGNED
Created attachment 170396 [details] [diff] [review]
use calendar/libical instead of other-licenses/libical. allmakefiles.sh and Makefile.in part
Attachment #170396 - Flags: first-review?(dmose)
At the moment i'm waiting with the bugs that are file-io related (icalfileset)
because my idea is to use mozilla file IO. these are bug 259956 and bug 241961.
We do need to make sure the line endings are correct that way though.
Also need to test if bug 185145 is still needed. That looks like a workaround
for cygwin perl, maybe that is fixed by now.
(Assignee)

Comment 11

14 years ago
libical has fixed some buffer overflows:
http://sourceforge.net/mailarchive/forum.php?thread_id=6413779&forum_id=10197
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
upgraded libical to the current cvs
Status: REOPENED → RESOLVED
Last Resolved: 14 years ago14 years ago
Resolution: --- → FIXED
Created attachment 173786 [details] [diff] [review]
patch to disable building other-licenses/libical (checked in)

this patch was checked in.
Attachment #170396 - Attachment is obsolete: true
Attachment #170396 - Flags: first-review?(dmose)

Updated

12 years ago
QA Contact: gurganbl → libical
Component: libical → Internal Components
The bugspam monkeys have been set free and are feeding on Calendar :: Internal Components. Be afraid for your sanity!
QA Contact: libical → base
You need to log in before you can comment on or make changes to this bug.