240339 - Bookmarks no longer launch URL

Status: RESOLVED WORKSFORME

(SeaMonkey :: UI Design, defect)

Description

[James Rome]

in the 2004041208 build on XP Pro, when I launch Mozilla, the personal tool bar
is not displayed until I do "manage bookmarks". Then they appear, but clicking
any bookmark does not do anything. Clicking the bookmark from the Manage
Bookmarks list does work.

Selecting a bookmark from the bookmark menu item does not work either!

Comment 1

[R.K.Aa.]

see bug 240288 comment 2 and 3

Comment 2

[James Rome]

The 4/8 build works. 4/11 did not. This is without changing my prefs.js, so I am
not sure the 240288 comment is relevent.

Comment 3

[R.K.Aa.]

It's The One. The fix causing this was checked in 2004-04-10. (bug 230219
comment 13). I built with it right away (on Linux) and got the exact symptoms
you describe. In addition, the >> to the right of personal toolbar vanished,
pushed out of sight when there were "too many" bookmarks there.

Comment 4

[Christos Cheretakis]

Same thing happens on Linux/2004041407. Bookmarks appear again by opening the 
bookmarks tab in the sidebar. 

Comment 5

[R.K.Aa.]

*** Bug 240380 has been marked as a duplicate of this bug. ***

Comment 6

[Matthias Versen [:Matti]]

smoketest B.22 is failing -> Smoketest blocker

Comment 7

[R.K.Aa.]

blocking 1.7?

Comment 8

[James Rome]

Blocking everything. A browser is unusable if you cannot use a bookmark to
access a URL......

Comment 9

[Matthias Versen [:Matti]]

It doesn`t block everything. We branched yesterday and this should not affect
1.7 unless someone got this on a 1.7 branch build.

Comment 10

[R.K.Aa.]

patch in attachment #145902 [details] [diff] [review] should acclaimedly fix this. If that is not in  1.7,
then 1.7 is affected. (Bug 230219)

Comment 11

[Artur Polaczynski]

selfbuild debian/linux unstable

Mozilla 1.7b
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040413

OS:All +

Comment 12

[Daniel Veditz [:dveditz]]

blocking 1.7

Comment 13

[Darin Fisher]

I cannot reproduce this bug using a CVS build of MOZILLA_1_7_BRANCH under Linux.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040415

I tried with and without a new profile.  In both cases, bookmarks seemed to
function normally.

Comment 14

[Darin Fisher]

Also, this bug is WFM regardless of whether I am using the Modern or Classic
theme.  (Same build as mentioned previously.)

Comment 15

[Darin Fisher]

(In reply to comment #11)
> selfbuild debian/linux unstable
> 
> Mozilla 1.7b
> Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040413
> 
> OS:All +
> 

Is this really a 1.7 branch build?  dbaron just today landed a patch on the
trunk to update the UA string to say 1.8a instead of 1.7b.  I suspect you
actually built a trunk build b/c I cannot reproduce this problem on the 1.7 branch.

dveditz: can you reproduce this on the 1.7 branch?

Comment 16

[Daniel Veditz [:dveditz]]

My build is definitely MOZILLA_1_7_BRANCH (windows)  and applying the patch in
bug 230219 makes it go away. I noticed that patch just got checked in, does it
fix the problem on the trunk as well?

R.K.Aa thinks this one was in 1.7 as well (see comment 3 and comment 10)

Comment 17

[James Rome]

So which build do I use to test this with the fix? I am confused about how
branches work

Comment 18

[Artur Polaczynski]

(In reply to comment #15)
> (In reply to comment #11)
> > selfbuild debian/linux unstable
> > 
> > Mozilla 1.7b
> > Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040413

> Is this really a 1.7 branch build?  
 
Propably no, sorry. I Cut&paste from about:

UA is set by config.js 
My build it's from HEAD 

Comment 19

[James Rome]

This seems fixed in the 2004041809 build

Comment 20

[R.K.Aa.]

*** Bug 240613 has been marked as a duplicate of this bug. ***

Comment 21

[R.K.Aa.]

*** Bug 240288 has been marked as a duplicate of this bug. ***