247227 - Cannot create shortcut for pages with no title or invalid characters in title

Status: RESOLVED WONTFIX

Description

[Brodie]

This is the FireFox version of the following Mozilla bugs:

bug 103468 = Mozilla creates .url files with zero byte at end, confusing IE
(Internet shortcut)
bug 78509 = Can't make an Internet shortcut with :, /, \ in title (by dragging
link to desktop)
bug 104933 = Mozilla-generated .url filename without name when page has no title 

These have all been fixed on the Mozilla 1.8 trunk. It would be worthwhile
putting it into Firefox 1.0. The patch for all of these problems is patch 5 at
bug 103468 
http://bugzilla.mozilla.org/attachment.cgi?id=149548&action=view

Note that this patch uses the localized string "noPageTitle" from
chrome://navigator/locale/pageInfo.properties 
It is possible that this is different in Firefox?

Comment 1

[Hiro]

The Mac version of AVIARY_1_0_20040515_BRANCH is also reproduced.

Comment 2

[Brodie]

This is a Windows only bug (in a Windows specific source file). The patch as 
applied to 1.8 trunk will fix Windows only, so I think you need to open a new 
bug for the same issue against Mac. Is there already a bug for the same problem 
on Seamonkey?

Comment 3

[Hidehiro Kozawa]

Bug 159773 is dup of this and l10n problem.
Shift-JIS contains 0x5c(\).
For Japanese this bug is bigger problem than for others.

Comment 4

[Brodie]

Nominating for blocking 1.0
Patch available.

Comment 5

[Asa Dotzler [:asa]]

p4 priority - not a blocker. if a patch materializes, please nominate for aviary
approval. 

Comment 6

[Brodie]

For crying out loud read the bug, even just a little. There is a patch 
already. It's been in the trunk for ages. From comment #0:
--
The patch for all of these problems is patch 5 at bug 103468 
http://bugzilla.mozilla.org/attachment.cgi?id=149548&action=view
--

Comment 7

[Brodie]

Created attachment 161099 [details] [diff] [review]
patch 5 from bug 103468 

I don't have access to source at the moment, nor am I doing development at
moment, so I can't verify this patch still works. It's probably bitrot, as is
normal with Moz development.

Comment 8

[Asa Dotzler [:asa]]

s/patch/fully reviewed patch/

Comment 9

[Brodie]

Created attachment 166229 [details] [diff] [review]
fully reviewed patch updated for firefox 1.0 branch

This is the patch from bug 103468 simply applied and re-created for the the
Firefox 1.0 source branch. It fixes the mismatch between the patch for the 1.8
trunk and the Firefox branch and now applies cleanly to the branch. Let's get
this into the next Firefox point release to fix this problem. For examples of
what this fixes see the testcases in attachment 149729 [details], 'testcases' on bug
103468.

Comment 10

[Brodie]

Comment on attachment 166229 [details] [diff] [review]
fully reviewed patch updated for firefox 1.0 branch

This patch is unchanged from that which has R/SR at bug 103468.

Comment 11

[Mike Connor [:mconnor]]

The plan at this point is to push aggressively towards 1.1, with 1.0.x being
security-only releases, so I doubt we'll take this on branch.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

*** Bug 281982 has been marked as a duplicate of this bug. ***

Comment 13

[Robert Strong [:rstrong] (use needinfo to contact me)]

Firefox 1.0 is no longer supported so resolving -> wontfix

Note: this was fixed on trunk quite some time ago