Closed Bug 247572 Opened 21 years ago Closed 19 years ago

Fix Update to use valid HTML4

Categories

(addons.mozilla.org Graveyard :: Public Pages, enhancement)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: wolf, Assigned: Bugzilla-alanjstrBugs)

References

(
URL
)

Details

Attachments

(2 obsolete files)

Mozilla Update currently uses fairly rough HTML4/transitional, which needs to be fixed up.
QA Contact: mozilla.update → fantasai.bugs
please, don't forget to remove "font-weight: bold;" from most elements, it looks very ugly as of today.
Daniel, you like these kind of bugs IIRC.
I don't have access to the site
Keywords: polish
Severity: normal → enhancement
Keywords: polish
OS: Windows XP → All
Hardware: PC → All
*** Bug 253029 has been marked as a duplicate of this bug. ***
From my duped bug, some heading substitutions: <div class="header-top"> -> <h1> <div class="boxheader"> -> <h2> <div class="itemtitle"> -> <h2> or <h3> if you make <span class="listtitle"> -> <h2> The FAQ page needs the above and <DIV class="faqtitle"> -> <h2> <DIV class="itemtitle"> -> <h3> Is there a way to create and/or submit patches i.e. is update.mozilla.org in CVS somewhere? Based on bug 247008 and comment 3 I guess not.
*** Bug 247767 has been marked as a duplicate of this bug. ***
Blocks: 249447
Status: NEW → ASSIGNED
The frontend code is now in CVS, for anyone who wants to poke it. Please use stylesheets as much as possible
Sorry for the bugspam but how do I get to the cvs?
Depends on: 260157
*** Bug 261338 has been marked as a duplicate of this bug. ***
Summary: Mozilla Update needs it's HTML improved → Mozilla Update needs its HTML improved
It would be really good if links to previous and next page in each category were implemented also in the document head. I mean something like this: <head> ... <link rel="previous" href="..." title="Previous page"> <link rel="Next" href="..." title="Next page"> ... </head> as described in http://www.w3.org/TR/html401/types.html#type-links and other parts of HTML 4.01 That links are displayed on Link Toolbar in Mozilla, which is also implemented via Link Toolbar extension in Firefox. Opera has a similar toolbar (and, afaik, Mosaic also). And it's a comfortable way to turn pages.
*** Bug 263954 has been marked as a duplicate of this bug. ***
Whiteboard: fixed by 260157
Blocks: 260157
No longer depends on: 260157
*** Bug 268507 has been marked as a duplicate of this bug. ***
Bulk Moving Web Site bugs to new component. (Filter: massumowebsitespam)
Component: Update → Web Site
Product: mozilla.org → Update
Version: other → unspecified
Target Milestone: --- → 1.0
260157 does not fix this problem. The html is still bad.
URL: http://validator.w3.org/check?uri=htt...
Whiteboard: fixed by 260157
Update-beta made some improvements in this area. Full HTML4 compliance wasn't one of them. Tweaking bug's status to be more accurate. Also reassigning this to nobody, as I don't intend to fix this fully. Also, I'm not likely to accept patches for this for update-beta, as I'm working on wrapping up the development and getting it live.
Assignee: psychoticwolf → nobody
No longer blocks: 249447, 260157
Status: ASSIGNED → NEW
QA Contact: fantasai.bugs → mozilla.update
Summary: Mozilla Update needs its HTML improved → Fix Update to use valid HTML4/Transitional
Target Milestone: 1.0 → Future
Version: unspecified → 0.9
Blocks: validate
Assignee: nobody → Bugzilla-alanjstrBugs
Attached patch html escape ampersands (obsolete) — — Splinter Review
I skipped the themes directory since it should be nearly identical to the extensions directory.
I'd like to get this checked in one chunk at a time. The bulk of the errors are probably just escaping the ampersand.
Status: NEW → ASSIGNED
Attachment #167614 - Flags: first-review?(psychoticwolf)
See Comment #15.
This is for a future release (see Target Milestone)
Fair enough, but save yourself the trouble for now, because most of the pages are about to bitrot you again. (The new styles are coming, and most of the pages are reorganized for this)
Only one bug now. I'll let someone else fix it.
Assignee: Bugzilla-alanjstrBugs → psychoticwolf
Status: ASSIGNED → NEW
Comment on attachment 167614 [details] [diff] [review] html escape ampersands This patch no longer applies.
Attachment #167614 - Attachment is obsolete: true
Attachment #167614 - Flags: first-review?(psychoticwolf) → first-review-
Assignee: psychoticwolf → nobody
The URL given validates. Can this be marked WORKSFORME (it is unclear which patch fixed this)?
Nice, even HTML 4.01 Strict. This is the only page I found that does not validate yet: http://update-beta.mozilla.org/about/ It's mainly "&" which need to be escaped. Also, use <del> instead of <s>.
Summary: Fix Update to use valid HTML4/Transitional → Fix Update to use valid HTML4
Assignee: nobody → Bugzilla-alanjstrBugs
Status: NEW → ASSIGNED
(In reply to comment #24) > Nice, even HTML 4.01 Strict. > > This is the only page I found that does not validate yet: > http://update-beta.mozilla.org/about/ > It's mainly "&" which need to be escaped. Also, use <del> instead of <s>. Fixed. I had those DB entries valid in my development copy, but forgot to copy them to the real thing, oops. :-)
Can't find any more errors.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Please have a look at the validation of https://addons.mozilla.org/themes/showlist.php?application=firefox&category=Newest&numpg=10&pageid=2 There is something missing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Future → 1.1
Version: 0.9 → 1.0
<div id="mainContent"> is missing its closing tag. Though why this bug was /reopened/ to address this, instead of filing a regression bug. I don't know.
Attached patch fixes invalid html (obsolete) — — Splinter Review
Yeah.. it looks like <div id="mainContent"> was the one without the close tags. This patch adds them right before the "mBody" close tag and adds comments saying which tag they were for (showlist.php in extensions and themes). If you put it anywhere before that, the page number nav bar isn't centered. There was also an extra </a> on index.php that I got rid of.
Attachment #186427 - Flags: first-review?(colin.ogilvie)
(In reply to comment #30) > Created an attachment (id=186427) [edit] > fixes invalid html Has this patch been committed and/or the problem been fixed? If not, can somebody active review the patch and do what needs to be done?
Setting correct QA Contact and CCing morgamic concerning this web site bug.
QA Contact: mozilla.update → web-ui
This bug shouldn't be reopened, it originally dealt with makign Update 0.9 --> 1.0 valid HTML4. Bugs caused by more recent changes should've been filed as seperate regressions, as they have nothing to do with this old bug.
The new template brought with it a drastically changed set of CSS docs with modifications to a lot of the HTML. The patch is now invalid, as is this bug. This would be be handled by filing another bug, and listing specific pages there. It should be noted that when the template was updated in December with the 1.5 release, they were checked for validity. If some aren't valid, please note them in a new bug and provide the URL -- which is utlimately more helpful than saying, "it's broken".
Status: REOPENED → RESOLVED
Closed: 20 years ago → 19 years ago
Resolution: --- → INVALID
Attachment #186427 - Attachment is obsolete: true
Attachment #186427 - Flags: first-review?(colin.ogilvie)
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Patch isn't applied -- so it's a WFM not an INVALID. Sorry for the spam. <3
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → WORKSFORME
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: