Closed Bug 248264 Opened 20 years ago Closed 20 years ago

update and compress Help images

Categories

(Firefox Graveyard :: Help Documentation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox1.0

People

(Reporter: mamozrk, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file, 17 obsolete files)

39.37 KB, image/png
Details
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-GB; rv:1.7) Gecko/20040616 ignore-this-UA-string
Build Identifier: http://downloads.mozdev.org/firebirdhelp/fbh1.1.xpi

The help package available at 
<http://downloads.mozdev.org/firebirdhelp/fbh1.1.xpi>
could be better packaged to minimise the download size.

The PNG images could also be better compressed by (a) switching from 24-bit to 
8-bit images and (b) recompressing with PNG-optimisation tools.

Reproducible: Always
Steps to Reproduce:




I've filed this following the discussion in n.p.m.l10n.

For the first part of the optimisation, help.jar and fbh1.1.xpi should be
archived using the same procedures as en-US.jar and langenus.xpi:

 * Files should be stored without compression in the JAR file
 * the XPI should be archived using maximum compression.

For the second part, I am willing to recompress the images.  Recompressing
just the five largest images from the currently available XPI and repackaging
as above saved me over 200 kB.

Following a newsgroup reply from Steffen Wilberg, I'm waiting for the images
to catch up with the UI again before submitting optimised PNGs.

(Feel free to alter the severity - I couldn't decide between min, triv or enh).
The images are currently not part of the Firefox download, because they're
stored on mozilla.org, like
http://mozilla.org/projects/firefox/help/0.9/opt_general.png. But compression
would improve the user experience, because the images appear sooner in the Help
Viewer.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Minimising download size for Firefox Help (image compression) → update and compress Help images
--> me

Jeff, was it you or Nilson that did the image optimization?

I'm not sure if moving to 8-bit will reduce the quality an unacceptable amount,
but if we're not using maximum compression, we need to get that changed.
Assignee: bugs → rlk
Reporter: Note that the Firefox Help 1.1 package on the Help Viewer page is
obsolete. The latest version is Help 1.2, which is included in Firefox 0.9. Help
is no longer posted to the Help Viewer website anymore because it ships with
Firefox.
so... wontfix?
Huh? What's wrong about updating the images to reflect Firefox 0.9 changes?
And what's wrong with compressing these images much better? Just because they're
not part of the downlaod doesn't mean compressing them wouldn't help. As I said
in comment 1, compressing the images improves the user experience because they
appear faster.
Attached image Paletted, optimised, interlaced image (obsolete) —
(Reply to comment #2):

If you're referring to the compression of the JAR/XPI as a whole, the 
Help bundled with FF0.9 is correctly stored (ie without any compression).
This lets the 7zip compression do its magic and obtain the smallest file size.

As to image quality degradation, I'll let you decide; but note that the
largest images (opt_*.png) have already been resized, so already some of 
the information in the images has been lost.

The largest image, 
http://mozilla.org/projects/firefox/help/0.9/opt_downloads.png
is one that needs updating (I would oblige but I haven't a WinXP system);
I've attached a paletted, optimised version so you can judge.

Note it's interlaced (so it shows a low-res version quickly); a 
non-interlaced version saves another 5kB.
That's great, Mark! The original image (link in comment 7) has 75.14 KB, your
version only 24.9 KB. That saves 50.24 KB or two thirds! And I can't tell the
difference without switching back and forth very quickly.

As Ben said in his forum post, we'll have a Firefox 0.9.1 in the next few days,
which contains (besides a ton of bugfixes of course) a theme update and an
updated download manager (see the screenshot in bug 246618). I'd recommend to
wait until then and take new screenshots after that.
http://forums.mozillazine.org/viewtopic.php?t=90193
Okay, I volunteer to take 0.9.1 screenshots on WinXP, with
ClearType/Antialiasing switched off, save them as PNG-24, and upload them to my
webserver.
> Okay, I volunteer to take 0.9.1 screenshots on WinXP, with
> ClearType/Antialiasing switched off, save them as PNG-24, and upload them to my
> webserver.

That would be great! Your contributions would be greatly appreciated! If you
have gila access, feel free to post the new images to the Firefox project page
(at http://mozilla.org/projects/firefox/help/0.9.1/img.png). Or I can post them
if you don't.

I can also update the links in the help docs once the images are posted.
The plan is that I take the screenshots, save them as loss-less png, and upload
them to my server.
Then Mark grabs them, applies his compression magic, and uploads them to
mozilla.org or sends them to R.J.

I can probably start soon since I'm just using a build with the theme changes
(which so far consist of new toolbar icons and icons for the buttons in the
extension/theme manager). I don't know if there's more to come though.
Attached file Firefox 0.9.1 screenshots (obsolete) —
Mark, these are the screenshots I took with a Firefox 0.9.1 build. I decided to
attach them to this bug, they might be useful in the future.

They're still in (large but loss-less) PNG-24. They're 291 KB in size right
now. I guess you can shrink them to 100 KB or so?

I included all the images I found in Firefox Help, with the exception of
opt_themes.png and opt_extensions.png, because these panels are gone since
Firefox 0.9. I added extension_manager.png and theme_manager.png instead.
Attachment #151584 - Attachment is obsolete: true
Attached file Compressed images (obsolete) —
Compressed version of attachment 151831 [details].

I've scaled several of the images (opt_*.png, cookie_ask.png and the two new
*_manager.png).  The opt_*.png images were all previously 425x353 px, so I've
retained that size; the other images keep comparable scale.
cookie _ask, _list and _manager were all incorrectly scaled in the xhtml file
(ie the <img/> tag had incorrect width & height attributes);

All images over 10kB are interlaced; the total size is 159 kB, not Steffen's 
predicted 100 kB, since (a) you get the biggest savings from the largest files
and (b) the earlier images were less well compressed (due in part to the
resizing of several).
Attachment #151905 - Attachment mime type: application/x-tar → application/zip
R.J., the new images you uploaded yesterday weren't the one I have taken and
Mark has compressed. They're about twice as large as the images in attachment
151905 [details]...
(In reply to comment #14)
> R.J., the new images you uploaded yesterday weren't the one I have taken and
> Mark has compressed. They're about twice as large as the images in attachment
> 151905...

I never uploaded your images. I uploaded images for 1.0 RC 1 help that David
Tenser provided me. They are new from the 0.9 help images, so they may need to
be  redone.

I'll look into getting these checked in.
Can someone post recent images? These images don't appear to be synced with the
latest help images. These are different dimensions, and not sure what release
they were taken off of.

It looks like you're trying to make new images. If you are, you need to have the
same dimensions. I can post the current help images if you'd like.
(In reply to comment #16)
> Can someone post recent images? These images don't appear to be synced
> with the latest help images. These are different dimensions, and not
> sure what release they were taken off of.
They were taken off of Firefox 0.9.1. A lot has changed since then, and I expect
further significant changes up to 1.0PR. I'll make new screenshots when we're
nearer to that.

> It looks like you're trying to make new images.
Of course, since the images used before were pretty out-of-date.

> If you are, you need to have the same dimensions.
Why? It's easier to adjust the width and height parameters in the code than to
produce screenshots with the exact same dimensions.

> I can post the current help images if you'd like.
That would be helpful.
(In reply to comment #17)
> They were taken off of Firefox 0.9.1. A lot has changed since then, and I expect
> further significant changes up to 1.0PR. I'll make new screenshots when we're
> nearer to that.

Did you make new images? Let's instead update the old ones with the
optimizations. This is easier because then we won't have to update the
dimensions in all the help docs (something we can't do for 0.9.1).

> Of course, since the images used before were pretty out-of-date.
> 

see above about dimensions.

> Why? It's easier to adjust the width and height parameters in the code than to
> produce screenshots with the exact same dimensions.

Because 0.9.1 is released, you need to have the same dimensions so they don't
appear weird in the Help Viewer.

What techniques are you using? I could update the website images real quick
using your techniques. The images are on the web, so why not change the 0.9
pics? It could only help 0.9.1 users.


> That would be helpful.

I can post them, but don't you have gila access steffen? Just making sure we
aren't having two different definitions of latest.
Assignee: rlk → steffen.wilberg
Attached file Compressed Images from 0.9.2 (obsolete) —
These images are optimised versions of the files referred to by the help files
in FF 0.9.2. (all in <http://www.mozilla.org/projects/firefox/help/0.9/>)

Again, images over 10kB are interlaced.  3 images used in cookies.xhtml
(_ask, _manager & _list) have been rescaled and white borders added to cope
with the current mismatch between image size and <img width/height> attributes.
Attachment #151905 - Attachment is obsolete: true
How close are we to having this finished?  Technically, the images should
probably be ready by 1.0PR so that localizers know exactly what the screenshots
display.

Also (the issue can probably be lumped in with this one), the URLs to the images
aren't consistent.  Some are in the 0.9 directory, while others are in 1.0rc1. 
Just do:

grep -R "projects/firefox/help/" browser/components/help toolkit/components/help

...and you'll get the full list.
Attached file Compressed images for 1.0rc1 (obsolete) —
As before, optimised versions of the images referred to by the 1.0rc1 branch
of FF (pulled by CVS this morning).  Only images below 
http://mozilla.org/projects/firefox/help/1.0rc1/ are included; attachment
154771 [details] contains optimised versions of the images in 
http://mozilla.org/projects/firefox/help/0.9/

Three images (cookie_ask.png, cookie_list.png and firefox-toolbar.jpg) appear
to be invalid.
Attachment #151831 - Attachment is obsolete: true
Attachment #154771 - Attachment is obsolete: true
Attachment #156418 - Attachment is obsolete: true
(In reply to comment #22)
> Created an attachment (id=156425)
> current and compressed images for immediate upload
> 
> These are images which are still current and which Mark already compressed,
> taken from the attachments above.
> I'd recommend to upload these to the 1.0rc1 directory immediately.
> 
> 
> I have to take new screenshots for these files:
> http://mozilla.org/projects/firefox/help/0.9/download_manager.png
> http://mozilla.org/projects/firefox/help/1.0rc1/cookie_ask.png
> http://mozilla.org/projects/firefox/help/1.0rc1/cookie_manager.png
> http://mozilla.org/projects/firefox/help/1.0rc1/opt_advanced.png
> http://mozilla.org/projects/firefox/help/1.0rc1/opt_connection.png
> http://mozilla.org/projects/firefox/help/1.0rc1/opt_imagemanager.png
> http://mozilla.org/projects/firefox/help/1.0rc1/opt_javascript.png
> http://mozilla.org/projects/firefox/help/1.0rc1/opt_webfeatures.png
> 
> I'll attach them soon, so Mark can compress them.

If you have new pictures, you need to update the image sizes in the help docs.
Attached file new and yet uncompressed images (obsolete) —
These are the new screenshots.
Mark, can you do your compression magic once again, please?

R.J., updating the image sizes is no problem. But do we need to specify these
at all if they are in the desired size?
There you go.

Steffen, if you specify the image sizes, the Help doesn't have to reflow on
finding out the image dimensions.
Attachment #156449 - Attachment is obsolete: true
R.J. uploaded the images. This patch makes the necessary adjustments.
Attachment #156425 - Attachment is obsolete: true
Attachment #156609 - Attachment is obsolete: true
Attachment #156857 - Flags: review?(rlk)
Mark, could you provide a 75% version of these, please?
http://mozilla.org/projects/firefox/help/1.0rc1/cookie_list.png
http://mozilla.org/projects/firefox/help/1.0rc1/cookie_accept.png
We're using shrunken versions everywhere else.

The patch above still refers to the large versions because Firefox scales images
so horribly.
Blocking the tracking bug since it affects Help content, see the patch.
Blocks: 253104
Target Milestone: --- → Firefox1.0beta
Comment on attachment 156857 [details] [diff] [review]
change pathnames and image resolutions [checked in: comment 30]

r=rlk@trfenv.com
Attachment #156857 - Flags: review?(rlk) → review+
Patch checked in.
It's time for one of those oh-so-anal comments everyone just loves to get:

The screenshots of the extension manager and the theme manager seem to be from
an unofficial build (notice the unofficial icon in the upper left of each
window).  The screenshots should be from an official build because of the
non-standard icon.  (...or at least I'm assuming that's the reason the icon is
different.  I'm in Linux right now, and in GNOME 2.6 there's no icon there at
all.  It's probably a Windows thing, but I'm not rebooting just to test an icon
issue.)

I took a look at as many of the other uploaded images as I could, and those two
seem to be the only ones exhibiting the problem.  (The problem of being able to
find what images are present is something of a hindrance to doing this; the
Bonsai directory view of mozilla.org is difficult to find even when you have an
idea how to get it.  Even from there, viewing files doesn't seem to be doable
without manually typing in filenames to an already-completed URL in another tab.
 Grrr...)

The two affected files:
<http://www.mozilla.org/projects/firefox/help/1.0rc1/extension_manager.png>
<http://www.mozilla.org/projects/firefox/help/1.0rc1/theme_manager.png>
Jeff, you're right, they're missing the official branding. Thanks for noticing.
I'll attach new images for the Extension and Theme Manager soon. They're indeed
the only ones being affected.

The command you provided in comment 20 should give you the full list of images
currently being used. The images which R.J. uploaded are in attachment 156425 [details]
and attachment 156609 [details].
Attachment #156857 - Attachment is obsolete: true
Attached image theme manager, large and uncompressed (obsolete) —
Mark: Could you please tell us lokalisers, what you do to shrik the images?
We'll need to do to pretty much the same with localised images.
Attached file three-quarter scale images (obsolete) —
Optimised, three-quarter scale versions of

cookie_accept
cookie_list
extension_manager
theme_manager

as requested in comments 27, 31-34
I've uploaded the images we already had in the 1.0rc1 dir plus those from
comment 36 to
http://www.mozilla.org/projects/firefox/help/1.0/cookie_accept.png
http://www.mozilla.org/projects/firefox/help/1.0/cookie_ask.png
http://www.mozilla.org/projects/firefox/help/1.0/cookie_list.png
http://www.mozilla.org/projects/firefox/help/1.0/cookie_manager.png
http://www.mozilla.org/projects/firefox/help/1.0/download_manager.png
http://www.mozilla.org/projects/firefox/help/1.0/extension_manager.png
http://www.mozilla.org/projects/firefox/help/1.0/firefox-toolbar.png
http://www.mozilla.org/projects/firefox/help/1.0/first.png
http://www.mozilla.org/projects/firefox/help/1.0/help-buttons.png
http://www.mozilla.org/projects/firefox/help/1.0/last.png
http://www.mozilla.org/projects/firefox/help/1.0/next.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_advanced.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_connection.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_downloadaction.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_downloads.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_fontsandcolors.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_general.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_imagemanager.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_javascript.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_languages.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_plugins.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_privacy.png
http://www.mozilla.org/projects/firefox/help/1.0/opt_webfeatures.png
http://www.mozilla.org/projects/firefox/help/1.0/pg-landscape-small.png
http://www.mozilla.org/projects/firefox/help/1.0/pg-portrait-small.png
http://www.mozilla.org/projects/firefox/help/1.0/previous.png
http://www.mozilla.org/projects/firefox/help/1.0/print.png
http://www.mozilla.org/projects/firefox/help/1.0/searchbar.png
http://www.mozilla.org/projects/firefox/help/1.0/theme_manager.png
http://www.mozilla.org/projects/firefox/help/1.0/urlbar.png

I left out
http://www.mozilla.org/projects/firefox/help/1.0rc1/firefox-toolbar.jpg since
that is broken and unused.

We've already dropped these two earlier:
http://www.mozilla.org/projects/firefox/help/0.9/arrow-dn-sharp.png
http://www.mozilla.org/projects/firefox/help/0.9/arrow-up-sharp.png

I'll make a patch to change the pathnames and some image sizes (comment 36) soon.
I just (2004-09-16 00:35) landed this on the branch. It doesn't apply on trunk
mostly, I guess we need to just copy over the files and check them in.

I also changed chrome://browser/skin/Popup-blocked.png (which is gone) to the
new chrome://browser/skin/Info.png.

And I updated the copyright dates. I suggest to do this on every modified file
from now on to help localizers.

Thanks again to Mark for compressing the images (comment 36).
Attachment #156882 - Attachment is obsolete: true
Attachment #156883 - Attachment is obsolete: true
Attachment #157127 - Attachment is obsolete: true
Attachment #156857 - Attachment description: change pathnames and image resolutions → change pathnames and image resolutions [checked in: comment 30]
Severity: minor → normal
Target Milestone: Firefox1.0beta → Firefox1.0
The Extension Manager image needs to be updated - those three "buttons" to the
right of each extension are no longer present.
Steffen, is this done?  It's cluttering up the open Help bugs list.
It's an ongoing process. We already need to update the Extension and Theme
Manager images. And we'll have to update the Advanced Options image as soon as
bug 172962 is fixed.
(In reply to comment #35)
> Mark: Could you please tell us lokalisers, what you do to shrik the images?
> We'll need to do to pretty much the same with localised images.

I've uploaded a how-to onto Henrik Lynggaard's l10nWiki
(eventually I plan to put it onto the l10n pages at m.o):
http://server.lynggaard.org/l10nWiki/Wiki.jsp?page=HowToOptimiseFirefoxHelpImages

Also announced on n.p.m.l10n
Some of the Options window screen shots need to be redone (or at the least
edited) to "completely" fix bug 254982.  Some have a nice fade at the top that
obscures the name, but others display the (sometimes incorrect) title.
Right, we should use the fade on all the Options panels. 

To do: EM, TM, Advanced Options, Print button.
*** Bug 262736 has been marked as a duplicate of this bug. ***
Attached file Options panels with fades (obsolete) —
I've faded out the following:

opt_general.png   425w x 305h
opt_downloads.png 425w x 305h
opt_privacy.png   425w x 305h

They've all got new heights (if that's a problem, say, and I'll pad them back 
out).
I've not got an XP system available, so I can't generate the new EM, TM and 
Advanced Options images - Steffen, can you generate them and attach them here?
(In reply to comment #46)
> They've all got new heights (if that's a problem, say, and I'll pad them back 
> out).

It would be preferable if the heights were the same (even if only for the sake
of the localizers who wouldn't really like an extraneous change like this).
Mark, here you are. We should indeed keep the image sizes from comment 37.
Comment on attachment 161836 [details]
Options panels with fades

Sigh. Bug 253738 just introduced new icons in the Options panel, see attachment
161926 [details]. I'll take new screenshots soon.
Attachment #161836 - Attachment is obsolete: true
Here are the new screenshots for the Options panel, as well as the EM, TM and
Print images from before.
Attachment #159070 - Attachment is obsolete: true
Attachment #161909 - Attachment is obsolete: true
FYI: Help icons got updated.  The image used in "Using Firefox Help" needs to be
updated.

(Incidentally, the new shot should not have words in it, because having words
makes it a localization issue, whereas not having words means it can be directly
copied by localizers.)
> FYI: Help icons got updated.  The image used in "Using Firefox Help"
> needs to be updated.
I noticed that. But of the buttons we're displaying in the doc, only the
Show/Hide sidebar icon got changed, and that's hardly noticeable unless you look
back and forth between the toolbar and the image.

> (Incidentally, the new shot should not have words in it, because having words
> makes it a localization issue, whereas not having words means it can be directly
> copied by localizers.)
Hmm, but changing the image size is evil as well, because I'd have to update the
doc.
(In reply to comment #52)
> I noticed that. But of the buttons we're displaying in the doc, only the
> Show/Hide sidebar icon got changed, and that's hardly noticeable unless you
> look back and forth between the toolbar and the image.

Hmm...it still would be a good idea to change it (and the also-obsoleted Print
icon in Help, if it's not the Print icon mentioned in the last attachment), but
you do have a point.

> Hmm, but changing the image size is evil as well, because I'd have to update
> the doc.

Point (which I really should have remembered as I did in comment 47).  Let's do
this for the After Firefox 1.0 timeframe.

Because I don't know the details of the branch->trunk merge after 1.0 is
released, I don't know if now's a good time to do this or not.  Probably later
today I'll do some asking around about the "plans" for the remerge to see
whether it would present a problem to start fixing things on trunk that aren't
fixed on aviary.  (Specifically, the question would be whether the merge process
will be modularized, bug-ized [bug assignees handle their merges], driven
top-down [primarily by Mozilla folks], or handled another way.  If the process
will safely ignore properly-synced files, making trunk-only changes now is
easily possible.)
(In reply to comment #50)

Voila.	Squashed, faded version of attachment 162063 [details] [diff] [review].
Sizes back to as they were.

This ZIP also (after borrowing an XP machine) contains cookie_ask.png, which is
a second shot of the privacy panel.
Comment on attachment 162367 [details]
Options panels, EM, TM, print [checked in: comment 55]

Thanks, Mark. I uploaded the images. The list in comment 37 is still recent.

Jeff, the print button is updated as well. I don't recommend do trunk work
right now. We might have to do last-minute-changes on the branch, and merging
is easier with files being the same on branch and trunk.

I imagine that the great trunk-merge will be done with different methods. E.g.,
you just have to copy browser.js, because there have been 124 checkins on the
branch until now, and you can't port every single checkin. The same applies for
the extension system. Changes in other areas, which far less changes, might be
ported bug by bug. But I'm only speculating. Maybe it will be a big copy from
branch, and recheckin of trunk fixes.
Attachment #162367 - Attachment description: Options panels, EM, TM, print → Options panels, EM, TM, print [checked in: comment 55]
Do any images currently need any processing (fading, scaling or compressing) for
1.0?

AFAICT, all the images that need doing are done; feel free to correct me, though.
The download manager has got a new image on the Clean Up button. But that's a
bit too trivial to bother IMHO.

And the cookie_ask.png image doesn't show the new images on the left. That's
purely cosmetic as well. Should we fix it?
(In reply to comment #57)

> And the cookie_ask.png image doesn't show the new images on the left. That's
> purely cosmetic as well. Should we fix it?

Bother.  I misspelt it in attachment 162367 [details], as "cookie-ask.png" ('-' not '_').
Sorry.
> Bother.  I misspelt it in attachment 162367 [details], as "cookie-ask.png" ('-' not '_').
> Sorry.
Never mind. I should've noticed it. I just uploaded the new image.
Attached image advanced options
I've created a new advanced options screenshot because of bug 268045.
Mark, can you spare a few minutes today or tomorrow, please? If you can't, I'd
try to shrink and compress it myself.
Attachment #162063 - Attachment is obsolete: true
Attachment #162367 - Attachment is obsolete: true
Bug 268045 is pretty much wontfix. Ben said "we're gold, sorry."
So we don't really need a new image either.
I don't think we need a 1.0 image tracking bug any more.  We can open new
versions of this bug as necessary for later releases.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: