248399 - Update Sunbird classic theme

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Chris Cook]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9

Calendar needs a new look. I am opening this bug, as requested, to track the
revision of the classic theme to support toolkit and to have updated graphics.
At least this is my understanding of the necessary work.

Todo:
1. Create new graphics for all application icons and toolkit dialogs (options,
themes, extensions, etc.)
2. Update theme style if necessary

Questions:
1. Will this skin be migrated into classic.jar (like other toolkit apps) or
remain in calendar.jar?
2. Will the modern theme continue to be supported?

I am uninformed about a possible contest for the theme revision so I'll let
others add that info if pertinent.

I have started work updating the theme with new icons created by Mark Carson.
I'll report further when there is something interesting to show.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Chris Cook]

CC'ing [e-mail] as requested.

Comment 2

[Justin Wood (:Callek)]

My understanding will be that Sunbird itself needs a new theme, Suite themes
will still be supported, though we need a new theme for our Standalone application.

IMO, also a `*stripe` theme would be useful for the firefox/TB installs.

(Marking NEW)

Comment 3

[Chris Cook]

Is the intention is to somehow support both toolkit and xpfe?

The other stand-alone apps have used the classic skin for their default theme
(and have stopped supporting modern). How would a new theme _and_ classic and
modern be supported by calendar?

Comment 4

[Justin Wood (:Callek)]

because we are an extension *and* stand-alone.

Comment 5

[Chris Cook]

I was intending to post patches (to classic) for the new skin. For a new theme,
should I just post the complete files (css, png, etc.) to this bug? How will
paths be handled? Should I just post a jar?

Comment 6

[Justin Wood (:Callek)]

For the new theme I would suggest a zip file for the theme itself and seperately
PATCH files for the changes made to makefiles, etc.  (and jar.mn, etc.)

but this is me, and mostafah may prefer a different method.

Comment 7

[Simon Paquet [:sipaq]]

Updating summary to better reflect reality. The call is currently for a new
default theme for Sunbird. And that's what we should focus on.

It should be no big problem to checkin a new theme into the sunbird cvs
directory and hook this up with some makefile-fu.

Updating or changing the calendar extension theme(s) is a whole different matter
and should be discussed in the calendar newsgroup/mailinglist.

Disclaimer: 
That is my personal opinion. In the end the decision lies with Mostafah.

Comment 8

[Mostafa Hosseini]

We will keep the current themes for suite extension support. Anything new for
sunbird will end up in calendar/sunbird/base/skin ( which is currently empty ).
If the look and feel of the new graphics happen to be more consistent with the
theme of firefox and thunderbird, we will supply the same theme for them as well.
A zip file of the new skin directory would be sufficient.

Comment 9

[Chris Cook]

In the current build (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2)
Gecko/20040602 Mozilla Sunbird/0.1.1+) the skin lives in both calendar.jar and
classic.jar but the "contest" requests only a calendar.jar to be submitted so I
assume all of the skin will be migrated into calendar.jar. Will this happen
gradually or are you waiting for the theme to be created first? It is difficult
to test theme changes when the xul is referencing css files which exist in the
classic.jar file. Currently I am forced to update classic.jar to make and test
changes.

Comment 10

[Simon Paquet [:sipaq]]

Chris, the classic.jar comes from Firefox. With our recent changes in the build
system we don't package that file anymore (or only parts of it) as far as I
know. If you need any files from there, then please identify those so that we
know what we may eventually need to hook up or fork for our purposes.

If you can't supply your proposal in the calendar.jar, but in another file, then
that is fine. We won't kill you for it :-)

Comment 11

[Chris Cook]

I should have been more clear. Some xul is pointing to stylesheets in the
browser component instead of calendar. In particular
calendar/resources/content/pref/pref.xul is importing
chrome://browser/skin/pref/pref.css while it should, as far as I know, be
importing chrome://calendar/skin/prefs.css. Or should that be
chrome://calendar/skin/pref/pref.css? There is a file for the latter but not the
former.

What I meant before is that I would have to update
chrome://browser/skin/pref/pref.css which is packaged in classic.jar in order to
style the options dialog but pref.xul should obviously (to me) be updated to
import the appropriate stylesheet.

There are other references to files in the browser component as well but mostly
dtds and not css so I won't mention them here.

Comment 12

[Chris Cook]

What modifications are sought for the initial theme change? The contest posting
isn't clear.

All current themes currently skin the toolbar but leave the calendar area with a
common style (AFAIK). Should the new theme design update the calendar area style
and graphics as well?

When the new theme is initially deployed, will it make use of both small and
large icons similiar to Firefox and Thunderbird?

Will the options dialog require the "Themes" and "Extensions" icons or will
these be relocated to the Tools menu similar to Firefox?

Will additional toolbar buttons be added (cut, copy, paste, import, export,
etc.) similar to Firefox?

Knowing these things will help me prioritize the changes.

Comment 13

[Chris Cook]

Attachment: Patch pref.xul to use skin in the calendar package

RE comment 11. This updates the pref dialog xul to use css located in the
calendar package. It also renames the option button ids which I hope is
appropriate.

Since this is a non-skin file I'm attaching it separately as a patch.

Comment 14

[Mostafa Hosseini]

This check-in applies the submitted patch and adds the base framework for using
the new theme for sunbird:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fcalendar&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-07-03+9%3A00&maxdate=2004-07-03+10%3A00&cvsroot=%2Fcvsroot

Thanks for the patch.

Comment 15

[Chris Cook]

Attachment: Winstripe theme - first revision

This zip contains my winstripe theme. Toolbar icons and options dialog have
been replaced and appropriate CSS has been updated. The theme includes a
/skin/mozapps/pref directory which contains the options dialog css to be
consistant with Firefox and Thunderbird skin implementations.

Some filenames (toolbar icons) are different than the originals in anticipation
of more being added once toolbar customization lands (i.e., small icons),
though it can be changed if this is a showstopper.

Comment 16

[Chris Cook]

In case it matters, I'll be offline from July 10-18.

Comment 17

[Mostafa Hosseini]

I've checked in the files from attachment 152632 [details] which are from the new theme
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fcalendar%2Fsunbird%2Fthemes&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=08%2F06%2F2004+10%3A30&maxdate=08%2F06%2F2004+10%3A40&cvsroot=%2Fcvsroot

Please provide the rest of the graphics and/or changes to the css files so I can
update the tree

Comment 18

[Chris Cook]

re #17, do you mean graphics updated since the attachment submission or are 
there missing files?

In that attachment the CSS still uses the current throbber though I've changed 
the throbber to the one used by FF/TB in my later revisions. Should we use it?

Comment 19

[Chris Cook]

The new images checked in have text encoding so they don't check-out properly. 
Were they not checked in correctly or do I need to change something in my cvs 
config?

Comment 20

[Mostafa Hosseini]

(In reply to comment #18)
> re #17, do you mean graphics updated since the attachment submission or are 
> there missing files?

The blue arrows?
I've actually emailed Marc to see if he can give them to us in the same format
as the old ones:
http://lxr.mozilla.org/mozilla/source/calendar/resources/skin/classic/prevnextarrow.png
http://lxr.mozilla.org/mozilla/source/calendar/resources/skin/classic/pageupdown.png

> In that attachment the CSS still uses the current throbber though I've changed 
> the throbber to the one used by FF/TB in my later revisions. Should we use it?
No big deal. We don't have an activity to show by an animated throbber so for
now we'll use the sunbird icon.

Comment 21

[Mostafa Hosseini]

(In reply to comment #19)
> The new images checked in have text encoding so they don't check-out properly. 
> Were they not checked in correctly or do I need to change something in my cvs 
> config?

Fixed.

Comment 22

[Chris Cook]

Attachment: Updated images and supporting CSS

This zip contains updated theme images and the required css changes only. I am
still working on theme changes unrelated to images which I will post as they
become ready.

I simply put the calendar.css in the zip. Let me know if you need a patch
instead.

I also added /mozapps/pref/pref.css to this zip because it wasn't previously
added and /content/calendar/pref/pref.xul references it. I don't know if
supporting the new mozapps toolbox component is planned for Sunbird so I chose
to support it until I am told otherwise.

Comment 23

[Mostafa Hosseini]

New images and changes have been checked into cvs.
Note that in calendar.css, I kept "cursor:pointer;" for the week/month
navigation buttons (e.g. #multiweek-next-button ) since I wasn't sure why they
were take out.
Also regarding mozapps/pref/pref.css, this is the pref.css defined in
toolkit/mozapps:
http://lxr.mozilla.org/mozilla/source/toolkit/themes/winstripe/mozapps/pref/pref.css
we get it by default.

Comment 24

[Mostafa Hosseini]

New logo has been checked in
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fcalendar&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=08%2F16%2F2004+12%3A00&maxdate=08%2F16%2F2004+12%3A10&cvsroot=%2Fcvsroot

Comment 25

[Simon Paquet [:sipaq]]

Attachment: Hook up the new buttons

This patch enables the new buttons (new task, cut, copy, paste, import, export,
subscribe, publish, print, choose date, go to today) in the customize toolbar
dialog. It also eanbles the new-task button on the default toolbar. This patch
covers all languages (localizers have to translate the new strings, of course).


Remaining issues:
- we need a "customize toolbar" menuitem in the view-menu
- we should get rid of the "go to today button" under the mini-calendar

I will open new bugs for these issues.

Comment 26

[Simon Paquet [:sipaq]]

I filed bug 256405 and bug 256407 for the remaining issues and attached patches
there.

Comment 27

[Michiel van Leeuwen (email: mvl+moz@)]

Checked in the new buttons patch. Can this bug be closed now?

Comment 28

[Chris Cook]

My opinion is that the theme is about more than the toolbar button images. I am
working on updating the appearance of the calendar view area which still falls
under the heading of this bug. However, if this work is not desired I would like
to know now.

Comment 29

[Michiel van Leeuwen (email: mvl+moz@)]

It's not that i think changes like that are not welcome! I just didn't think
about it :)
But i do think that splitting off a different bug for that work would be better,
to keep stuff readable. Otherwise, someone looking for info on why the view
changed, has to wade through lots of buttons stuff before finding it.

Comment 30

[Chris Cook]

I was under the impression that the scope of "theme contest" and this bug was
about the whole theme and not just the toolbar. If that scope is too large I
have no problems with working in new bug.

Comment 31

[Michiel van Leeuwen (email: mvl+moz@)]

Nobody said everything that falls under the contest has to be done in this bug. :)

Comment 32

[Michiel van Leeuwen (email: mvl+moz@)]

I removed the !important clauses from the button rules in calendar.css in a
seperate checkin. They are not needed.

Comment 33

[Chris Cook]

Attachment: Patch to change throbber to Firefox style

This patch requires the throbber images to be attached next.

Comment 34

[Chris Cook]

Attachment: Throbber images

These images need to be dropped in /themes/winstripe/sunbird.

Forgot to mention, I'm not sure why the #navigator-throbber[busy="true"]
selector section was removed so I put it back in, but IMO if we're going to
remove that then we may as well remove the throbber altogether.

Comment 35

[Chris Cook]

Attachment: Patch to change throbber to Firefox style

Updated patch to fix sloppy whitespace. Sorry for the spam.

Comment 36

[Chris Cook]

Attachment: Patch to change throbber to Firefox style( checked in )

Added changes for jar.mn file. Hope I got that part right.

Comment 37

[Chris Cook]

Attachment: New "about" dialog files to make it consistant with other apps

These files make the about dialog look the same as those in Firefox and
Thunderbird. I had to hack the current logo image to look decent (added the
Brand text and fixed the weird semi-transparent border) but Mark will have to
create a final version.

Is there a way to create diffs for new files if you don't have add permission?

Comment 38

[Chris Cook]

Attachment: New "about" dialog files to make it consistant with other apps

Oops. Last upload didn't work.

Comment 39

[Chris Cook]

Attachment: Patch to update jar.mn for aboutDialog new files

Comment 40

[Chris Cook]

Attachment: Screenshot of about dialog with patch (and hacked image) applied

Comment 41

[Mark Carson]

Attachment: Sunbird About graphic without text

Comment 42

[Chris Cook]

(In reply to Comment #41)
Can you create a version WITH the brand text and slogan, which is 300x236px just
so we can have that option. The files I've added rely on this being part of the
image.

Also, if you look closely there is a dark line at the bottom and on the left
side. Please make sure that it isn't there in updated versions as it is quite
visible on the white background.

Comment 43

[Chris Cook]

Sorry. I didn't realize that you already posted a graphic with text in bug
157657. However, the brand text in that image doesn't really match the style
used in the other apps.

Comment 44

[Chris Cook]

Doh! Sorry, that should have been bug 257711.

Comment 45

[Mark Carson]

Attachment: Sunbird About Page Graphic with Text

300x236 image with text (green "Sinbird", black "it's about time")

Comment 46

[Mark Carson]

Attachment: Sunbird About Page - no text

300x236 image without text

Comment 47

[Chris Cook]

(In reply to comment #45)
That green is a bit bright isn't it? Try putting my screenshot next to Firefox's
about dialog and I think you'll find that the darker green matches better with
the darker red text of the other.

Comment 48

[Mark Carson]

Attachment: Sunbird About page with (darker) green text

Comment 49

[Mark Carson]

Attachment: Sunbird About Page graphic with text

Oops - grabbed the wrong image a moment ago.

Comment 50

[Chris Cook]

Much better. If I were a graphic artist I would probably have some comment about
the slogan not being the same length as the brand, but I'm not ;-)

Comment 51

[Mark Carson]

Attachment: Sunbird About Graphic - justified text

Everyone's a critic. Just kidding Chris. The previous one was close, but I
think one is right on. BTW - I'm not a graphic designer either :-) Just a coder
who hacks out some grapics for fun.

Comment 52

[Chris Cook]

Comment on attachment 157778 [details] [diff] [review]
Patch to change throbber to Firefox style( checked in )

This patch hooks up the new throbber image. Please review and check in if
appropriate.

Comment 53

[Chris Cook]

Attachment: Patch to update toolbar graphics to support image changes( checked in )

This patch supports changes made to the toolbar graphic by Mark Carson.
Specifically, the view (day, week, multi-week, month) buttons have been given a
new icon for their "checked" state.

This patch relies on the following image files being replaced/updated:
toolbar-large.png
toolbar-small.png

Comment 54

[Chris Cook]

Attachment: New toolbar-large with "pressed" view button graphics( checked in )

Comment 55

[Chris Cook]

Attachment: New toolbar-small with "pressed" view button graphics( checked in )

Comment 56

[Chris Cook]

Comment on attachment 162553 [details] [diff] [review]
Patch to update toolbar graphics to support image changes( checked in )

The required toolbar images have been attached. Provided the new "pressed"
graphic is suitable this is ready to go.

Comment 57

[Simon Paquet [:sipaq]]

*** Bug 264919 has been marked as a duplicate of this bug. ***

Comment 58

[Matthew (lilmatt) Willis]

Attachment: rev0 - trunk - changes about dialog to mimic Firefox's

This patch makes "About Sunbird" look similar to Firefox, and gets rid of a
nasty scrollbar problem on Mac OS X once the useragent wrapped to 3 lines.

mozilla/calendar/sunbird/base/content/about.png is attachment 157840 [details] above.

The patch also moves the Sunbird-specific about dialog components inside
Sunbird's directory, rather than have them added to the calendar.jar of the
xpi.

Comment 59

[Mostafa Hosseini]

Comment on attachment 164009 [details] [diff] [review]
rev0 - trunk - changes about dialog to mimic Firefox's

Patch checked in with minor tweaks:
sunbird.png is about-sunbird.png
kept height setting for aboutDialog.xul

Comment 60

[Mostafa Hosseini]

Comment on attachment 157840 [details]
Sunbird About Graphic - justified text

Checked in as sunbird/base/content/about-sunbird.png

Comment 61

[Mostafa Hosseini]

This bug is fixed now. Please open new bugs for more improvements.

Comment 62

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!