Closed
Bug 248419
Opened 21 years ago
Closed 20 years ago
[Linux] Yellow background in location bar for secure site indication does not show
Categories
(Firefox :: Address Bar, defect)
Tracking
()
VERIFIED
FIXED
Firefox1.0
People
(Reporter: ali, Assigned: steffen.wilberg)
References
Details
(Keywords: fixed-aviary1.0)
Attachments
(1 file)
|
871 bytes,
patch
|
bugs
:
review+
bugs
:
approval-aviary+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040623 Firefox/0.9.0+
On Linux, the yellow background in the location bar for secure site indication
does not show. Although the SSL lock shows, the background remains white.
It works fine on Windows.
|
Reporter | |
Updated•21 years ago
|
Flags: blocking1.0?
|
||
Comment 2•21 years ago
|
||
For an explanation what's happening, see bug 244025 comment 37 and bug 244025
comment 41.
|
||
Comment 4•21 years ago
|
||
this is pretty much due to the crappy moz-appearance impl on GTK, per bz and my
own testing.
evil CSS hackery is probably our best short-term bet... if someone wants to dig
into it enough
|
|
||
Comment 5•21 years ago
|
||
Bug 241070 looks to be the fix needed here, and it even has an unreviewed patch.
|
||
Comment 6•20 years ago
|
||
*** Bug 259664 has been marked as a duplicate of this bug. ***
|
|
||
Comment 7•20 years ago
|
||
have a fix, need to test on other platforms to make sure it doesn't hork those
platforms.
-moz-appearance sucks
Assignee: bryner → mconnor
|
|
||
Comment 8•20 years ago
|
||
ok, short version is that to get this to work fine, just add -moz-appearance:
none; to the style rule that hardcodes the colors.
Steffen, if you can patch/drive this, that'd be great.
Assignee: mconnor → steffen.wilberg
|
Assignee | |
Comment 9•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #161139 -
Attachment description: -moz-appearance: none
none → -moz-appearance: none
|
|
Assignee | |
Comment 10•20 years ago
|
||
Comment on attachment 161139 [details] [diff] [review]
-moz-appearance: none
One-liner, as suggested by Mike. Fixes the problem in Linux, and doesn't harm
Windows.
Attachment #161139 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [have patch]
Target Milestone: --- → Firefox1.0
Version: unspecified → 1.0 Branch
|
||
Comment 11•20 years ago
|
||
Comment on attachment 161139 [details] [diff] [review]
-moz-appearance: none
r+a=ben@mozilla.org if the field still has the standard blue luna border around
the edge.
Attachment #161139 -
Flags: review?(bugs)
Attachment #161139 -
Flags: review+
Attachment #161139 -
Flags: approval-aviary+
|
|
Assignee | |
Comment 12•20 years ago
|
||
Checked in br & trunk.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Keywords: polish → fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: [have patch]
|
|
Assignee | |
Comment 13•20 years ago
|
||
> r+a=ben@mozilla.org if the field still has the standard blue luna border around
> the edge.
It still has.
|
||
Comment 14•20 years ago
|
||
Marking VERIFIED YELLOW, er, FIXED, with Linux Gecko/20041010 Firefox/0.10.1.
See bug 263750 for 1px black border regression (which I think looks neat) caused
by this.
Status: RESOLVED → VERIFIED
|
||
Comment 15•20 years ago
|
||
*** Bug 282963 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•