249680 - Location bar text not visible with yellow background for secure sites

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Laurence "GreenReaper" Parry]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040702 Firefox/0.8.0+ (BlueFyre)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040702 Firefox/0.8.0+ (BlueFyre)

The recently-added yellow background for the location bar when a secure site is
accessed does not take into account the system's theme colours. WindowBlinds
themes Blackcomb Dark and Furcadia (in development) do not use black, or even
dark button or window text. The yellow background assumes this and thus causes
the URL to become unreadable.

Reproducible: Always
Steps to Reproduce:
1. Load a theme that includes light-coloured text
2. Load a site in Firefox that is secure
3. . . . there's no step 3

Actual Results:  
The background was applied without regard to the system (and previous)
background colours, and without considering the fact that text may not be dark.
This resulted in unreadable URL text.

Expected Results:  
This should be handled in a way that works with all themes. In general, if you
are going to force a non-themed background colour, you should force a non-themed
foreground as well. Perhaps it could change the foreground text to be black, or
use the selected foreground and background colours when on a secure site and
switch back to non-selected colours when selecting text.

Using latest BlueFyre build from burning edge forums, latest versions of
WindowBlinds available, with skins Blackcomb Dark and Furcadia (latter is in
development and currently uses yellow text)

Comment 1

[Laurence "GreenReaper" Parry]

Attachment: Screenshot of a secure site with Furcadia and Blackcomb Dark, and a non-secure site with Blackcomb Dark

Comment 2

[David P James]

I knew it, I knew something like this was going to happen. Whenever we 
hardcode colours we create problems. 

Comment 3

[Jesse Ruderman]

Each default theme should include a text color (black) to go with the background
color it specifies (yellow).

Comment 4

[Ryan Polk (Quark)]

Attachment: one liner: set a color when background-color is set

Takes Jesse's suggestion, which is an easy solution.

This fixes Winstripe, and should fix Gnomestripe b/c there's no gnomestripe
version of browser.css

Unfortunately, the urlbar change is not landed in Pinstripe yet.  Read more
about that at bug 244025.  I'll post a comment there so hopefully they
integrate this with the landing.

Comment 5

[Ryan Polk (Quark)]

Sorry, correction.  Until bug 248419 (block 244025) is fixed we can't know
what's up with Linux.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 154924 [details] [diff] [review]
one liner: set a color when background-color is set

this'll do the trick

Comment 7

[Ryan Polk (Quark)]

Comment on attachment 154924 [details] [diff] [review]
one liner: set a color when background-color is set

Requesting approval.  This bug should probably remain open until we can confirm
gnomestripe is fixed.

Pinstripe already encorporated this with a seperate checkin.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 154924 [details] [diff] [review]
one liner: set a color when background-color is set

a=[e-mail]

Comment 9

[Jesse Ruderman]

I checked in Quark's patch, trunk and aviary.