250279 - View Source doesn't use Find Toolbar / Since Find Toolbar was implemented, Find as you type is broken in "Page Source" window

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P3)

Description

[Jesse Ruderman]

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

-> Find Toolbar component.

Comment 2

[José Jeria]

*** Bug 251660 has been marked as a duplicate of this bug. ***

Comment 3

[Blake Ross]

*** Bug 251660 has been marked as a duplicate of this bug. ***

Comment 4

[(not currently active) Ted Mielczarek]

*** Bug 253272 has been marked as a duplicate of this bug. ***

Comment 5

[logan]

If/when fixed, would this also cover FAYT in help? Not sure if it's supposed to
work there or not, but I don't see a reason why it shouldn't.

Comment 6

[Jeff Walden (gone starting June 8)]

(In reply to comment #5)
> If/when fixed, would this also cover FAYT in help? Not sure if it's supposed to
> work there or not, but I don't see a reason why it shouldn't.

That's bug 253621, which I just filed.  Thanks for reminding us about it!

Comment 7

[Asaf Romano (gone)]

...and the find toolbar also broke FAYT in any other gecko window (e.g.
Chatzilla, Help system, etc.)...

Comment 8

[Brendan Eich [:brendan]]

Why did we lose FAYT in other windows?  We should restore compatibility.

/be

Comment 9

[Arthur Wiebe]

*** Bug 262914 has been marked as a duplicate of this bug. ***

Comment 10

[Bill Mason]

*** Bug 263622 has been marked as a duplicate of this bug. ***

Comment 11

[Asa Dotzler [:asa]]

I really don't think FAYT in view source should be something that we'd hold the
release for. Normal ctrl+f find dialog find works just fine in view source and
that's good enough. We really should minus this bug. 

Comment 12

[Brendan Eich [:brendan]]

Is there anything to gain by removing the old find dialog for 1.0?

/be

Comment 13

[Blake Ross]

Attachment: patch

Comment 14

[Blake Ross]

Fixed.

Comment 15

[Benjamin Smedberg]

The net effect of this checkin, after most of the l10n changes were reverted,
was to change

-<!ENTITY useTypeAheadFind.label       "Use Find As You Type">
+<!ENTITY useTypeAheadFind.label       "Begin finding when you begin typing">

I'm going to post-approve this change, since it doesn't break the existing
localizations we're trying to put out for RC, but grrr.

Comment 16

[Jeff Walden (gone starting June 8)]

As the l10n change is approved, please make sure to fix the label in Help
documentation:

http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/prefs.xhtml#419

It'd be nice if you'd fix this issue on both branch *and* trunk, but if you
don't, just let me know here or via email and I'll fix it on trunk.

Comment 17

[Scott MacGregor]

FYI, I attached a patch to Bug #264852 that trys to fix the thunderbird
regressions this patch introduced into thunderbird's view source dialog on the
branch.

Comment 18

[Steffen Wilberg]

v.

Comment 19

[Patrick]

*** Bug 265963 has been marked as a duplicate of this bug. ***