250922 - found links aren't focused

Status: RESOLVED INVALID

(Toolkit :: Find Toolbar, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Steps to reproduce
1) visit a page with links 
2) Ctrl+F or / to invoke Find Toolbar
3) type text in a link, text in the link is selected
4) press "Enter"

Expected Results:
- Navigate to link

Actual Results:
- Nothing happens. Need to press tab to shift focus to next link, then shift tab
to shift it back.

Comment 1

[sairuh (rarely reading bugmail)]

see also bug 250272, bug 250274.

Comment 2

[Aaron Leventhal]

The other thing is that people are used to hitting Enter at the end of a Ctrl+F
search.

Muscle memory wise this is a problem and people might not notice the behavior is
now different.

So you type Ctrl+F bug Enter like you used to, and you've missed the first match.

Comment 3

[Blake Ross]

Fixed on branch.

Don't need to leave open for trunk since I have bug 250231 and all these fixes
will land as part of that.

Comment 4

[Ben Basson]

This appears to fix Bug 250483 too.

Comment 5

[Gemma L.C. Anible]

A text find using the Find Toolbar (invoked through Ctrl+F) doesn't focus links
for me. A text find using Find As You Type or '/' does focus links. Is this
behavior intentional? Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040804 Firefox/0.9.1+

Comment 6

[Tuukka Tolvanen (sp3000)]

right, ctrl-f (ctrl-g also) puts focus with a text cursor into the find bar
textfield, and keeps it there, which sort of makes sense since it'll behave more
like a find dialog with the old find dialog shortcut..

Comment 7

[Tuukka Tolvanen (sp3000)]

hmh. reopening for a look since it doesn't do what comment 0 specifies, and
comment 2 still applies.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

the original test case worksforme 08/06... please file new bugs on other problems. 

Comment 9

[:deanis74]

Reopening.  The original test case does not work using 08/23 branch build. 
Enter triggers Find Again but does not navigate the link.  To reproduce, search
for "Show" on this page.

Comment 10

[:deanis74]

*** Bug 256304 has been marked as a duplicate of this bug. ***

Comment 11

[Travis Hume]

Is this bug not considered a blocker for 1.0?

Comment 12

[Johan Nilsson]

I have this problem mostly with pages using frames and using autostart type ahead.

The last update of this bug where a long time ago, do someone have a fix for this?

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

-> WFM

Currently, the found link doesn't have a focus. But it has pseudo-focus always.
While FAYT, find toolbar's enter key event fires found link's enter key event.
See bug 259454.

Comment 14

[Jesse Ruderman]

I still see this bug using the steps in comment 0.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050707
Firefox/1.0+

Comment 15

[Travis Hume]

I run into this bug on a daily basis.
1. go to http://www.eclipse.org
2. after loaded find downloads (/downloads)
3. downloads link is highlighted by pressing enter does not navigate

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

If you are testing with Ctrl + F, it is invalid.
Ctrl + F is not found the link that is designed so.

If you think that Ctrl + F should be, it is not bug. It is not bug.
So it is not this bug (this bug is not 'enhancement', it is 'normal').

Currently design, FastFind find the link and you can naviate the link that is
only in FAYT mode, not in Normal Find mode.

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

O.K. I misread comment 0.

Comment 0 said:
> 2) Ctrl+F or / to invoke Find Toolbar

Currently design, the link is found when starting with "'" only.
It is design. Not a bug.

-> INVA

Comment 18

[Travis Hume]

I disagree.

1. Navigate to http://www.eclipse.org
2. type "'" to start finding links
3. enter "downloads"
4. the downloads link is highlighted
5. press enter to follow the link
6. nothing happens.

While the link is highlighted, it isn't focused and can't be navigated to with
the keyboard.

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Travis:

It is a FAYT's bug in frame. It is not this bug.
Please file a new bug.

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I filed bug 300105 for comment 18.

Comment 21

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

*** Bug 250272 has been marked as a duplicate of this bug. ***