User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8) Gecko/20051111 Firefox/1.5
I updated to FF 1.5. Many extensions were disabled while installing. Some could be updated automatically. On (here SessionSaver2) has to be updated manually from another website than mozilla.extensions. Now i have two rows in the extension manager. First the normal extension with full functionality 8works fine) and second a row with "sessionsaver-02-dev.xpi", that does nothing (right-click-menu is greyed-out) ... seems to be an error in extension handling.
Created attachment 204943 [details]
In case anyone might want to study them, please attach the extensions.rdf in your profile and the install.rdf's of every extension in the folder extensions before you restore your profile.
Like described on the bottom of this bug: Bug 317193.
This happens when an extension doesn't complete an install and there are several bugs open to fix the cause of this symptom. To fix this on your system you can delete the extensions.rdf file in your profile directory and it will be recreated.
If it fixes it this bug will be fixed in another bug. If it does not then there is another bug this bug is masking and we can take this further. Please post back whether this fixes it or not.
Created attachment 211422 [details] [diff] [review]
We continue the download of an extension when the extension manager ui is closed but we only remove the download item in the rdf from extensions.js. This move the call to INSTALL_DONE in nsExtensionManager.js.in.
*** Bug 318926 has been marked as a duplicate of this bug. ***
*** Bug 260276 has been marked as a duplicate of this bug. ***
Mel, you brought up this bug to me once before and if you have the time I'd appreciate your help with verifying this is working as expected, etc. when it is patched.
checked in to trunk
weird, I didn't get your email, but happened to come across this on mozillazine trunk list.
I'll do some testing on an older computer where I think I can dupe this. I'm "assuming" this will only help this from happening in the future, right? Which bugs are related to this one to resolve existing (as I like to call them) "ghost" entries?
this is a very annoying bug in 1.5, any chance of this being reviewed for branch?
Mel, bug 326722 which this bug blocks is to take care of the existing ghost entries. This appears to have fixed the application quit bug when installing an extension in that I was only able to get it to show the cancel download dialog one time and when I clicked cancel the entry was removed from the Extension Manager ui. It also now successfully completes installations if you close the Extension Manager ui and leave it closed while an install is being performed similar to how the Download Manager will complete a download.
mdew, I will land this on the MOZILLA_1_8_BRANCH (e.g. Firefox 2.0) after I get verification from others that it is working as expected without any serious regressions. As for the MOZILLA_1_8_0_BRANCH (e.g. Firefox 1.5.x.x) I doubt it. I would want bug 326722 which will be a more complicated patch to land as well otherwise we would have 3 different cases with release builds as follows instead of just cases 1 and 3.
1) 1.5 ghost entries and can reproduce this bug
2) 126.96.36.199 ghost entries and can't reproduce this bug
3) 2.0 no ghost entries and can't reproduce this bug
I did some further testing today using the different versions of http://spellbound.sourceforge.net/install since it installs multiple extensions during a single install and all worked as expected. When installing / upgrading to an incompatible extension and closing the EM ui the incompatible alert is displayed. When exiting when installing / upgrading and quiting the application if you click cancel downloads the extensions are not left behind in the extensions datasource and when you click don't exit the extensions are installed properly.
Everything looks good to me but I suspect there are still a couple of edgecases lying around. Confirmation from others on this bug would be appreciated.
One way to still get the appearance of a "ghost" entry is to start two installs of themes - possibly extensions as well - separately which is bug 251519. The entry in the Theme Manager that finishes last will look the same as a "ghost" entry when the first install completes but it will continue the install and complete successfully which removes the "ghost" entry. So, bug 251519 appears to now be a visual glitch which will correct itself.
*** Bug 266117 has been marked as a duplicate of this bug. ***
Checked in on MOZILLA_1_8_BRANCH
*** Bug 316038 has been marked as a duplicate of this bug. ***
*** Bug 325423 has been marked as a duplicate of this bug. ***
*** Bug 336697 has been marked as a duplicate of this bug. ***
*** Bug 340230 has been marked as a duplicate of this bug. ***
*** Bug 346309 has been marked as a duplicate of this bug. ***
*** Bug 346465 has been marked as a duplicate of this bug. ***