252294 - Firefox and Thunderbird themes with OS ALL should not show up for Mac

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[alanjstr]

Because of bug 222654, themes show up for Mac users that should not.  Since this
really screws up Mac users, I think we should filter them out until Bug 222654
is resolved.  If you decide to Fix this one, I'll open another that is blocked
by 222654 to Undo this one.

Comment 1

[Wolf [:wolf]]

This definitely relates to Bug 248625.. which causes MacOSX specific themes not
to take precendence over their All counterparts. It's not quite a dupe thuough.

Do you think the fix for Bug 248625 would cover this? or would it not be enough
for themes that don't have MacOSX specific counterparts? Hiding the issue for
Bug 222654 might not be particularly helpful to getting that bug properly resolved.

Comment 2

[alanjstr]

I think they're separate enough.  If someone picks Mac from the dropdown, they
shouldn't see ALL when it comes to Firefox.  

Comment 3

[Wolf [:wolf]]

Sounds fair enough, this bug really is a hack though. I personally don't want to
do it, since I feel strongly that the root bug should be fixed (I nominated it
to block-aviary1.0mac), but it's unfair to the basic Mac user to get broken
themes if I don't, so it will be added, hopefully on a temporary basis. heh. 

I'm marking dependency on this bug, so we don't need a second undo bug. just use
this one to handle both, implementation and removal.

Comment 4

[Wolf [:wolf]]

heh, this bug sucks, but it's "fixed".

Comment 5

[Wolf [:wolf]]

Fixed.