253054 - Spellchecking in Thunderbird does not function on new install

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Don Crandall]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040717
Build Identifier: Thunderbird 0.7.1

Thunderbird spellchecking fails to fuction upon new install.

The Languages menu, in the spellchecking dialog, is set to 'Download more' on a
new insatll of Thunderbird causing the spellchecking to fail.





Reproducible: Always
Steps to Reproduce:
1. Install Thunderbird 0.7.1 with new profile.
2. Obviously, set up at least one account.
3. Create a new email with known spelling errors and try to check the spelling.

Actual Results:  
No checking is done.

Expected Results:  
The normal spellchecking of the email is seen.

Workaround: Selecting a dictionary from the Languages menu solves the problem,
but a new user is confused by the behavior. (frankly, so was this technician
when he heard this) ;-)

Comment 1

[chris hofmann]

confirming and marking as a blocker...

Comment 2

[Scott MacGregor]

*** Bug 255104 has been marked as a duplicate of this bug. ***

Comment 3

[Scott MacGregor]

I'm still trying to reproduce this. 

Comment 4

[Scott MacGregor]

Do we get lucky and have any JS errors in the console?

Comment 5

[Bob Clary [:bc] (inactive)]

Warning: useless expression
Source File:
file:///C:/Program%20Files/Mozilla%20Thunderbird/components/nsExtensionManager.js
Line: 285

Warning: useless expression
Source File:
file:///C:/Program%20Files/Mozilla%20Thunderbird/components/nsExtensionManager.js
Line: 288

bunch of redeclaration warnings...

Warning: function nsExtensionManager_installExtensionInternal does not always
return a value
Source File:
file:///C:/Program%20Files/Mozilla%20Thunderbird/components/nsExtensionManager.js
Line: 2249, Column: 22
Source Code:
    return extensionID;


Warning: function nsExtensionsDataSource_getItemProperty does not always return
a value
Source File:
file:///C:/Program%20Files/Mozilla%20Thunderbird/components/nsExtensionManager.js
Line: 3745, Column: 2
Source Code:
  },


Warning: useless expression
Source File:
file:///C:/Program%20Files/Mozilla%20Thunderbird/components/nsUpdateService.js
Line: 83

Warning: useless expression
Source File:
file:///C:/Program%20Files/Mozilla%20Thunderbird/components/nsUpdateService.js
Line: 86

Warning: function nsAppUpdater__parseUpdateCollection does not always return a value
Source File:
file:///C:/Program%20Files/Mozilla%20Thunderbird/components/nsUpdateService.js
Line: 831, Column: 22
Source Code:
    catch (e) { return; }

Warning: function nsAppUpdater__parseUpdateCollection does not always return a value
Source File:
file:///C:/Program%20Files/Mozilla%20Thunderbird/components/nsUpdateService.js
Line: 855, Column: 17
Source Code:
    return result;

and finally the coup de grace

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004003 (NS_ERROR_INVALID_POINTER)
[nsIEditorSpellCheck.GetNextMisspelledWord]"  nsresult: "0x80004003
(NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://editor/content/EdSpellCheck.js :: NextWord :: line 260"  data: no]

Comment 6

[Scott MacGregor]

Attachment: the fix

Comment 7

[Scott MacGregor]

Comment on attachment 155850 [details] [diff] [review]
the fix

Editor should use a chrome package known to exist (like itself) instead of
using "navigator" as the chrome package to ask the locale of. 

In the case of thunderbird static installer builds, we strip out the navigator
package so it doesn't even exist. That leads to this code failing.

Comment 8

[Kathleen :Brade]

Comment on attachment 155850 [details] [diff] [review]
the fix

moa/r=brade
I haven't tested this patch but I'm ok with it based on what mscott described.

I do think that we'll want to make further changes to it though.  I'd like to
see the spellchecker have its own chrome/locale/etc. so that it could easily be
added as an extension to firefox (without bringing in all of the editor
dialogs, etc.).  That probably requires a separate bug.

Comment 9

[Scott MacGregor]

FYI, this is fixed on the aviary branch. Leaving open for the trunk which is
currently closed for a seamonkey release.

Moving to .9 so this doesn't show up on my .8 blocking list anymore.

Comment 10

[chris hofmann]

fixed-aviary1.0 keyword

Comment 11

[Scott MacGregor]

fixed on the trunk now too