253478 - hide Schedule and Notify tabs in the bookmarks properties dialog

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Asa Dotzler [:asa]]

Bookmarks notification is buggy and we don't have time to make it better. Remove
for 1.0.

Comment 1

[chris hofmann]

remove the pannel for
bookmarks | manage bookmarks | properties | notify  

Comment 2

[Blake Ross]

Also need to remove Scheduling panel.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: bookmarks-disable-scheduling-0.patch

Just #if 0'ing stuff out, we'll want to revisit and fix it post-1.0.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 154821 [details] [diff] [review]
bookmarks-disable-scheduling-0.patch

a=asa

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

in. (aviary only)

Comment 6

[Alfred Kayser]

Why not also remove the tabs completely (using if 0), if only one tab is left?

Comment 7

[Alfred Kayser]

Reopening, the patch is not complete. 
As only one tab is left, the complete tabbox/tabpanel thing can be
removed/disabled (#if'ing)...

Comment 8

[amano]

Now this has to be re-enabled since it was disabled by the aviary landing on the
branch. It is one the todo list in the "branch landing wiki"

http://wiki.mozilla.org/index.php/Firefox:Branch_Landing

Comment 9

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20050108
Firefox/1.0+

If "remove bookmark notification pannel" is the valid summary of this bug.

WFM

(I assume there will be a reenable this bug sometime in the future ?)

Comment 10

[Mike Connor [:mconnor]]

This isn't coming back for 1.1, unless someone comes up with some fixes.

Comment 11

[Prognathous]

This useful feature was removed July 2004. Marking WORKFORME.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050213 Firefox/1.0+

Prog.

Comment 12

[Worcester12345]

(In reply to comment #10)
> This isn't coming back for 1.1, unless someone comes up with some fixes.

Target Milestone: Future?

Comment 13

[Worcester12345]

Just because it was removed sure doesn't make it working (WFM). I think this
should be reopened with a future milestone and a "helpwanted" key word.

Isn't there a tracking bug for bookmark bugs?

Comment 14

[johnzilla]

(In reply to comment #13)
> Just because it was removed sure doesn't make it working (WFM). I think this
> should be reopened with a future milestone and a "helpwanted" key word.
> 
> Isn't there a tracking bug for bookmark bugs?

I'd like to take a crack at this, but would first like to understand the
requirement for the feature - can anyone refer me to such information?  

What's led me here is an interest in creating an extension to provide a visual
indicator when a live bookmark is updated with new content.  Is it preferable to
look to provide a patch or stick with the extension?

Comment 15

[Kelley Cook]

(In reply to comment #14)
> What's led me here is an interest in creating an extension to provide a visual
> indicator when a live bookmark is updated with new content.  Is it preferable to
> look to provide a patch or stick with the extension?

This bug concerned normal bookmarks, but adding implementing update
notifications for both normal and live bookmarks would be welcome.  Probably
would need a new bug though.

Comment 16

[Asaf Romano (gone)]

reopening for comment 7 (nothing else).

Comment 17

[Steffen Wilberg]

I filed bug 289797 to hide the Info tab as well. Marking fixed again.

Comment 18

[Worcester12345]

Is there a corresponding bug to reopen this issue for 1.2 or whatever version? 

Comment 19

[Worcester12345]

(In reply to comment #15)
> (In reply to comment #14)
> > What's led me here is an interest in creating an extension to provide a visual
> > indicator when a live bookmark is updated with new content.  Is it preferable to
> > look to provide a patch or stick with the extension?
> 
> This bug concerned normal bookmarks, but adding implementing update
> notifications for both normal and live bookmarks would be welcome.  Probably
> would need a new bug though.

(In reply to comment #18)
> Is there a corresponding bug to reopen this issue for 1.2 or whatever version? 

?

Comment 20

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change