Update docs to reflect Setting as Default Browser as possible in Linux

VERIFIED FIXED in Firefox1.0beta

Status

Firefox Graveyard
Help Documentation
--
minor
VERIFIED FIXED
14 years ago
2 years ago

People

(Reporter: Jeff Walden (gone starting June 8), Assigned: Jeff Walden (gone starting June 8))

Tracking

({fixed-aviary1.0})

1.0 Branch
Firefox1.0beta
All
Linux
fixed-aviary1.0

Details

Attachments

(3 attachments)

(Assignee)

Description

14 years ago
The GNOME integration work seems to be proceeding well, because I just noticed
that Set as Default Browser is available in Linux.  The docs (specifically, the
page documenting the Options panel) say it's only for Windows, so we need to
change it to reflect that it's available on some platforms.  Perhaps using the
unix and win classes is a good idea here, once they work correctly.

This should be simple enough to fix; I'll take it and get to it pretty soon.
(Assignee)

Comment 1

14 years ago
Created attachment 155647 [details] [diff] [review]
Section now displayed in Linux - includes bug 249231 stuff

I added the section to the "unix" class to display it on Linux.  I also removed
the prefixed "On Windows, " text because it could be wrong now.

The patch also contains stuff for bug 249231 (because removing it's a pain),
which with any luck should get in before 1.0.

Will nominate for blocking-aviary1.0PR in a sec because there's a patch...
(Assignee)

Updated

14 years ago
Attachment #155647 - Flags: review?(rlk)
(Assignee)

Comment 2

14 years ago
It has a patch, and it's a new Linux feature...we should display help for
Setting as Default Browser on Linux.
Status: NEW → ASSIGNED
Flags: blocking-aviary1.0PR?

Comment 3

14 years ago
Comment on attachment 155647 [details] [diff] [review]
Section now displayed in Linux - includes bug 249231 stuff

r=rlk@trfenv.com

You could use noMac instead of "win unix" but "win unix" is probably much more
readable. We might want to consider removing the "noPlatform" classes in favor
of this.
Attachment #155647 - Flags: review?(rlk) → review+
(Assignee)

Comment 4

14 years ago
(In reply to comment #3)
> You could use noMac instead of "win unix" but "win unix" is probably much more
> readable. We might want to consider removing the "noPlatform" classes in favor
> of this.

By my way of thinking this choice was because it was made explicitly available
for those platforms.  If work had to be done to hide the feature for Macs only
(for example, if the feature was buggy on Macs specifically), I would have used
noMac.  Given the code overhead for the no* classes, I don't particularly see a
reason to remove them, but it's a trivial matter.  Perhaps sometime a coding
style issue?  Will consider...

Anyways, removing redundant blocking flag, adding to deps for Help tracker, and
marking FIXED because patch is checked in...
Blocks: 253104
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Flags: blocking-aviary1.0PR?
Resolution: --- → FIXED
(Assignee)

Updated

14 years ago
Target Milestone: --- → Firefox1.0beta

Comment 5

14 years ago
VERIFIED
Status: RESOLVED → VERIFIED
(Assignee)

Updated

14 years ago
Keywords: fixed-aviary1.0

Comment 6

14 years ago
I just noticed that this is hidden on Linux. And it looks like it's hidden on
Windows as well.

The heading and the paragraph have class"win unix".
On Linux, the rule  ".noUnix, .win, .mac { display:hidden; }" is applied becuase
of "win".
On Windows, the rule ".noWin, .mac, .unix { display: none; }" is applied because
of "unix".

Reopening. We might want to use "mac" instead.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

Comment 7

14 years ago
"noMac" of course. And we need to add that to the platformClasses for non-Mac
platforms.

Updated

14 years ago
Keywords: fixed-aviary1.0
(Assignee)

Comment 8

14 years ago
Created attachment 156656 [details]
Demonstrate various styles (switch between them w/stylesheet switcher)

The attached testcase demonstrates a perfectly valid way to handle platform
hiding with multiple classes (as opposed to the no* option).  Unfortunately, it
would require approval-aviary and would necessitate tweaking every document
with platform-specific styles to work around a specificity issue inherent in
the fix -- and time's in short supply.

Personally, I'm loving the method the testcase demonstrates because it's so
elegant.  It enables sensible parsing of "win unix" yet remains fully
compatible with the "no*" style to exclude one platform.  It's also more
robust, because if we ever supported four different platforms this would be the
*only* way to do it.  However, at this stage I think the solution is just to
change the "win unix"/"win mac"/"mac unix" classes over to the appropriate
"no*" styles and let it go at that.  After 1.0 we can get code similar to this
testcase into the tree, but right now it's too much hassle.

Patch coming up for changing the two-class style into one-class...if we think
the idea in this testcase is good, let's create a new bug for better platform
CSS and then target it for after 1.0.  Making a patch for it is trivial using
the example of the testcase, but such a patch would reach far enough that we
can't do it now.
(Assignee)

Comment 9

14 years ago
Created attachment 156658 [details] [diff] [review]
Convert "win unix" to "noMac"

I don't believe there are any other instances of this type of class set up.  If
anyone else remembers any, mention them and I'll add 'em to a new patch.
(Assignee)

Updated

14 years ago
Attachment #156658 - Flags: review?(rlk)

Updated

14 years ago
Attachment #156658 - Flags: review?(rlk) → review?(steffen.wilberg)

Comment 10

14 years ago
Comment on attachment 156658 [details] [diff] [review]
Convert "win unix" to "noMac"

Steffen, can you do this review for me? I'm going to be busy today and won't
have time until much later today.

Comment 11

14 years ago
Comment on attachment 156658 [details] [diff] [review]
Convert "win unix" to "noMac"

Sure. Just what I suggested in comment 6 and 7. And just forget about the
second sentence in comment 7.
Attachment #156658 - Flags: review?(steffen.wilberg) → review+

Comment 12

14 years ago
Checked in on branch. The platform-specific classes aren't on trunk yet.
-> fixed.

I really like Jeff's demonstration though. Great stuff! Isn't it basically a
search-and-replace job?
Status: REOPENED → RESOLVED
Last Resolved: 14 years ago14 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED

Updated

13 years ago
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.