255314 - [Submission] Extract preview image from theme jar

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Developer Pages, enhancement, P5)

Description

[alanjstr]

We should extract the preview image from the jar file so that a separate upload
isn't needed.

Comment 1

[Wolf [:wolf]]

Update has preview image requirements in size that Firefox doesn't have. So,
what happens then?

Comment 2

[alanjstr]

Crop it.  Pad it.  I don't care.  Be creative.  Future it.

Comment 3

[Wolf [:wolf]]

Well, to do that, i'd need the GD image functions. which i've requested for the
new server. I'm going to reassign this to nobody for now. heh. It's not a bad
idea though. I'll revisit nobody's bugs later. once my own buglist is shorter. :-)

Comment 4

[Gabriele Fava]

Isn't this feature already present (even if not working)? If it's not, why did
you (Wolf) marked my bug 262655 as a duplicate of bug 255258 instead than of
this one?

Comment 5

[alanjstr]

No, this feature does not exist, not even in the beta.  Yes, your bug should be
duped to this one, which is dependent on the other.  

Comment 6

[Gabriele Fava]

*** Bug 262655 has been marked as a duplicate of this bug. ***

Comment 7

[Wolf [:wolf]]

Bulk Moving Developer Control Panel bugs to new component.
(Filter: massdevcpspam)

Comment 8

[Joshua Nixon]

given that some theme developers don't see the need to add a preview een on
their own home pages, yeah, this would be a good idea. how much bandwidth is
wasted by people downloading a theme that they subsequently discover they hate
and immediately delete?

Comment 9

[Jaap A. Haitsma]

On update-beta.mozilla.org there are previews which are extracted from the .jar
file. However they are converted from .png to .jpg and for themes which have an
alpha channel in the preview .png file (E.g GNOME-Fx). The transparent area is
converted to black, which looks really ugly. The transparent area should be
converted to the color of the web page (in this case white) or .png files should
be used

Comment 10

[Cameron]

AMO bugspam. Correcting QA contacts on OLD bugs ([e-mail])

-> Correct QA contact ([e-mail])

Filtermeplzkthx

Comment 11

[Cees T.]

Using http://www.imagemagick.org/script/index.php in a subprocess should work for any dynamic website.

Comment 12

[Fred Wenzel [:wenzel]]

(In reply to comment #11)
> Using http://www.imagemagick.org/script/index.php in a subprocess should work
> for any dynamic website.

Thanks. Though this comment may be more appropriate for bug 453370.

Comment 13

[Alfred Kayser]

I don't think that the preview.png image from the theme file need or should be converted to jpg. Also the icon is also extracted and used, so why not not the preview image as well, to make uploading easier?

Comment 14

[Wil Clouser [:clouserw]]

Thanks for filing this.  As you can see, it hasn't received much traction as 100% of the AMO team has been focused on other projects for a couple years now.

In an effort to not drown in existing reports we're aggressively closing old enhancements and bugs to get the buglist to a reasonable level so we can scope and process bug sprints in an effective manner.

Patches for this bug are still welcome.