255608 - F1 doesn't bring up help on OS/2

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Peter Weilbacher]

Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7.2) Gecko/20040814 Firefox/0.9.1+

The current aviary branch FF contains F1 as shortcut to Help->Help Contents,
which according to bug 251165 works at least on Win/Unix. This does not work on
OS/2. F1 shows no reaction at all, no error in the JS console, either.

Comment 1

[Felix Miata]

I suspect this should be a bug 88739 dupe. If not, it blocks bug 67376.

Comment 2

[Mike Connor [:mconnor]]

no, those are Suite bugs.

Steffen, any reason this doesn't work? I don't remember the details of the patch. :)

Comment 3

[Steffen Wilberg]

It really should work. The code I introduced in bug 251165 is here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/help/content/helpMenuOverlay.xul&rev=1.2.2.1.2.3&mark=60-64#60
I'd assume OS/2 doesn't match #ifdef XP_MACOSX, so it takes the #else route.
openHelp.commandkey is VK_F1, which works fine on Windows and Linux.

Looks like a platform-specific backend problem.

Comment 4

[Peter Weilbacher]

You are most likely right about the backend problem, I remember some discussion
about that on OS/2 some time ago, but was not able to dig it up yet. Will try to
have a look in the code tonight.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Fix for problem

On OS/2, F1 is handled internally by the OS and converted to another message
(WM_HELP).

Fix is just to add VK_F1 to the list of keyboard sequences that we steal from
the OS.

This should go on trunk as well.

Comment 6

[Peter Weilbacher]

Mike, you are too fast. :-) I thought I could have a few hours of fun looking
for this... Anyway, thanks! It works perfectly on Firefox.
Seamonkey still needs the patch from bug 88739 to go in, in addition to this
one, then it works there, too.

Comment 7

[Mike Kaply [:mkaply]]

Fix checked into 1.7, trunk, aviary.