255731 - autocomplete handler inconsistencies in the toolkits

Status: RESOLVED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[Pierre Chanial]

Seamonkey toolkit autocomplete widget handlers are: ontextcommand and
ontextrevert. The new toolkit ones are ontextentered and ontextreverted.
As a result, hitting return in the dom inspector url bar does not load the
document in firefox.

The last ones are more consistent with other handlers like onpopupshowing,
onpopupshown and I propose to deprecate ontextcommand and ontextrevert.

The patch I will attach does not get rid of them, but the handlers ontextentered
and ontextreverted would have the precedence.

Comment 1

[Pierre Chanial]

Attachment: patch seamonkey autocomplete.xml + inspector

If module owners are ok and even if I know thunderbird does not use the new
toolkit autocomplete widget, I am ready to change all the occurence of
ontextcommand and ontextrevert to the new ones and modify also mscott's version
of autocomplete.xml.
This patch has been tested on mozilla 1.7.2

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 156230 [details] [diff] [review]
patch seamonkey autocomplete.xml + inspector

Unforking is good.

Comment 3

[[e-mail]]

Comment on attachment 156230 [details] [diff] [review]
patch seamonkey autocomplete.xml + inspector

sr=me if you change all the occurrances not just inspector but remove the
fallback code as extensions can just provide both sets of attributes if
necessary.

Comment 4

[Andrew Schultz]

Attachment: fix the rest of xpfe and mail

Comment 5

[[e-mail]]

Comment on attachment 208058 [details] [diff] [review]
fix the rest of xpfe and mail

>-                 ontextcommand="return handleURLBarCommand(eventParam, domEvent);"
>+                 ontextentered="return handleURLBarCommand(eventParam, domEvent);"
>                  ontextrevert="return handleURLBarRevert();"
Missed one :-P

There are a bunch of fields with related names in autocomplete.xml that look unused.

I still don't understand why you want the fallback code, anyone writing a dual suite/toolkit compatible extension will already have had to provide both sets of attribtues.

Comment 6

[Andrew Schultz]

Attachment: patch v3

fixup ontextrevert, remove backwards-compat and nuke obsolete fields

I'd guess the backwards-compat is so that current suite-only extensions don't break... not that I'd guess there are many.  :(

Comment 7

[[e-mail]]

Comment on attachment 208170 [details] [diff] [review]
patch v3

I guess you can also kill <field name="onerrorcommand">.

Probably a good idea to get mail sign-off on this too.

Comment 8

[Andrew Schultz]

FIXED

Comment 9

[Paul Tomlin]

Comment on attachment 208170 [details] [diff] [review]
patch v3

Neil suggested approval-seamonkey1.1 was the right way to get this into TB2. Please.

Comment 10

[Robert Kaiser]

Comment on attachment 208170 [details] [diff] [review]
patch v3

This sounds to me like it touches more than just SeaMonkey and needs general 1.8.1.1 approval instead.

Comment 11

[Daniel Veditz [:dveditz]]

Comment on attachment 208170 [details] [diff] [review]
patch v3

approved for 1.8 branch, a=dveditz for drivers

Comment 12

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 208170 [details] [diff] [review]
patch v3

a=me for sm1.1

Comment 13

[Andrew Schultz]

(I landed on the branch without Neil's suggestion from comment 7, see bug 362163)