256048 - icon for the disabled Clean Up button in Downloads Manager missing

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Steffen Wilberg]

downloadCleanup.png is there, but downloadCleanupDisabled.png is still missing.

Comment 1

[miahz]

Quick fix would be to just use the regular icon for disabled state.  Since it's
gray, it kinda looks "disabled" anyway.  That would work until the VID team or
whoever can cook up an icon.  Not sure if this is a case where you just fade the
original icon, or have to come up with a different one.

Comment 2

[José Jeria]

*** Bug 260878 has been marked as a duplicate of this bug. ***

Comment 3

[u88484]

i know this is a seperate issue but any way of making the disabled icon default
when nothing in the downloads manger window

Comment 4

[chris hofmann]

not sure we would hold for this, but would would consider a pathch if one appears.

Comment 5

[Kevin Gerich]

fixed on branch ..

Comment 6

[Ryan Polk (Quark)]

Kevin: Winstripe is still pointing to a non-existant downloadCleanupDisabled.png
-
http://lxr.mozilla.org/aviarybranch/source/toolkit/themes/winstripe/mozapps/downloads/downloads.css#41

Comment 7

[Ryan Polk (Quark)]

Sorry about that Jesse (note to self, you just cleared your autocomplete
history!  It's different!)

Comment 8

[Chris Blore]

I still cannot see the icon using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041002
Firefox/0.10.1

Comment 9

[miahz]

Still not fixed in 20041005.

Stephen, we need a disabled "Clean Up" icon.

Comment 10

[Tracy Walker [:tracy]]

I've noticed the new icon in Download dialog -Clean up- button (a white
cross-out graphic in the middle of a red circle) looks good. But the disabled
(grayed out version) of the -Clean up- button is missing the icon altogether.  

tested against Windows Firefox branch build 2004-10-15-06-0.9

note: This works fine on linux.

Comment 11

[Ger Teunis]

I still can see this, no disabled icon. Shouldn't the "fixed-aviary1.0" keyword
be removed?

Comment 12

[Asaf Romano (gone)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041015
Firefox/0.10

not fixed.

Comment 13

[Jesse Ruderman]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041017 Firefox/1.0

WFM

Comment 14

[Ger Teunis]

Seems to be fixed indeed. A nice grayed-out clean-up button here on aviary1.0
build  20041018.

Comment 15

[u88484]

WFM for the past couple of builds

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041020 Firefox/1.0

Comment 16

[Ryan Polk (Quark)]

We don't need anymore WFM comments.  This is labeled "fixed-aviary1.0" and
rightly so, but it hasn't been checked into trunk, so it's not RESOLVED.

Comment 17

[Steffen Wilberg]

Fixed on trunk by the aviary landing.