256062 - Stop button should stop animations

Status: RESOLVED DUPLICATE of bug 21623

(Firefox :: Toolbars and Customization, enhancement)

Description

[Grey Nicholson (they/them)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.2) Gecko/20040816 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.2) Gecko/20040816 Firefox/0.9.1+

Firefox version of bug 21623

Reproducible: Always
Steps to Reproduce:
1. View an animated GIF, or visit a page containing one, in Firefox
2. Once the page has loaded, click the Stop button

Actual Results:  
Nothing happens.

Expected Results:  
Animations should stop, the Stop button should be disabled.

Comment 1

[Logan Ingalls]

Hit escape.

*** This bug has been marked as a duplicate of 213377 ***

Comment 2

[Grey Nicholson (they/them)]

I know about Escape - this is specifically about the Stop button.

Reopening.

Comment 3

[(not currently active) Ted Mielczarek]

This will undoubtedly be WONTFIXed per bug 213377 comment 15 .

Setting severity to enhancement.

Comment 4

[Peter van der Woude [:Peter6]]

I'm tempted to set INVALID
if escape works why do you want it under the stop button ?
The stop button goes inactive after a page has loaded.
Do you want the button to be always active ?

Comment 5

[Grey Nicholson (they/them)]

re: bug 213377 comment 15
I disagree that a toolbar button being enabled is annoying; users can remove it
if they like. To me it seems more annoying that a button is disabled when its
keyboard equivalent is functional. Apparently this UI was in Netscape 4 and
older, with no ill effect.

re: comment 4
As per bug 21623 comment 5, the Stop button should only be enabled if an
animation is present.

My main reason for this request is discoverability - I've used Firefox for about
a year without knowing it could stop animations in this way, a feature I did not
expect and find useful.

Users are much more likely to discover this function by clicking an active
toolbar button than by pressing Esc. (Esc also doesn't "feel" right - escape
means "leave", not "stop".) This is why I want it under the Stop button - such a
useful feature should have some UI.

If this is implemented, the Stop button's tooltip should change to "Stop
animations in this page" once the page has loaded; this would explain the
feature to those users who would be confused by the active Stop button. I assume
that those who don't know to hover over a button for an explanation of its
function probably don't know what Stop usually does anyway, so the button's
activeness would be no more confusing than its presence in the first place.

IMO, little touches like this make Firefox more pleasant to use and should be
advertised mercilessly.

Comment 6

[Robert Parenton]

INVALID per Bug 213377 comment 15 - Ben Goodger said "The always-enabled stop
button is annoying (especially since it's a subtlety that 99.9% of users won't
understand), but the escape option is fine."  As the project leader, Ben has the
final say.

Comment 7

[José Jeria]

*** Bug 256288 has been marked as a duplicate of this bug. ***

Comment 8

[José Jeria]

*** Bug 260369 has been marked as a duplicate of this bug. ***

Comment 9

[Jesse Ruderman]

*** Bug 269162 has been marked as a duplicate of this bug. ***

Comment 10

[Phil Ringnalda (:philor)]

*** Bug 280458 has been marked as a duplicate of this bug. ***

Comment 11

[Asaf Romano (gone)]

In the worst case it's a WONTFIX, not invliad.

anyway, the right soultion would be to enable the stop button only when there're
(looping) animated images.

Comment 12

[Asaf Romano (gone)]

(see bug 284140 comment 3 and 4)

Comment 13

[Daniel soeemod]

no it shouldt NOT !! what if you are on a site made in flash and then stop
animation then you would not be able to navigate the site also if the site only
uses flash for menu and you cant intercept the flash animation and get to stop
after my knowledge

Comment 14

[james]

the stop button should only stop animated gifs... not flash images, so would not
be a problem.

Comment 15

[Alexey Chernyak]

*** Bug 288014 has been marked as a duplicate of this bug. ***

Comment 16

[Felipe Corrêa da Silva Sanches]

(In reply to comment #14)
> the stop button should only stop animated gifs... not flash images, so would not
> be a problem.

No. STOP button should only stop page loading.

If someday this functionality come to be implemented it should have its own UI
button called "stop animations" so that we avoid confusion.

Comment 17

[Kanav Jain]

perhaps the stop button should have a drop-down for also stopping animations.
are you also considering the action for flash animations or just for animated gifs?

Comment 18

[flock31070]

Is this bug about if the page is half loaded, you stop it and animations still load, or just stopping animations period? If it's just stopping animations, that'd be...weird.

Comment 19

[Grey Nicholson (they/them)]

(In reply to comment #18)
> If it's just stopping animations, that'd be...weird.

It is just stopping animations. The fact that Esc stops animations is highly undiscoverable and Esc is supposed to be the keyboard equivalent of Stop.

Comment 20

[flock31070]

>>It is just stopping animations. The fact that Esc stops animations is highly
undiscoverable and Esc is supposed to be the keyboard equivalent of Stop.

So how do you stop an animation? Just press Esc anytime? Or click animation, then stop?

From what I understand of this bug, if I wanted to half load a page but still see an animation, I don't want Stop to stop it

Comment 21

[comperr]

Maybe it should change a little bit to lighter red - or yellow.  Or just have a seperate button.
Also right click should have this feature as well.

Comment 22

[Jacob]

I agree the stop button is for stopping the loading of a webpage but i do think that this feature in the right click would be much more useful as many people are worried about the escape key closing program and an array of other untrue ideas they have.