256154 - Treat "Add Bookmark" popup as other popups

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Zarco Zwier]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040817 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040817 Firefox/0.9.1+

Currently the "Add Bookmark" can be openened without consent of the user (visit
the URL above). So it can be used as an add popup.
Shouldn't it be treated as any other popup? Open the "Add Bookmark" popup when a
user instructs the browser to open it and in any other case, don't open it.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Patrick]

Zarco please list the steps to reproduce. There's a reason it's listed on the
bug report form. What should i do, and what should i see?

Going to the site you specify, i get a DIALOG if i want to install a SIDE BAR.
Pressing CANCEL on that window i get pop-up which is killed.

So nothing there about BOOKMARKS or POP-UPS not being killed?
This is with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3)
Gecko/20040813

Comment 2

[Zarco Zwier]

Sorry, thought this one was pretty clear.

Steps to reproduce:
Go to the specified URL.

Actual results:.
An "Add Bookmark" popup is automatically shown 

Expected results:
Nothing is shown, unless I click on a link (giving permission for opening a "Add
Bookmark" popup, which is not the case here)


When trying this at home using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8a3) Gecko/20040811 Firefox/0.9.1+, I get the same result as I did @ work
with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040817
Firefox/0.9.1+. 

According to the site:
======================
Actually not a pop-up, but very annoying. This test tries to open a sidebar in
your browser. The pop-up killer failed the test if a pop-up is displayed in the
sidebar, if you get annoying questions about adding a bookmark or if a pop-up
appear.
======================

Apparently the suite and Firefox do not exhibit the same behaviour when this
function is called, but nevertheless my request remains: should a website be
able to show popup or request to add a sidebar, while I did not ask for it?

Firefox only fails on 2 accounts in the complete popup test: an overlay "popup"
(which, I adit is hard to block) and the test specified. Wouldn't it be nice if
1 failing test were to be eliminated?

While thinking about this, does the same not apply to installing XPIs? (Should
this be addressed in a seperate report?)

Comment 3

[Dan M]

*** Bug 259719 has been marked as a duplicate of this bug. ***

Comment 4

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 5

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 6

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 7

[[:Aleksej]]

Confirmed with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070521 Minefield/3.0a5pre and on Solaris.

Comment 9

[Mark Banner (:standard8)]

The old addSidebar API that the example used has gone away, additionally the newer style doesn't seem to allow the option for causing it to happen automatically by javascript.

Therefore marking this as WFM as I believe it is no longer an issue.