256243 - Unabled to remove downloads / navigate downloads dialog mouseless

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect, P1)

Description

[Daniel O'Connor]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040803 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040803 Firefox/0.8

Downloads
While you can navigate the items, you can't remove an item - you can open it
with "enter" or space though. Open/Remove links should have access keys for when
an item is selected (o/r); change "Options" access key to Alt+p perhaps?

Reproducible: Always
Steps to Reproduce:
1. Open downloads dialog
2. Try to remove an item with keyboard only
3.

Actual Results:  
Unable to focus and remove item

Expected Results:  
Gain focus on "remove" link

Comment 1

[Jesse Ruderman]

Pressing the Delete key should function as cancel/remove, too.

Comment 2

[Nickolay_Ponomarev]

I can focus both Open and Remove links with keyboard. But clicking Enter always
behaves as if Open link was active.

After removing with Delete the dialog becomes absolutely inaccessible for me. I
can't even select an item with arrows.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041008
Firefox/0.10

Comment 3

[Aaron Leventhal]

The keyboard bugs should go in the keyboard navigation component.

Comment 4

[Aaron Leventhal]

Related: bug 263646

Comment 5

[Aaron Leventhal]

Please note: Shift+F10 or the context menu key should bring up the right click
context menu. Somewhere we're not using oncontextmenu. See item 9 in the
Accessible XUL Authoring Guidelines: http://www.mozilla.org/access/xul-guidelines 

Comment 6

[Aaron Leventhal]

*** Bug 263646 has been marked as a duplicate of this bug. ***

Comment 7

[Doron Rosenberg (IBM)]

Attachment: first try

Need testing :)

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 174508 [details] [diff] [review]
first try

r=[e-mail] ... let's see how this works.

Comment 9

[Aaron Leventhal]

Any way we can move away from hbox and use a list or some other standard widget?
The accessibility module has no idea what this stuff is or when an item gets
focused, etc.?

At the very least these download manager extension manager needs to be made into
a new widget in XBL so that I can use nsIAccessibilityService to create a new
kind of accessible for it.

I understand if this is not possible for 1.1, but then we need to file a
separate bug for making it work with assistive tech.

Comment 10

[Doron Rosenberg (IBM)]

checked in, please open a new one about assistive techs.

We also should consider making oncommand on more xul elements work :)

Comment 11

[Aaron Leventhal]

Several problems:
1. The focus is often not visible.
To repro: Open the download manager, Tab into first list item, down arrow past
the last item visible on the screen
Alternate repro steps: Open the download manager, down arrow several times, then
press Tab
Another way to repro: Open the download mgr, notice that focus is not visible,
shift+tab, focus is now on the lower right button, shift+tab again, focus is not
visible (it is on the 'all items download to: [folder - focus here=']). We need
to style that focus. Shift+tab again, and focus is at the end of the list but is
not visible unless you manually scroll there.

2. The tab order is not synced with the current list item
To repro: Open the download mgr, tab into the first list item, down arrow
several times, press tab again. The item you tabbed to is the 'Open' link for a
different item, but it should be for the current item.

3. Must hit escape twice to cancel download if 'Open' activated with keyboard
To repro: Tab to an 'Open' link to an executable. Hit Enter. At confirmation
dialog hit Escape. Dialog reappears.

4. Shift+F10 context menu often misplaced, appears on different item.
To repro: Open download manager, Tab and press down arrow 3 times, press
Shift+f10. Context menu shows up at top of download manager which makes it
appear to relate to a different item than it does.

Comment 12

[Aaron Leventhal]

*** Bug 276218 has been marked as a duplicate of this bug. ***

Comment 13

[Aaron Leventhal]

Mike & Ben, we have to jump through hoops to make this download mgr accessible
(see the 4 reasons why we reopened it in comment 11), yet it probably needs to
be reimplemented as a tree or list anyway for support of accessibility APIs (bug
285584). I think using a legitimate widget like a list would make it much
better. Mike, I read you are the new owner of this code, what do you think?

Comment 14

[Mike Connor [:mconnor]]

I'm not in favour of any UI changes here as an easy fix for a12y.  If we need to
implement a new type of widget in order to support proper focus/scrolling in
this and the extension manager, then that is what we'll have to do.

Trees have ensureRowIsVisible, I think we need that among other things, but
simply using a tree/list is going to decrease usability across the board.

Comment 15

[Aaron Leventhal]

(In reply to comment #14)
> Trees have ensureRowIsVisible, I think we need that among other things, but
> simply using a tree/list is going to decrease usability across the board.
Mike, can't we make it look the same as it does now but have a list widget
implement that?

Comment 16

[Mike Connor [:mconnor]]

What I meant is that I don't think we can do this without implementing a new
type of widget for extension, themes, and downloads managers to use.  Whether
that's something totally new or an extension of an existing widget isn't quite
the point.

As long as there's no UI changes, I'm not picky about how you want to implement it.

Comment 17

[Doron Rosenberg (IBM)]

Aaron - want to file a bug to create an accessible list element that can contain
richt content?

Doing one in xbl should be possible (including a scrollIntoView thing), but not
sure how to handle tab order issues.

Comment 18

[Aaron Leventhal]

(In reply to comment #17)
> Aaron - want to file a bug to create an accessible list element that can contain
> richt content?
I consider that bug 285584. 

Comment 19

[Doron Rosenberg (IBM)]

fixed

Comment 20

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381