257581 - Cursor (caret) doesn't appear in MailNews Compose Window, although you type something

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Get a nightly build
2. Reply to a mail or news posting
(3. Type something)

Actual Results: No cursor appears

Exspected Results: A cursor should appear

Comment 1

[Ruediger Lahl]

'Clicking' in the Text: Cursor appears.
Change Window(Alt-Tab) and after that go back to the  Mozilla Editpane, the
cursor is gone again.

Bug comes up with nightly 20040831xx 20040830xx works fine.

Comment 2

[Frank Wein [:mcsmurf]]

Ginn: Your patch in Bug 169297 caused this bug here.
Roc: CCing you, since you were the superreviewer of the patch and might be
interested in this (as always, feel free to un-CC again).

Comment 3

[Ginn Chen]

It seems this happens when you turn off "Caret browsing".
I'm trying to fix it.

Comment 4

[Ginn Chen]

Attachment: patch

Comment 5

[Ginn Chen]

Comment on attachment 157599 [details] [diff] [review]
patch

This is only a workaround, just like the origin code before fixing bug 169297.
We still have other problems. If we have a browser window and a composer window
at the same time, turning on caret-browsing will cause two cursors blink in two
windows.

Comment 6

[Ginn Chen]

Attachment: patch v2

Comment 7

[Ginn Chen]

Comment on attachment 157607 [details] [diff] [review]
patch v2

review?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 157607 [details] [diff] [review]
patch v2

+  PRInt16 isEditor = 0;

Move this inside the if.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

glazman, care to comment on this bug and patch?

Comment 10

[Ginn Chen]

Attachment: patch v2.1

Comment 11

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 157677 [details] [diff] [review]
patch v2.1


>+  nsIPresShell *shell = mPresContext->GetPresShell();
>+  if (shell) {
>+    PRInt16 displaySelection = 0;
>+    shell->GetSelectionFlags(&displaySelection);
>+    PRBool isEditor = (displaySelection == nsISelectionDisplay::DISPLAY_ALL);
>+    if (isEditor)
>+      return; // Never browse with caret in editor
>+  }
>+

Errrr. I am not sure it's the best way to determine if we have an editor here
or not. You should try to do that through the docShell and nsIEditingSession.

Comment 12

[Ginn Chen]

I tried this, but I can always get editSession. So no caret visiable for
caret-browsing now.

+  nsCOMPtr<nsIDocShell> docShell = do_QueryInterface(shellItem);
+  if (docShell) {
+    nsCOMPtr<nsIEditingSession> editSession = do_GetInterface(docShell);
+    if (editSession) {
+      return; // Never browse with caret in editor
+    }
+  }

Comment 13

[Frank Wein [:mcsmurf]]

*** Bug 258019 has been marked as a duplicate of this bug. ***

Comment 14

[Ginn Chen]

Attachment: patch v3

this one works for me

Comment 15

[Ginn Chen]

Comment on attachment 158084 [details] [diff] [review]
patch v3

I found similar code in the same file. review?

Comment 16

[Ginn Chen]

Attachment: patch v3

sorry, I forgot to change the comment

Comment 17

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 158085 [details] [diff] [review]
patch v3

seems ok to me, although I don't know the nsEventStateManager context.
Please make sure this does not break Midas, Composer and form textareas.
Thanks.

r=[e-mail] providing the tests I require above are done and ok.

Comment 18

[Ginn Chen]

Tested against Midas, Composer and form textareas, with Caret Browsing on/off.
All pass.

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 158085 [details] [diff] [review]
patch v3

a=asa for checkin to 1.8a4. Time is short so please get this landed ASAP.
Thanks.

Comment 20

[Kyle Yuan]

fixed.

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with Seamonkey trunk build 2004-10-01-05 on Windows XP.

Comment 22

[Mike Cowperthwaite]

*** Bug 258689 has been marked as a duplicate of this bug. ***