258447 - Mail Start Page ignores character setting

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Pavel Franc - Mozilla.cz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: version 0.7+ (20040901)

Mail Start Page is displayed in iso-8859-1 even if other character encoding is
specified in meta.

Reproducible: Always
Steps to Reproduce:
1.Go to tools->options->general->Thunderbird Start Page and set your start page
to  http://www.slovo.info/testuni.htm 
2.Go to Go->Mail Start Page


Actual Results:  
UTF-8 character encoding is ignored. You see garbage insted of coresponding
characters.

Comment 1

[Met - Martin Hassman]

This really affects lozalization of the Thunderbird start page.

Comment 2

[Scott MacGregor]

yuck, i wonder if the charset changes to make RSS articles look correct
regressed this. 

Comment 3

[Martin Creutziger [:MMx]]

I can confirm this behaviour with build "version 0.8 (20040908)" in Windows NT4
TB 0.7.3 does not have this bug.

Comment 4

[Piotr Komoda]

I can confirm this too. Start Page in newest Thunderbird pre-0.8 nightlys
localized to Polish (UTF-8 encoded) looks just like a total mess. This
definitely should be a 0.8 blocker.

Comment 5

[Scott MacGregor]

do you guys see this problem in trunk builds too or just the branch?

I wonder if this was caused by my branch only changes for Bug #253807....hmmm

Comment 6

[Piotr Komoda]

(In reply to comment #5)
> do you guys see this problem in trunk builds too or just the branch?

I've previosly tested it only on the aviary builds, which i'm trying to keep
up-to-date with localization, but let me do some test on a trunk build...

Nope, in the trunk builds everything is OK. 

Comment 7

[Scott MacGregor]

It may be too late to fix this for 0.8 but I'll try. Does anyone on the cc list
have a debug build where they can try to back things out or test potential fixes?

I looked at my change for Bug #253807 and I'm starting to think it couldn't be
the cause. Because we set the charset to an empty string just befor loading the
start page....

Can someone attach an example start page with non ascii characters to the bug
that I can use to test? Thanks!

Comment 8

[Met - Martin Hassman]

Attachment: Czech star page

Here is Czech start page. In the browser it looks correctly, in the TB there is
chaos.

Comment 9

[Hidehiro Kozawa]

http://lxr.mozilla.org/aviarybranch/source/mailnews/base/resources/content/mailWindow.js#513

code below makes this bug?
505 function loadStartPage() {
...
515             if (startpage != "") {
516                 // first, clear out the charset setting.
517                 messenger.setDisplayCharset("");

Comment 10

[Hidehiro Kozawa]

Attachment: patch

Patch of Bug 59787 seems to be emptiness now.
This patch seems to fix it.
This is for 
mozilla/ mailnews/ base/ resources/ content/ mailWindow.js 
(means for ontent\messenger\mailWindow.js in chrome\mail.jar).
Test of this patch can do only changing mailWindow.js in mail.jar without
build.

Comment 11

[Hidehiro Kozawa]

Comment on attachment 160332 [details] [diff] [review]
patch

who can review it?

Comment 12

[Simon Montagu :smontagu]

Please do careful regression testing for all the cases where bug 59787 occurred
with a non-ASCII and non-UTF-8 start page.

Comment 13

[Scott MacGregor]

Comment on attachment 160332 [details] [diff] [review]
patch

I need testing help to regression test this so I'm going to get it checked in
so folks can look at it. Thanks so much for the patch!