259199 - Tooltips don't work in the sidebar

Status: RESOLVED FIXED

Description

[Trejkaz (pen name)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3

When there is an HTML "title" attribute on an element of a page loaded in the
sidebar, the tooltip does not appear for the attribute.

Reproducible: Always
Steps to Reproduce:
This is just one example, as it's the main sidebar I use which would have
tooltips on it.
1. Go to http://sitebar.org/sitebar3/ .
2. Click on the link "SiteBar" in "Mozillazine topic describes how to use
SiteBar sidebar extension" which will install the sitebar extension.
3. Click on the link "SiteBar" and hover over some of the buttons up the top to
confirm that the tooltips are there.
4. Open the SiteBar sidebar and hover over the same buttons.

Actual Results:  
Nothing happens while hovering over the buttons.

Expected Results:  
Tooltips should have been displayed, the same as if the page were loaded in the
main frame.

Comment 1

[Håvar I. Henriksen [:havarh]]

Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040911 Firefox/0.10
Same problem here.
Try opening e.g. this page: http://www.mozilla.org/products/firefox/ in the
sidebar, and when hovering the mouse over the mozilla logo at the top you should
see the text [Return to homepage] in a tooltip. This works fine in a normal
window, but the tooltip doesn't show up if the page is loaded in a sidebar.

Reproducible: Always
Steps to Reproduce:
1. Add this link as an bookmark: http://www.mozilla.org/products/firefox/
2. Go to Bookmarks|Manage Bookmarks and right click on the bookmark you added
and select properties
3. Click the "Load this link in the sidebar" checkbox
4. Close the Bookmarks Manager
5. Select the bookmark you added in your bookmark menu and watch the link open
in a sidebar
6. Try to hoover the mouse over the mozilla logo

Actual Results:  
Nothing happens when hoovering the logo

Expected Results:  
Tooltips should have been displayed, the same as if the page were loaded in the
main frame.

Comment 2

[Håvar I. Henriksen [:havarh]]

Created attachment 159272 [details] [diff] [review]
Simple oneline patch that would fix this bug

This simple patch adds the attribute tooltip="aHTMLTooltip" to the <browser
id="sidebar"> sidebar component

Comment 3

[Håvar I. Henriksen [:havarh]]

this is a duplicate of 229831

Comment 4

[Dimitrios]

confirming based on comment 1. Havar, please don't set blocking-aviary1.0 flag
to + if you don't have the privileges to do so. For your patch to have chances
for review, you must set the appropriate flag and check guidelines at
http://www.mozilla.org/hacking/code-review-faq.html

Comment 5

[Dimitrios]

*** Bug 229831 has been marked as a duplicate of this bug. ***

Comment 6

[Dimitrios]

forgot to say that you can still nominateitfor aviary by setting the associated
flag to "?"

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 159272 [details] [diff] [review]
Simple oneline patch that would fix this bug

first, this isn't the same tooltip as the bookmarks toolbar, second, it doesn't
 quite seem to work right, and third, I don't think we want every sidebar to
have this.

Comment 8

[Trejkaz (pen name)]

I thought it should be possible in any sidebar, but really I'm easy, as long 
as custom sidebars like Sitebar work properly. 
 

Comment 9

[Jonathan Haas]

(In reply to comment #7)
> first, this isn't the same tooltip as the bookmarks toolbar, second, 

Why should this be the same tooltip as in bookmarks-toolbar? It should be the same like on any other webpage. FYI, I can see no difference between the tooltips in the bookmarks toolbar an the tooltips from this patch.

> it doesn't quite seem to work right, 

I have no problems with this patch. What does not work right?

> and third, I don't think we want every sidebar to have this.

Why not? For example an this ( http://de.selfhtml.org/navigation/sidebars/html.htm
 ) sidebar, this is really annoying, because, you can't see the tooltips from the red X'es, when hoovering them.
There is no reason, why we would hide the tooltips from the user intentional. This is like saying: "It's not a bug, it's a feature, we want wo hide these evil tooltips from the user".

Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8) Gecko/20051107 Firefox/1.5

Comment 11

[Nick R]

I posted Bug 383834, which is a duplicate of this bug. Is it fixed in the current build (2.x)?

Comment 12

[Trejkaz (pen name)]

2.0.0.5 certainly still exhibits the problem.  It's pretty easy to verify.

Comment 13

[Yves Orton]

2.0.0.6 still exhibits this problem. 

On my linux box making the change as described by Jonathon Haas makes them work as expected. Please can his patch be applied for the next release?

Comment 14

[Yves Orton]

Whoops I meant Håvar I. Henriksen's patch resolves this issue.

Comment 16

[Samuel Bronson]

This bug also plagues http://www.rainwave.cc/sidebar/

Comment 18

[David McRitchie]

This bug is about displaying a webpage in the sidebar, and not allowing showing tooltips (/titles).

This is not a duplicate of bug 244371 which is strictly for bookmarks and history.

This bug see comment #1 which is not about looking at bookmarks in the sidebar, but about the sidebar brought up when using option in a bookmark to display the bookmarked webpage into the sidebar.   See comment #7 from Mike Conner specifically stating that this is NOT the same as tooltips on the bookmarks toolbar; therefore, this should not be  resolved by pointing to bug pertaining to bookmarks. 

Other bugs about use of webpages in side bar have been pointed to this bug.

Comment 19

[Gabriele Best [:Gabri]]

Created attachment 367471 [details] [diff] [review]
Working patch

This patch fixes the problem and Mike's review (comment #7).

It displays a tooltip over webpages only, it doesn't display a tooltip over any other sidebar (e.g.: bookmarks and history sidebar bug 244371)

Comment 20

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 367471 [details] [diff] [review]
Working patch

Review -> land on trunk -> then ask for approval.

Comment 22

[Mike Connor [:mconnor]]

Comment on attachment 367471 [details] [diff] [review]
Working patch

Dao, can you take a look? I'm still way behind on my queue...

Comment 23

[Dão Gottwald [::dao]]

http://hg.mozilla.org/mozilla-central/rev/e6a1fab0c9f6