260306 - live bookmarks pick up favicon only after visiting an item

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect, P5)

Description

[Dave Chand]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10

I have slashdot bookmarks as an rss feed. When I look at the headlines of the
feed they all have the generic firefox placeholder bookmark. Only after I have
visited a link of the feed is the icon changed to the site's icon.
This bug is not limited only to slashdot's rss feed.

Reproducible: Always
Steps to Reproduce:
1.visit http://www.slashdot.org
2.add slashdot's rss feed as a bookmark
3.open slashdot's rss feed bookmarks and look at their icons, they will all have
the generic icon.
4. visit a link from the feed, then check the rss bookmarks again,  the slashdot
site icon will appear only next to the feed you just visited

Actual Results:  
 the site icon only appears for the rss link that was visited, not any of the others

Expected Results:  
The site icon should appear for all of the rss links.

Comment 1

[Dave Chand]

Attachment: JPEG showing what I am talking about, circled in red

Comment 2

[u88484]

Pretty sure https://bugzilla.mozilla.org/show_bug.cgi?id=237158 blocks this bug,
also:

Summary: needs to be changed to something along the lines of "favicon should
appear for all rss links, not just visited links

Severity: should be changed to Enhancement, since no favicons are shown until a
page or rss link is visited

Hardware and OS: should be changed to all since this is also the case on PC not
just Mac.


I know this should be (probably is) another bug filed, but also for when
bookmarking a website the favicon should also be saved at that time, the default
favicon should not be there if the site has a favicon. Only reason why I said
the above is because both deal with showing favicons before visiting a page.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This is a byproduct of the way favicons and live bookmark items are handled; in
theory, the favicon should show up for the parent, and not for each individual
item (we can't fetch each individual item's favicon).  This won't get fixed for
1.0 though.

Comment 4

[Reuben Farrelly]

I'm still seeing this with trunk builds - and in fact can't remember a time ever
when it wasn't the case.  The favicon never appears against the parent
feed...only ever against a child entry after the child URL has been visited.

Also probably related - I also see that the favicons are not saved across
restarts with the live (child) bookmarks.  In other words, if the live bookmark
is loaded and a favicon appears, then it will continue to appear _until_ firefox
is reloaded, at which point it disappears again and the link needs to be
revisited for the icon to reappear (even if the live bookmarks haven't changed
at all).  Not sure if I should file this as a separate bug or not..

Comment 5

[u88484]

does this bug depend on 237158. also hardware should equal All, and OS=All

Comment 6

[Gideon Newell]

This one has always bothered me as a Livebookmark user. I see it as a superset
of bug #304902 (reprinted below):
*******************************************

Livemarks in the Bookmarks menu all use the same orange icon, and can be
confused with adjacent livemarks. I suggest an enhancement allowing the livemark
icon to be replaced with the site's Favicon, as with 'normal' bookmarks.

Reproducible: Always

Steps to Reproduce:
1. Add livemark to bookmarks
2. Hover over or click on a livemark entry
Actual Results:  
Cannot distinguish adjacent livemarks visually by icon. See screenshot at:
http://www.newellcreations.com/other/Bugzilla/LiveBookmarksBEFORE.png

Expected Results:  
Livemarks visually represented with site Favicon, as with 'normal' bookmarks.
See screenshot at:
http://www.newellcreations.com/other/Bugzilla/LiveBookmarksAFTER.png

Comment 7

[Julian D. A. Wiseman]

It happens with non-live bookmarks as well. I'm manually adding lots of dmoz.org categories as bookmarks, and those visited get proper favicons, those not don't. 

Comment 8

[Brett Wilson]

Assigning to places, which will be doing favicons for Firefox 2. I'm not sure how feasible this is.

Comment 9

[Brett Wilson]

*** Bug 330176 has been marked as a duplicate of this bug. ***

Comment 10

[Jackie Liu]

I request:

(a) this bug's component be moved to "Bookmarks"
(b) priority be moved to P2 or

Comment 11

[Jackie Liu]

I request this bug's priority be moved up to P2.

Comment 12

[Brett Wilson]

Right now the best place for future bugs on bookmarks is Places since that is the current bookmarks system on trunk. I this the low priority is appropriate.

Comment 13

[Jackie Liu]

So, does this bug not apply to Firefox 2.0?

Comment 14

[Brett Wilson]

I think it does apply to Firefox 2. I guess we could have a duplicate entry on Bookmarks for this problem for Firefox 2, but there is no way it will be fixed in Firefox 2, so it's not very useful. The Bookmarks system for Firefox 3 is kind of in flux, so it's not really clear what to do about bugs yet.

Comment 15

[Marco Bonardo [:mak]]

Places has a generic livemark icon for items until they are visited, so i suppose this could be a WONTFIX (imo) since i can't see a point in preloading all favicons for all livemark children, that would also cause slowdown in case of many livemarks.

Comment 16

[Dietrich Ayala (:dietrich)]

I think this is not WONTFIX. The way that some items have favicons and some don't for the same feed is definitely a polish issue. For consistency, maybe we should instead just display the feed icon if available or the default icon, if the item is a livemark child.

Comment 17

[Marco Bonardo [:mak]]

we are displaying the default icon... this bug is talking about the "completely white" icon, while now we have a "livemark child" icon.
So is the request to look for a feed icon and show that instead of the generic livemark item icon? OR to preload all favicons from all livemark child?

Comment 18

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 19

[Stefan Plewako [:stef]]

I find it very useful when using (live) bookmarks - it allows me to quickly focus on items that I didn't open (read).

(In reply to Reuben Farrelly from comment #4)
> Also probably related - I also see that the favicons are not saved across
> restarts with the live (child) bookmarks.

I can't see this anymore.

(In reply to Dietrich Ayala (:dietrich) from comment #16)
You can't display favicons for every item in library simply because some sites don't provide them…

+1 for wontfixing

Comment 20

[Marco Bonardo [:mak]]

now this is wontfix for real, since we won't display anymore the site icons for livemark children, just a visited/unvisited icon.