260549 - Right-clicking on bookmark in a folder on bookmarks toolbar loads bookmark and context menu

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[James Clarke]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10

Right-clicking on a bookmark within a folder on the bookmarks toolbar loads the
url and the context menu, the context menu persists until escape is pressed or
an option clicked.  A click away (anywhere but the menu) does not remove the
context menu.

Reproducible: Always
Steps to Reproduce:
1. Add a folder inside bookmark toolbars
2. Add a bookmark within new folder
3. Left-click folder on bookmarks toolbar
4. Right-click bookmark
Actual Results:  
Bookmark loaded, context menu appeared, context menu persists.

Expected Results:  
Context menu appears, bookmark shouldn't load, click away removes menu.

Comment 1

[Asaf Romano (gone)]

confirmed

Comment 2

[a_geek]

I have a different behaviour: When I right-click on a bookmark that's shown in a
folder from the Personal Toolbar, I get _no_ reaction. That's sort of better
than  loading the bookmark, but not the expected result. The expected result
would be to show the context menu (esp. to adjust properties).



Mozilla version info: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3)
Gecko/20040913 MultiZilla/1.6.4.0b

(ie, Mozilla-The-Suite, didn't check with Firefox)

Comment 3

[Vi Vovan]

Attachment: Picture of context menu (or lack of) when right clicking bookmark menu

Picture of context menu (or lack of) when right clicking bookmark menu on
Windows XP.

Comment 4

[Vi Vovan]

Right clicking on the bookmarks in the main menu, I also get no context menu at
all, just a little box comes up with no contents. This has been the case for
many builds over 1-2 months + for me.

Windows XP SP2, using branch nightly build.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041022 Firefox/1.0

Comment 5

[Asaf Romano (gone)]

(In reply to comment #4)
> Right clicking on the bookmarks in the main menu, I also get no context menu at
> all, just a little box comes up with no contents. This has been the case for
> many builds over 1-2 months + for me.
> 
> Windows XP SP2, using branch nightly build.
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041022
Firefox/1.0

Please file a separate bug on the windows case, this one deals a different issue
(OS X only).

Comment 6

[:Gavin Sharp [email: [e-mail]]]

The "context menu persists" part of this is bug 259423 isn't it?

Comment 7

[Jonathan Fordyce]

When right clicking on bookmark located inside bookmark folder, instead of right
click options, the page loads as if left clicked.

Comment 8

[Asaf Romano (gone)]

On mac, left, right and control click _in a context menu_ should activate the
command, without opening another context menu. Our mac event code does handle
the first part (left/right/ctrl click activate context menu commands) but we
still open a [mostly not working] second context menu, when it's defined.

Comment 9

[Asaf Romano (gone)]

Attachment: #ifndef context menus for bookmarks inside a folder popup

see comment 8

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 173110 [details] [diff] [review]
#ifndef context menus for bookmarks inside a folder popup

r=[e-mail]

Comment 11

[Asaf Romano (gone)]

Attachment: Complete fix

I have added the #ifndef in three more places (in order to handle the overflow
menu), r=vlad for them on irc.

Comment 12

[José Jeria]

I find it a bit odd that you can right click the bookmarks in the toolbar menu,
but not the ones within a folder. Same goes with the bookmark menu.

Would it be possible to add this to the mac version? If yes, I can file a bug,
if not then not...

Comment 13

[Asaf Romano (gone)]

(In reply to comment #12)
> I find it a bit odd that you can right click the bookmarks in the toolbar menu,
> but not the ones within a folder. Same goes with the bookmark menu.

AFAIK that's what any other mac browser does (and i'm not sure what do you mean
by "bookmark menu").

Comment 14

[José Jeria]

(In reply to comment #13)
> AFAIK that's what any other mac browser does (and i'm not sure what do you mean
> by "bookmark menu").
>

Ah, I noticed this now. Kind of new to mac. Thanks for your reply.

Comment 15

[Asaf Romano (gone)]

*** Bug 276489 has been marked as a duplicate of this bug. ***

Comment 16

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change