Closed Bug 260704 Opened 20 years ago Closed 20 years ago

Can Uninstall/Update/Disable/Enable an Uninstalled extension

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
1.7 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.7.5

People

(Reporter: ian, Assigned: steffen.wilberg)

References

Details

(Keywords: fixed-aviary1.0, Whiteboard: no trunk checkin yet)

Attachments

(1 file, 2 obsolete files)

unbitrotten
4.43 KB, patch
bugs
: review+
bugs
: approval-aviary+
Details | Diff | Splinter Review 
STEPS TO REPRODUCE
0. Install an extension.
1. Uninstall an extension.
2. Without restarting, uninstall it again.

EXPECTED RESULTS
Step 2 should not be possible.

ACTUAL RESULTS
Step 2 is possible.
You can more stupid things, like update, disable, enable (reopen EM to do
reenable). 

Modifying the extensions's preferences is probably okay since it is still active
until you restart Firefox.
OS: Windows 2000 → All
Hardware: PC → All
Summary: Can Uninstall an Uninstalled extension → Can Uninstall/Update/Disable/Enable an Uninstalled extension
Version: unspecified → 1.0 Branch
Working on it.
Assignee: bugs → steffen.wilberg
Target Milestone: --- → Firefox1.0
Attached patch patch v1 (obsolete) — — Splinter Review 
Disables cmd_useTheme, cmd_options, cmd_uninstall, cmd_update, cmd_enable and
cmd_disable when an item is to be uninstalled.
cmd_about and cmd_homepage are still enabled in that case.
cmd_reallyEnable only controls whether to show Enable or Disable in the context
menu of extensions, so there's no change neeeded there.

I also disabled cmd_update when the selected item is to be installed, since the
Update dialog doesn't ever finish in that case.
Attached patch patch v1.1 (obsolete) — — Splinter Review 
same as before, but without a stupid change to cmd_about
Attachment #159733 - Attachment is obsolete: true
Attachment #159736 - Flags: review?(bugs)
Flags: blocking-aviary1.0?
Whiteboard: [have patch]
*** Bug 257961 has been marked as a duplicate of this bug. ***
Flags: blocking-aviary1.0? → blocking-aviary1.0+
Comment on attachment 159736 [details] [diff] [review]
patch v1.1

Bitrotten because of bug 258892.
Attachment #159736 - Attachment is obsolete: true
Attachment #159736 - Flags: review?(bugs)
Attached patch unbitrotten — — Splinter Review 

    
  

        Attachment #160956 -
        Flags: review?(bugs)

    
    

    
  
Checked into branch.
Doesn't at all apply on trunk, but that's hardly a surprise.
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: [have patch] → no trunk checkin yet
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: