260704 - Can Uninstall/Update/Disable/Enable an Uninstalled extension

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Hixie (not reading bugmail)]

STEPS TO REPRODUCE
0. Install an extension.
1. Uninstall an extension.
2. Without restarting, uninstall it again.

EXPECTED RESULTS
Step 2 should not be possible.

ACTUAL RESULTS
Step 2 is possible.

Comment 1

[Steffen Wilberg]

You can more stupid things, like update, disable, enable (reopen EM to do
reenable). 

Modifying the extensions's preferences is probably okay since it is still active
until you restart Firefox.

Comment 2

[Steffen Wilberg]

Working on it.

Comment 3

[Steffen Wilberg]

Attachment: patch v1

Disables cmd_useTheme, cmd_options, cmd_uninstall, cmd_update, cmd_enable and
cmd_disable when an item is to be uninstalled.
cmd_about and cmd_homepage are still enabled in that case.
cmd_reallyEnable only controls whether to show Enable or Disable in the context
menu of extensions, so there's no change neeeded there.

I also disabled cmd_update when the selected item is to be installed, since the
Update dialog doesn't ever finish in that case.

Comment 4

[Steffen Wilberg]

Attachment: patch v1.1

same as before, but without a stupid change to cmd_about

Comment 5

[Michael Lefevre]

*** Bug 257961 has been marked as a duplicate of this bug. ***

Comment 6

[Steffen Wilberg]

Comment on attachment 159736 [details] [diff] [review]
patch v1.1

Bitrotten because of bug 258892.

Comment 7

[Steffen Wilberg]

Attachment: unbitrotten

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 160956 [details] [diff] [review]
unbitrotten

r+a=[e-mail]

Comment 9

[Steffen Wilberg]

Checked into branch.
Doesn't at all apply on trunk, but that's hardly a surprise.