262286 - Uninstaller is not fully localizable through l10n CVS

Status: RESOLVED WORKSFORME

(Firefox :: Installer, defect)

Description

[Andras Timar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10

The Uninstaller contains the following user visible strings "hard coded" in .rc
files:

1. "Extracting..."

2. "Extracting %s"
3. "Launching Setup..."
4. "Unable to write file %s"
5. "Installation"
6. "Out of memory!"

In fact 4 and 6 hopefully will be never displayed, but the rest of them appear
during the uninstallation process and should be localizable. I used to translate
them using Resource Hacker. If Mozilla Foundation would produce localized
builds, this was no longer possible.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Vidar Haarr (not reading bugmail)]

I guess the best way to do this would be to modify
<http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/build/scripts/makeuninstallini.pl>
to use GNU gettext, and create a PO file for each language. When creating
uninstall.ini[1], it would then use _("String") instead of "String", and we'd
all be happy.

1: The template for moz win32, just as an example:
<http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/build/win/mozilla/uninstall.it>

Any comments to this process? Specifically, any thoughts about using gettext ?
CC'ing bsmedberg for build-foo.

Comment 2

[Vidar Haarr (not reading bugmail)]

Henrik: Any thoughts on using PO ? Are there easier/better alternatives?
I guess we could just make it a .properties file, and read it in and create a
hashmap, and use that to output things..

Would that be better? I'm not sure other things in mozilla.org-CVS are dependant
on gettext yet (I think it's being considered for umo, at least) ?

Comment 3

[Benjamin Smedberg]

We should be loading these strings from the uninstall.ini file. Adding a
build-time dependency on PO tools is not acceptable at this time.

Comment 4

[Vidar Haarr (not reading bugmail)]

bsmedberg: So should the l10n teams just translate the uninstall.it templates?

Comment 5

[Vidar Haarr (not reading bugmail)]

*** Bug 300099 has been marked as a duplicate of this bug. ***

Comment 6

[Alex Ihrig [:Thunderbird_Mail_DE]]

1) The above mentioned strings could be in the 7zip part of the installer, too.

2) The Uninstaller has more than the above mentioned strings! E.g. there is the
question, if the user really wants to uninstall the application. In the past
(before CVS l10n) we were able to translate the uninstaller by manually editing
the uninstall.ini file, which is included in the packed UninstallThunderbird.exe
/ UninstallFirefox.exe.

Comment 7

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: German example file for uninstall strings

Comment 8

[Robert Strong (they/them - no direct email)]

They can now be localized as of the new installer that landed - bug 326580. The 7-zip strings are bug 260914.
resolving -> wfm