262423 - "Leave on server" mails deleted by filter option "Set Junk Status"

Status: RESOLVED DUPLICATE of bug 224563

(Thunderbird :: General, defect)

Description

[Neil Taylor]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Thunderbird 0.8 (20040913)

using "Leave on Server" to preview mail worked fine upto and including 0.7.3;
in 0.8 I found "some" messages were deleted.
Since I was discarding previewed messages and relying on the 2nd download (at
home) to fetch and archive messages, I lost 20-50 mails (that I would have kept)
before I worked out what was happening.


Reproducible: Always
Steps to Reproduce:
1. set e-mail account to "Leave on Server"
2. set up a Message Filter
3. add the action "Set Junk Status to Not Junk"
4. download mail from server

Actual Results:  
messages that triggered the filter action have been deleted from the server; all
other messages have been left on the server (verified by independent Web-mail
interface)

Expected Results:  
left all messages for the "Leave on server" account on the POP server

was fine up until 0.7.3
broken in 0.8


this counts as "makes you lose data" since I discard previewed messages - and
then find that they are deleted when I download for real at home

Comment 1

[Mike Cowperthwaite]

Under the POP3 Server settings, do you have this option checked?:
  [] Until I delete or move them from Inbox
If you are manually deleting the messages, and that setting is checked, then 
*that* is why they are being deleted from the server.

Setting the Junk Status to anything should not affect the destination of the 
messages; are they in fact ending up in your Inbox before you discard them?

Comment 2

[Neil Taylor]

no, both "for at most N days" and "until I ..." are cleared.

<at work> when I preview the messages, with "leave on server", all messages are
downloaded to the work PC, and can be read locally. They are (or not) filtered
as they arrive - their dispatch to other folders does not affect their fate.
-- now that I know of the problem and have cleared all "set junk status to..."
actions, the preview download and filters all work fine, both to InBox and other
folders, and messaages remain on the POP Server.

The only factor I found which caused a problem here was quite specifically: if
the filter triggers the action "set junk status to ..." then that filtered
message is removed (deleted) *from the POP server* as part of the download (even
if it also remains in InBox);
messages which are unfiltered, or whose filter does not include this action
remain on the server -- both cases within ONE download from the server.
Thus some messages may be left and some deleted out of the download.
No messages are deleted on the local (work) PC as a result of the filters. 

[however, the human reader, after previewing, would delete the temporary copies,
 expecting to re-download at home, for permanent storage. The SECOND, home,
download finds the messages deleted from the POP server, and because also
deleted by hand from the work PC, lost for good.]

<at home> where I do not use "leave on server" the filters are fine, and "set
junk status to..." is without problem..

Since the account in question has a (****) web-mail provided by NTL, I can
separately peek into the POP mailbox without any downloads. This confirms the
server deletion of messages.

Comment 3

[WADA:World Anti-bad-Duping Agency]

Confirmed with Thunderbird nightly latest-0.9 2004/11/23 build(Win-2K).
Server settings is as follows, as Neil Taylor says.
(1) Check "Leave messages on server"
(2) Uncheck "For atmost NN days"
(3) Uncheck "Until I delete or move them from Inbox"
If a mail satisfied a filter rule which has condition of "Set Junk Status as
Junk" or "Set Junk Status as Not Junk", the mail was deleted from server because
Thunderbird sent "DELE" after "RETR".

Comment 4

[WADA:World Anti-bad-Duping Agency]

Attachment: NSPR log (POP3:5)

(Test sscenario and result)
(1) Send 5 mails to myself
   (1-1) Subject: test1
   (1-2) Subject: test2
   (1-3) Subject: test3
   (1-4) Subject: test4
   (1-5) Subject: test1
(2) Receive mails
(3) Message filter works
(4) Mails are deleted from server except mail of "Subject: test1"

(Filter rules)
name="test1"
  action="Move to folder"
  actionValue="mailbox://[e-mail]-01/Filtered"
  condition="OR (subject,contains,test1)"
name="test2"
  action="JunkScore"
  actionValue="0"   (Set Junk Status as Not Junk)
  condition="OR (subject,contains,test2)"
name="test3"
  action="JunkScore"
  actionValue="100"  (Set Junk Status as Junk)
  condition="OR (subject,contains,test3)"
name="test4"
  action="Move to folder"
  actionValue="mailbox://[e-mail]-01/Filtered"
  action="JunkScore"
  actionValue="0" (Set Junk Status as Not Junk)
  condition="OR (subject,contains,test4)"

(Filter log)

Applied filter "test1" to message from  -  at 1970-01-01 09:00:00
Action = Move to folder mailbox://[e-mail]-01/Filtered
 id = 

Applied filter "test2" to message from Wada
<[e-mail]> - test2 at 2004-11-25 01:21:32
Action = JunkScore 

Applied filter "test3" to message from Wada
<[e-mail]> - test3 at 2004-11-25 01:21:39
Action = JunkScore 

Applied filter "test4" to message from Wada
<[e-mail]> - test4 at 2004-11-25 01:21:52
Action = JunkScore 

Applied filter "test4" to message from  -  at 1970-01-01 09:00:00
Action = Move to folder mailbox://[e-mail]-01/Filtered
 id = 

Applied filter "test1" to message from  -  at 1970-01-01 09:00:00
Action = Move to folder mailbox://[e-mail]-01/Filtered
 id =

Comment 5

[WADA:World Anti-bad-Duping Agency]

Bug 195052 introduced automatic mail delete function when marked Junk even when
"Leave Message on Server".
I suspect error of the patch ;
 - Patch of Bug 195052 deletes mail from server even though "Set as *NOT* Junk".

Comment 6

[WADA:World Anti-bad-Duping Agency]

Sorry, Bug 195052 is still open and no patch is created for it.
DUP of Bug 224563?

Comment 7

[Mike Cowperthwaite]

This bug does appear to be a dupe.  I don't think the patch made it into the 
TB 1.0 branch, but current nightly builds will have it.

Neil Taylor, if you find that nightly builds, or TB 1.1 (once it's released) 
still exhibit this problem, feel free to reopen.

*** This bug has been marked as a duplicate of 224563 ***