262544 - Firefox should indicate a restart is needed after installing 0.10.1 update

Status: RESOLVED INVALID

(Toolkit :: Application Update, defect)

Description

[Stuart]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10

Hi.  While using 1.0 Preview Release (0.10), I was notified that a critical
update was available via that red arrow icon (thank you!).  I clicked on the
icon and the dialog indicated that a critical update was available, but it did
not say what was critical, what the update version was, or where to find more
info (of course, I know where to find more info, but thats not the point).  I
clicked to install the update.  After the update appeared to install, I checked
the version number string in the "Help", "About" menu, and it still said "0.10",
not "0.10.1".  So, the barely informative download dialog implied that 0.10.1
had been applied, but was it?  Did the browser need to be restarted?  It would
be helpful to provide better guidance for users that are perhaps less educated.

Thanks,

Stuart

Reproducible: Didn't try
Steps to Reproduce:
1.  Install 1.0 Preview Release (0.10)
2.  Click on the 'critical update' (red arrow icon) when it appears
3.  Install the update
4.  Notice that you are not sure if the update has really applied or if you
perhaps need to restart.
5.  Check "Help", "About Mozilla Firefox" and notice that the version number
still says "0.10".
6.  Restart the browser and now the version says "0.10.1", implying that you
actually needed to restart the browser but were not told this.




I'm using the default installation.

Comment 1

[Nick Bebout]

CONFIRMED

Comment 2

[Richard Hurt]

This is similar to bug #262558 "Patch that upgrades to 0.10.1 installs with
wrong permissions"

Comment 3

[Stuart]

(In reply to comment #2)
> This is similar to bug #262558 "Patch that upgrades to 0.10.1 installs with
> wrong permissions"

I wouldn't say that they are too similar, although they both relate to update
issues.  262558 appears to refer to the permissions when installing on Linux. 
#262544 (this bug) refers to the failure of educating the user that an
application restart is required after installing the patch.

What is curious is that 262558 mentions that the update "does not clear the
update button."  I noticed similar behavior after installing the update on
Windows.  Once the update has been installed and the application restarted, the
red update icon comes back!  When you click on it, a dialog box opens up and
contacts ftp.mozilla.org (or whatever it is), and then concludes that no updates
are available.  Perhaps that should be the subject of a separate bug (though it
is merely an annoyance)?

Comment 4

[Daniel Veditz [:dveditz]]

The issues in comment 3 (update icon not clearing after update) should be a
separate bug. I didn't see that while I do see this one.

XPinstall scripts return a status of RESTART_NEEDED, the update dialog needs to
watch for that status and give the user some message like "Quit and restart
Firefox to complete installation."  Perhaps even a "Would you like to quit now?"
dialog (with "Quit" "Cancel" buttons). 

Even better, from a user's POV, "Would you like to restart Firefox now?"
assuming we write an external process to re-launch the browser after shutdown.
And best of all would be a restart that reopens all the current windows and tabs.

But at the very least we should inform people a restart is needed. Do we tell
people when an install fails?

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 263501 has been marked as a duplicate of this bug. ***

Comment 6

[Asa Dotzler [:asa]]

Ben, this was fixed for aviary? Has whatever fixed this landed on the trunk?

Comment 7

[Darin Fisher]

The new software update system being developed for Firefox 1.5 will resolve this
issue.  The dialog will give the user a link they can click on to see details
about the update.

Comment 8

[Peter van der Woude [:Peter6]]

This has been resolved in the new update system