263801 - Hang when importing invalid address book (csv file)

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Andrew Tanner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9

Thunderbird version 0.8 (20040913):

  Attempting to import an address book csv file containing the following section...

First Name, Last Name, Nickname, E-mail Address
John, Citizen, John, [e-mail]
"Jane," Citizen, Jane, [e-mail]
Jim, Citizen, Jim, [e-mail]

  ...results in a hang when processing the "Jane," line. Source file is
obviously corrupt due to the comma within the quotes being discounted, but error
should be handled gracefully.
  

Reproducible: Always
Steps to Reproduce:
1.Open import dialog (Tools|Import)
2.Select "Address Books", "Text file", file location (see details for file),
column IDs
3.Click Ok to begin import

Actual Results:  
  Import process stops when it encounters the problem line and CPU usage pegs at
100%. Cancel button works but no error message is given.

Expected Results:  
  Report an invalid source file giving details (line#) and cancel import.

Comment 1

[Mark Banner (:standard8)]

I have a possible solution to this - I can stop the crash, just trying to
improve the actual import algorithm as well.

Comment 2

[Mark Banner (:standard8)]

*** Bug 279966 has been marked as a duplicate of this bug. ***

Comment 3

[Mark Banner (:standard8)]

Test case from duplicate bug 279966:
"Jamie,",Tester,Jamie Tester,,[e-mail],,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,

Comment 4

[Mark Banner (:standard8)]

Attachment: Patch for fix.

This patch has two parts. Firstly check for end of file whilst reading in
lines, if we have got to the end of file before a line is recongnised complete,
then that file is invalid, so return an error.

Secondly, revise the is line complete function so that it will take account of
quotes before the first delimiter. In doing so, it appears there is no point in
keeping track of if we have passed delimiters or not, so simply keep track of
the quotes.

I've tested it on both the two cases in this bug, and on a variety of my
current address books (tab and comma) for both mailnews & tb and they seem to
work ok.

Comment 5

[Mark Banner (:standard8)]

Just some housekeeping on flags.

Comment 6

[Scott MacGregor]

Comment on attachment 174075 [details] [diff] [review]
Patch for fix.

+	 if (isEof == PR_TRUE)

that can just be
if (isEof)

Comment 7

[Mark Banner (:standard8)]

Attachment: Patch for checkin

This patch fixes the nit that scott raised.

Comment 8

[Mark Banner (:standard8)]

Fix checked in by timeless:
2005-02-24 08:11	timeless%mozdev.org 	mozilla/ mailnews/ import/ text/ src/
nsTextAddress.h 	1.11 	1/1
2005-02-24 08:11	timeless%mozdev.org 	mozilla/ mailnews/ import/ text/ src/
nsTextAddress.cpp 	1.43 	22/38