264488 - Customize Toolbars window should not have maximize or minimize buttons

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Right-click a toolbar, select "Customize..."

The window that appears should not have minimize and maximize buttons.  (From
bug 262256 comment 9.)

Comment 1

[José Jeria]

This also applies to the "clear private data" dialog, it has a minimize button

Comment 2

[Paul J. Weiss]

Why do you want the maximize and minimize buttons to be removed? I think they are useful and behave as expected.

Comment 3

[Jesse Ruderman]

It doesn't make sense to maximize the Customize Toolbars window because then it would cover the toolbars you can drag items to.  And it doesn't make sense to minimize it because it's quite modal.

Comment 4

[Simon Bünzli]

Attachment: one-line fix

Instead of all window elements, we really only want a titlebar...

(In reply to comment #1)
> This also applies to the "clear private data" dialog, it has a minimize button

That dialog isn't marked as "dialog", presumably so that it doesn't end up as a sheet on OS X, and might require some #ifdef hackery. New bug?

Comment 5

[Paul J. Weiss]

Re: Comment #3

It makes sense to maximize it when you have a lot of extensions with icons, and you want to see more of what you have. It makes sense to minimize it if you want to see a clearer view of changes you have made.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

This makes us lose "resizable" too right? Not sure whether or not that is desired...

Comment 7

[Simon Bünzli]

Attachment: resizable!

Good catch.

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/3a436b085836

Comment 9

[(mostly gone) XtC4UaLL [:xtc4uall]]

checkin caused Bug 457160.

Comment 10

[Bill Gianopoulos [:WG9s]]

(In reply to comment #3)
> It doesn't make sense to maximize the Customize Toolbars window because then it
> would cover the toolbars you can drag items to.

Not if you hare using dual monitors.

Comment 11

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20081002 Minefield/3.1b1pre, Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20081002 Minefield/3.1b1pre, and  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20081002 Minefield/3.1b1pre.