Location bar doesn't have an icon in customize toolbar dialog

VERIFIED FIXED in Firefox 3.6a1

Status

()

defect
P2
normal
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: whimboo, Assigned: zeniko)

Tracking

({regression, verified1.9.1})

3.5 Branch
Firefox 3.6a1
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3.5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090322 Shiretoko/3.5b4pre ID:20090322030800

The location bar doens't have an icon when dropped from the toolbar into the customized toolbar dialog. There is only the label 'location' visible.

Steps:
1. Open customize toolbar dialog
2. Remove the location bar from the navigation toolbar

I wonder why there is no bug about this issue yet (or i missed it). Seems to be Windows only.
Flags: blocking1.9.1?
We might have missed it because of how many of us work on OSX :(

Regression range?
Mike this is Windows XP not OS X!
Ups sorry, I misread your comment. Xtc4yAll, could you try to find the regression range?
i looked and it's the same range as mentioned here: https://bugzilla.mozilla.org/show_bug.cgi?id=457160#c2 (still have that hourlies in my archive).
so it's a fallout of bug 264488 and the fix for bug 457160 didn't catch this one.
Blocks: 264488
Component: Toolbars and Toolbar Customization → Toolbars
Flags: blocking1.9.1?
Product: Toolkit → Firefox
QA Contact: toolbars → toolbars
Version: 1.9.1 Branch → Trunk
Flags: blocking-firefox3.5?
Assignee

Comment 6

10 years ago
Posted patch one-linerSplinter Review
Assignee: nobody → zeniko
Status: NEW → ASSIGNED
Attachment #369777 - Flags: review?(gavin.sharp)
Attachment #369777 - Flags: review?(gavin.sharp) → review+
Assignee

Updated

10 years ago
Keywords: checkin-needed
OS: Windows XP → All
Hardware: x86 → All
Target Milestone: --- → Firefox 3.6a1
Version: Trunk → 3.1 Branch
Flags: blocking-firefox3.5? → blocking-firefox3.5+
Priority: -- → P2
Do the max/min buttons have a name that could be used in "all,whatever=no"? Seems like you're getting closer and closer to having to list every single possible window feature other than max/min.
Assignee

Comment 8

10 years ago
(In reply to comment #7)
> Do the max/min buttons have a name that could be used in "all,whatever=no"?

Unfortunately, once a flag is set, it can't be unset anymore; i.e. once you set "all", there's (currently and thus at least for 1.9.1) no way for further qualification.
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/72137b6a5c16
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Assignee

Updated

10 years ago
Keywords: checkin-needed
Whiteboard: [needs 1.9.1 branch landing]
Verified fixed with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090402 Minefield/3.6a1pre (.NET CLR 3.5.30729) ID:20090402045446

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090402 Shiretoko/3.5b4pre (.NET CLR 3.5.30729) ID:20090402045633
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.