Closed Bug 26543 Opened 26 years ago Closed 20 years ago

[Mac] Both Backspace and Delete keys should delete Bookmarks items

Categories

(SeaMonkey :: Bookmarks & History, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey1.0alpha

People

(Reporter: ssource, Assigned: stefanh)

References

Details

(Whiteboard: [PDT-][adt3])

Attachments

(4 files, 1 obsolete file)

When you manage bookmarks, you are not able to select and press the delete key to remove them. Michael Schroder Admin@GetSource.com M13 BuildID: 2000012520
thanks for the bug report but a quick search (Bugzilla query form) for 'delete' in the summary and 'bookmark' in the body shows us that this is a dupe of bug 14442 *** This bug has been marked as a duplicate of 14442 ***
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → DUPLICATE
VERIFIED Dupe
Status: RESOLVED → VERIFIED
reversing myself. The delete functinality is there but it's the 'delete' key that does not work. I view that as a different problem than bug 14442. I'm REOPENING this bug. does anyone know who is handling key events of this sort?
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---
Looks like none of the keys work. Changing summary and nominating as "beta1" blocker.
Severity: minor → normal
Priority: P3 → P1
Summary: Delete Key does not function in "Manage Bookmarks" window. → Keys in "Manage Bookmarks" window are broken
Target Milestone: M14
Keywords: beta1
Assuming delete works in menu as work around.
Whiteboard: [PDT-]
by my estimate all four arrows keys work. 'Home', 'End', 'PgUp', 'PgDown', and 'Delete' (not backspace) do NOT work. changing platform to ALL/ALL
OS: Windows 98 → All
Hardware: PC → All
What this patch does: - it adds a keyset to bookmarks.xul, and defines key bindings for page up/down, home, end, delete and return keys. - it adds functions in bookmarks.js to implement these bindings. Note that I did not implement the functions for the page up/down bindings, since I don't know what the spec is. - home and end keys now select the first and last bookmark respectively (is that the spec?). Note that I encountered a problem I could not solve there. After pressing home or end, the first or last bookmark is selected. But then if an arrow key is pressed, the new selection is not above or below the first or last bookmark, but rather above or below the bookmark that was selected before pressing home or end (if any)... any idea why?
Summary: Keys in "Manage Bookmarks" window are broken → Keys in "Manage Bookmarks" window are broken (Delete, PgUp, PgDn, Home, End)
Whiteboard: [PDT-] → [PDT-] patch attached
Since the handling of Home/End/PgUp/PgDown was not working correctly, I removed it. The new patch just makes the delete key and the return key work. Deleting a bookmark crashes mozilla, whether it's done with Edit/Delete or the delete key. Probably because of bug #30710.
M16 ...
Target Milestone: M14 → M16
*** Bug 35194 has been marked as a duplicate of this bug. ***
Target Milestone: M16 → M17
borto@pacbell.net - this bug seems to have been overlooked. Could you check your patch still works against the current source, then we'll make some noise to get it in? Some of the stuff seems fixed, though... Gerv
I checked with 2000-05-13-08 on Linux. The delete key works. However if I select a bookmark and press Return, I get the following message in the console: STYLE CHANGE REFLOW. Blowing away all box caches!! and Mozilla crashes. I also have a XUL question. The following code implements the delete and return keys functionalities in bookmarks.xul: onkeyup="if (event.keyCode == 8) return doDelete(false); if( event.keyCode == 13 ) OpenURL(event, event.target.parentNode.parentNode, this);" Is that OK to hardcode key codes like this? Isn't it cleaner to use a keyset (see patch)?
Hmm, re-reading my comment, it may not be clear :) Delete key works in 2000-05-13-08 *without* my patch. Also return key produces a crash, without my patch. So if this crash is fixed, my patch is no longer needed.
Cyril, the return key crash issue needs to be a separate bug to be properly tracked.
OK, I opened bug #39385 for the return key crash. Marking this bug dependant on 39385.
Depends on: 39385
Move to M20 target milestone.
Target Milestone: M17 → M20
This bug is not no more reperdusable I tryed on win 98 on build 2000070508 and doesn't reperduce
Reassigning 79 Bookmarks bugs to Ben. I was told this was going to be done shortly about two months ago, but it clearly hasn't been. I think that's long enough for all these bugs to remain assigned to nobody. Feel free to filter all this spam into the trashcan by looking for this string in the message body: ducksgoquack
Assignee: slamm → ben
Status: REOPENED → NEW
worksforme. I guess this has since been fixed.
Status: NEW → RESOLVED
Closed: 26 years ago25 years ago
Resolution: --- → FIXED
This bug is VERIFIED Fixed in 2000113004 builds.
Status: RESOLVED → VERIFIED
*** Bug 93864 has been marked as a duplicate of this bug. ***
The wrong key, Forward Delete, performs the delete function in the Bookmarks window on Mac. The regular Delete key should perform this action. All other keys appear to function correctly.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
nav triage team: Marking p2 and mozilla0.9.5
Priority: P1 → P2
Target Milestone: --- → mozilla0.9.5
nav triage team: Marking nsbeta1+ to get off untriaged bug radar
Keywords: nsbeta1nsbeta1+
Mass-moving lower-priority 0.9.5 bugs off to 0.9.6 to make way for remaining 0.9.4/eMojo bugs, and MachV planning, performance and feature work. If you disagree with any of these targets, please let me know.
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Status: REOPENED → ASSIGNED
OS: All → Mac System 9.x
Hardware: All → Macintosh
Summary: Keys in "Manage Bookmarks" window are broken (Delete, PgUp, PgDn, Home, End) → Backwards/Forwards delete key issues in Bookmarks (Mac)
Target Milestone: mozilla0.9.6 → mozilla0.9.7
Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter email notifications caused by this by searching for 'ilikegoats'.
Assignee: ben → pchen
Status: ASSIGNED → NEW
The problem here is that bookmarks delete has been bound to VK_DELETE, which is forward delete. This is annoying on powerbooks since there is no forward delete key. Moving to mozilla0.9.9
Target Milestone: mozilla0.9.7 → mozilla0.9.9
Pushing out to mozilla1.0.1
Target Milestone: mozilla0.9.9 → mozilla1.0.1
*** Bug 55148 has been marked as a duplicate of this bug. ***
Resummarizing to something less `issues'-ish.
Keywords: 4xp, helpwanted
Summary: Backwards/Forwards delete key issues in Bookmarks (Mac) → Both Backspace and Delete keys should delete Bookmarks items
Whiteboard: [PDT-] patch attached → [PDT-]
Yet more proof that Mozilla is going nowhere. This obviously simple-to-fix bug has been open for a year.
sticking mac back in because i don't want this for windows.
Assignee: pchen → ben
URL: any
Summary: Both Backspace and Delete keys should delete Bookmarks items → [Mac] Both Backspace and Delete keys should delete Bookmarks items
Keywords: mozilla1.2
Keywords: nsbeta1
This needs to be done on Linux too, imo.
Nav triage team: nsbeta1+/adt3
Keywords: nsbeta1nsbeta1+
Whiteboard: [PDT-] → [PDT-][adt3]
Keywords: mozilla1.2mozilla1.3
Nav triage team: nsbeta1-
Keywords: nsbeta1+nsbeta1-
This bug is targeted at a Mac classic platform/OS, which is no longer supported by mozilla.org. Please re-target it to another platform/OS if this bug applies there as well or resolve this bug. I will resolve this bug as WONTFIX in four weeks if no action has been taken. To filter this and similar messages out, please filter for "mac_cla_reorg".
Setting to "all", since both Mac and Linux need it.
OS: Mac System 9.x → All
Hardware: Macintosh → All
retargeting
Target Milestone: mozilla1.0.1 → Future
Target Milestone: Future → mozilla1.0.1
Mass reassign of my non-Firefox bugs to ben_seamonkey@hotmail.com
Assignee: bugs → ben_seamonkey
http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarksManager.xul#108 108 <!-- We need to provide our own delete key binding because the key_delete 109 handler in platformGlobalOverlay.xul maps command to "cmd_delete" which 110 is NOT what we want! --> 111 <key id="key_bm_delete" keycode="VK_DELETE" command="cmd_bm_delete"/> Hmmm... On Mac (OS X) I'd at least expect [delete] (VK_BACK) to delete objects. This is what is used elsewhere to delete objects (e.g. entries in the history window). A quick check shows that (on this G4 laptop) [fn]+[delete] (VK_DELETE) doesn't delete inside the history window. I wouldn't even expect that to work, but I guess it wouldn't bother me either if we make that work. Dunno about Windows and Linux, over there I kinda expect the [Del] key to delete objects, but not the [Backspace] key. *shrug* Either we add 111a <key keycode="VK_BACK" command="cmd_bm_delete"/> or we write a Mac overlay that replaces the VK_DELETE with VK_BACK. I'm not quite sure what the problem is with the default cmd_delete handler on trees. Perhaps we need to do extra work when a bookmark is deleted, or some extra checks. <tree> should really allow us to register a delete handler which could veto (individual) deletes or do some extra work before the (individual) delete is done.
I believe that the original reported behaviour is still in. Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a4) Gecko/20040921 Firefox/0.9.1+ (Today's build). There are a fantastic number of 'Bookmark', 'Bookmark Sidebar' and 'Bookmark Manager' bugs open, and I can't really be certain where we are: My problem is: 1) The 'Delete Bookmark' key binding is Cmd-D. It should not be. Cmd-D should Duplicate. 2) At the very least, the Backspace key should Delete the current selection. 3) I am indifferent as to whether the Delete key should Delete the current selection, as I probably wouldn't use it, but it seems correct so to do. If I submitted a patch would it be considered
Neil, could you answer the questions in comment 44?
(In reply to comment #44) >1) The 'Delete Bookmark' key binding is Cmd-D. It should not be. Cmd-D >should Duplicate. I don't have a mac, but by my reading it should be Ctrl+D >2) At the very least, the Backspace key should Delete the current selection. >3) I am indifferent as to whether the Delete key should Delete the current >selection, as I probably wouldn't use it, but it seems correct so to do. > >If I submitted a patch would it be considered To add Backspace as a synonym for Delete? Sure.
Product: Browser → Seamonkey
I agree with Ben Fowler's comments regarding Mac OS X functionality for deletion of bookmarks, but I wanted add a few comments based on Safari and Apple's Mail application. Let me preface by saying that just because something is done a certain way in Safari doesn't mean it's part of the official guidelines or that we shouldn't do it a different way (some people seem to treat Safari as if it defined the Apple HIG for browsers!), but it's often a useful comparison. When managing bookmarks in Safari or emails in Mail (at least in Jaguar, I haven't tested in the newer Panther): - Hitting the delete key deletes the bookmark or mail - Hitting command-delete does nothing - Hitting command-d does nothing command-delete is usually used for moving files to the trash in OS X (as opposed to just deleting something within a file), so it tends to only be used in programs like iTunes and iPhoto where a file is actually moved to the trash as a result. Still, it'd be nice and intuitive to have BOTH delete and cmd-delete work to delete bookmarks. But given the use of the delete key in the other apps, I'd say that delete alone would be the more important one to have if we had to choose just one. I think the current cmd-d is a really bad idea for deleting bookmarks. In the main browser window it's used for adding a new bookmark, so making it do completely the opposite in the bookmarks manager is only asking for trouble. Is this something that should be filed separately for Firefox?
Attached patch One-liner, add backspace key (obsolete) — Splinter Review
This will make the backspace key a new key for deleting bookmark items on all platforms.
Assignee: ben_seamonkey → stefan_h
Status: NEW → ASSIGNED
Attachment #183860 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #183860 - Flags: review?(neil.parkwaycc.co.uk)
Keywords: helpwanted
Target Milestone: mozilla1.0.1 → Seamonkey1.0alpha
Comment on attachment 183860 [details] [diff] [review] One-liner, add backspace key > <key id="key_bm_delete" keycode="VK_DELETE" command="cmd_bm_delete"/> Hmm, yeah, bookmarks uses that weird cmd_bm_delete... >+ <key id="key_bm_delete2" keycode="VK_BACK" command="cmd_bm_delete"/> Nit: this doesn't need an id; the VK_DELETE <key> only has an id so that it shows up as the shortcut on the Windows/Linux menus.
Attachment #183860 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #183860 - Flags: superreview+
Attachment #183860 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #183860 - Flags: review+
Low-risk patch for Seamonkey.
Attachment #183860 - Attachment is obsolete: true
Attachment #183871 - Flags: superreview+
Attachment #183871 - Flags: review+
Attachment #183871 - Flags: approval1.8b2?
Comment on attachment 183871 [details] [diff] [review] New version with nit fixed, carrying over flags (Checked in) a=asa for seamonkey only change.
Attachment #183871 - Flags: approval1.8b2? → approval1.8b2+
Comment on attachment 183871 [details] [diff] [review] New version with nit fixed, carrying over flags (Checked in) Checking in xpfe/components/bookmarks/resources/bookmarksManager.xul; new revision: 1.9; previous revision: 1.8 done
Attachment #183871 - Attachment description: New version with nit fixed, carrying over flags → New version with nit fixed, carrying over flags (Checked in)
Status: ASSIGNED → RESOLVED
Closed: 25 years ago20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: