265457 - GetEventsForRange is inefficient

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

The way GetEventsForRange isn't efficients. It walks the array of items to find
the next occurence of any event, and keeps on doing this. So it lwlks the entire
array quite a few times. It does it this way to get a sorted list. The result is
that it takes quite long.
A better way would be to first walk the event to get all the occurences in the
time range, then sort it.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

Patch to do it. In a quick test, the function was about 25x as fast as before.

Patch depends on the patch in bug 262620. Not because it is really needed, but
because i didn't want to bitrot my own patches.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 162865 [details] [diff] [review]
patch v1

side note: i want to turn the eventOccurence class into oeICalEventOccurence
when that is ready. (guess how i found the inefficient code :) )

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: same for GetFirstEventsForRange

Ofcourse, we can do the same for GetFirstEventsForRange(), which is used for
the list of events.

Comment 4

[Mostafa Hosseini]

Comment on attachment 162865 [details] [diff] [review]
patch v1

Patch checked in, after fixing indents.

Comment 5

[Mostafa Hosseini]

Comment on attachment 162881 [details] [diff] [review]
same for GetFirstEventsForRange

Patch checked in, after fixing indents

Comment 6

[Mostafa Hosseini]

Fixed in CVS. Thanks for the great work mvl

Comment 7

[Marcia Knous [:marcia]]

Mass move of libxpical bugs to the Internal Components, per ctalbert.

Comment 8

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Internal Components. Be afraid for your sanity!