265507 - Problems renaming virtual folders

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

Asa reports having difficulty renaming his virtual folders. 

IMAP account. Single folder (inbox) virtual folders. 

Using today's windows build.

Comment 1

[Scott MacGregor]

I just tried to rename it and it looked like it was trying to unsubscribe the
folder from the imap server. 

Comment 2

[Asa Dotzler [:asa]]

The context menu needs looking over. I suspect some of the items are attempting
IMAP or other inappropriate actions. See, for example, Copy folder location and
Compact Folder. Also, Search seems to fail with odd IMAP warning too :)

Comment 3

[David :Bienvenu]

we talked about that - there are only a couple things that are really valid in
the context menu for virtual folders...I don't know if there's a bug, though.

Comment 4

[David :Bienvenu]

Attachment: proposed fix for imap

this looks like a big change, but basically what I really did was move some
routines from nsMsgLocalMailFolder.cpp to nsMsgDBFolder.cpp, so that imap could
call the local folder rename folder case for virtual folders (since in that
case we just want to rename the .msf file). I also got rid of some duplicate
code 

I'll need a similar fix for news ...

Comment 5

[Asa Dotzler [:asa]]

Can you enable rename from the properties window too?

Comment 6

[Asa Dotzler [:asa]]

OK, something is bad here. I can rename but after a restart, I can no longer
edit the virtual folder. All of the rules defined in the Properties window are gone.

Comment 7

[David :Bienvenu]

weird, it worked for me on trunk and branch. It sounds like it has forgotten
it's a virtual folder at all (I wish we had the art work for that...).

Comment 8

[Marcia Knous [:marcia]]

Using today's build, I can rename a virtual folder with no problem. But when I
do, the screen doesn't refresh, and it made me think that I had completely lost
the criteria. When I change focus to another folder and move back, the search is
still there. If we need a separate bug for the second part let me know.

Comment 9

[Scott MacGregor]

(In reply to comment #3)
> we talked about that - there are only a couple things that are really valid in
> the context menu for virtual folders...I don't know if there's a bug, though.

I filed Bug #266578 to hide the menu items in the folder pane that don't make
sense for a virtual folder. Fix checked in. 

Comment 10

[David :Bienvenu]

Asa, were you running on a mac or windows?

Comment 11

[Asa Dotzler [:asa]]

Windows XP.

Comment 12

[Scott MacGregor]

this seems to be working for me too using today's build with an imap account.
I'm going to go ahead and mark this fixed based on David's fix + comments from
marcia and myself.