265915 - typeahead pref. & "repeated character find" issues

Status: NEW

(Toolkit :: Find Toolbar, defect, P5)

Description

[Michael Clackler]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041024 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041024 Firefox/1.0

I opened this bug report to summarize the many issues with typeaheadfind
preferences.  The following preferences are not used in the "new" find bar:
accessibility.typeaheadfind.autostart
accessibility.typeaheadfind.startlinksonly
accessibility.typeaheadfind.enabletimeout

The "repeated character find" feature available in the "old" FAYT system is also
not present in the new find bar.

The following bugs are preference related (some are marked as fixed/duplicate
but are not working correctly or a duplicate):
bug 251633 - find as you type no longer cycles through links beginning...
bug 254592 - Options, Find as you type = off , should respect typeahea...
bug 260562 - accessibility.typeaheadfind.enabletimeout is ignored

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Michael Clackler]

Attachment: patch to fix preferences & repeated character find

This patch will enable the .autostart, .startlinksonly, and .enabletimeout
preferences as well as get the "repeated character find" feature working.

This patch will fix the following bugs (some are marked as fixed/duplicate but
are not working correctly or a duplicate):
bug 251633 - find as you type no longer cycles through links beginning...
bug 253994 - Pressing slash when find toolbar is visible but not focus...
bug 254592 - Options, Find as you type = off , should respect typeahea...
bug 260562 - accessibility.typeaheadfind.enabletimeout is ignored

Comment 2

[Michael Clackler]

nominating for 1.1 since it makes the find bar react to preferences to help "old
time" trunk users and a patch exists

Comment 3

[sairuh (rarely reading bugmail)]

has patch, so confirming.

Comment 4

[Peter van der Woude [:Peter6]]

Michael, does your patch still work with the current trunk build ?

Comment 5

[Mike Connor [:mconnor]]

-'ing, will consider updated patch.

I don't think we want repeated character find, as noted in other bugs.

Comment 6

[Jason Daly]

It would really suck if this make it into 1.5...

Comment 7

[Matt Day]

This is still broken in Firefox 1.5 RC3. Specifically, the find bar disappears after 5 seconds even when accessibility.typeaheadfind.enabletimeout is false.

I'm running Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 on Windows XP SP2.

I did a clean install of Firefox 1.5 RC3, not an upgrade, no old preferences or settings.

Extensions I'm using: DOM Inspector, Talkback, Google Toolbar for Firefox

Workaround: Set accessibility.typeaheadfind.timeout to 999999999 and restart Firefox.

Comment 8

[Adam Guthrie]

Michael, would you consider making a new patch that applies to the current FAYT code?

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 13 votes.
:enndeakin, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 10

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.