266249 - can't re-order or sort Calendars list

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Jamie Zawinski]

The Calendars list shows up only in the order in which the calendars were
created or subscribed.  I would like to control the order of entries in that
list, by dragging them to a new order, or by clicking on the column heading to
sort them alphabetically.

I was able to reorder them by quitting mozilla and hand-hacking the RDF file,
but that's kinda cheesy.

Calendar 2004092412
Mozilla 1.7.3
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922

Comment 1

[Yuval Aviel]

*** Bug 275332 has been marked as a duplicate of this bug. ***

Comment 2

[Matthew (lilmatt) Willis]

Reassigning all automatically assigned bugs from Mostafa to nobody@m.o

Bugspam filter: TorontoMostafaMove

Comment 3

[Tyran Ormond]

I just have to add that this is still an issue.  If when using only two or three calendars this isn't much of an issue but when managing tens of calendars, then being unable to sort the calendars makes life miserable.

Comment 4

[Robert Harvey]

I'd like to add my views to this bug.
It isn't just the order in which calendars are listed in the calendar pane that depends on creation order - the order in which all-day events like holidays and moon phases depends on the creation order in the calendar list pane.

I would like to suggest that it should be possible to pick up and drag individual calendars in the list pane to determine the default ordering, and also it should be possible to pick up and drag individual reminders within a date to over-ride the ordering.

Comment 5

[Bas van den Bosch]

As Imip-support currently adds events to the first calendar only (bug 361635), this is becoming a real issue especially for lightning, on all platforms. 

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

The new implementation of the calendar list (bug 388405) will be using a <richlistbox>. Unfortunatly, it is not possible to correctly use a <listhead> (header column) element on branch due to bug 376815. This could either become a trunk-only feature, or we need to port the trunk <richlistbox> to something like a <calendar-trunk-richlistbox>, or this feature will have to wait.

It should be possible to manually reorder the list without depending on trunk, it might be a bit messy to persist the order after a restart.

Comment 7

[Pete Riley]

I think that drag and drop is the best way to order the calendars.

I'm not sure that it's useful to sort calendars alphabetically by clicking on the column header.  That might require prefixing the calendar names with numbers like:

01 Pete
02 Work
03 Nancy

The problem with that is that when you add or remove calendars, then you have to change all the numbers.

Also, I don't think that sorting calendars by clicking on the column header would work if bug 255180 is implemented.

Comment 8

[Simon Paquet [:sipaq]]

Setting wanted0.8- as the main Calendar developers will not devote any time to
this in the 0.8 timeframe. Patches are, of course, always welcome.

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

bug 403006 has made this much more easily possible. I have some experimental code for this available.

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This is all there is to it :-)

I haven't made any effort to change the drag feedback, I think its fine the way it is for now.

I had some trouble finding the right indexes for adding/removing the array items, but I think they are good now.

Comment 11

[Berend Cornelius]

Comment on attachment 356689 [details] [diff] [review]
Fix - v1

everything looks very good.
r=berend

Comment 12

[Stefan Sitter [:ssitter]]

I can't test the patch currently therefore some questions: What happens if you start dragging but drop outside the calendar list or the application window? What happens if you abort the drag operation e.g. with Escape key? What happens if you drop e.g. an event or a desktop file to the calendar list? Is the same functionality available in an accessible way, e.g. keyboard shortcut?

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to comment #12)
> I can't test the patch currently therefore some questions: What happens if you
> start dragging but drop outside the calendar list 
Unfortunately hovering over the calendar views causes a shadow to be displayed. This is a views bug though, berend could you take a look at this?


> or the application window?
The drag session contains a text/plain flavor with the calendar name, so possibly dropping on an external app will display the name. On linux the drop wasn't possible outside the app window for me.


> What happens if you abort the drag operation e.g. with Escape key?
Works for me.

> What happens if you drop e.g. an event or a desktop file to the calendar
> list?
Caused an error, fixed.

>Is the same functionality available in an accessible way, e.g. keyboard 
>shortcut?
No, not currently. I'll ask in #accessibility if there is a commonly used key or use Ctrl+Up/Down.

Comment 14

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

Comment 15

[Philipp Kewisch [:Fallen][📱📆]]

Final patch as checked in is v2.

#a11y said there is no common key and we should consider adding buttons somewhere. I think a (very small) set of buttons in the Calendar list header with an up and down arrow (and a set of tooltips) is a good idea, I'll leave this to a different bug though.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/2150245817c8>

-> FIXED

Comment 16

[Pete Riley]

FYI, I can re-order the calendars in the list with drag & drop, but the order isn't remembered after I restart TB.

Thunderbird 3.0b2 'official' / Lightning 1.0pre (downloaded 28 Feb 2009)

(just upgraded from TB 2.X / Lightning 0.9)

Comment 17

[Stefan Sitter [:ssitter]]

(In reply to comment #16)
> FYI, I can re-order the calendars in the list with drag & drop,
> but the order isn't remembered after I restart TB.

This used to work in 1.0pre. I suggest that you file a new bug for the regression.

Comment 18

[Pete Riley]

Okay, filed bug 480930.

Comment 20

[Jelle de Jong]

thanks!

Comment 21

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.6pre) Gecko/20091105 Lightning/1.0pre Shredder/3.0pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.6pre) Gecko/20091106 Calendar/1.0pre

Comment 22

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".

Comment 23

[Ulrich Windl]

With many calendars in the list, it would be great to be able to select multiple calendars (at least a contiguous block) and move them around. You can only move a single calendar.

Comment 24

[Philipp Kewisch [:Fallen][📱📆]]

Please open a new bug for this feature request, this one is already 5 years old and has served its purpose :)