268762 - SMTP server list in Advanced Account Settings does not display entries correctly (when mutiple users on same server and no username)

Status: RESOLVED DUPLICATE of bug 237146

(Thunderbird :: Account Manager, defect)

Description

[Jason Chu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041023 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041023 Firefox/1.0

Using 0.9 20041102 branch (would try a newer build but the servers are
overloaded right now).  There are two problems with the SMTP server list in the
Advanced Account Settings (Tools > Account Settings > [account] / Server
Settings > Advanced > SMTP tab) dropdown that I can see that do not have bugs filed:

1. Entries are omitted from the list when there are entries with the same server
but different username options and different ports.  Any entries with no
username is omitted except for the first.
2. When there are entries with the same server but have different username
options and different ports, the wrong port is displayed for entries without a
username if they are preceded by one of the entries with a username.  The first
entry with a username's port is used instead.

I think these bugs are related somehow but I don't see anything wrong with the
XUL/JS so there must be something fishy going on with the SMTP RDF datasource.

Reproducible: Always
Steps to Reproduce:
Steps to reproduce bug 1:
1. Create a new profile
2. Add an SMTP server with servername smtp.example.org and port 25 and no username
3. Add another server with servername smtp.example.org and port 2525 and no username
4. Open the Advanced Account Settings dialog for an account and notice that the
SMTP dropdown does not include the second server (or any additional servers
without usernames)
5. Add another server with servername smtp.example.org and port 123 and username
jdoe
6. Open the AAS dialog and notice that the third server is listed (as will any
additional accounts with usernames)

Steps to reproduce bug 2:
1. Create a new profile
2. Add an SMTP server with servername smtp.example.org and port 2525 and
username jdoe
3. Add another server with servername smtp.example.org and port 25 and no username
4. Open the Advanced Account Settings dialog for an account and notice that the
entry for the second server shows port 2525
5. Edit the second server to include a username jsmith
6. Add another server with servername smtp.example.org and port 123 and no username
7. Open the AAS dialog and notice that the second server now shows the proper
port but the third server shows port 2525

Comment 1

[Ralf Hauser]

see also Bug 237146

Comment 2

[WADA:World Anti-bad-Duping Agency]

Adding "same server" and "no username" in summary for ease of search.

Comment 3

[WADA:World Anti-bad-Duping Agency]

(bug 1) sounds DUP of Bug 237146.
(bug 2) looks different symptom but seems to be a result of Bug 237146, same
SMTP server/different port/null username SMTP entries are not distinguished
properly.

Comment 4

[WADA:World Anti-bad-Duping Agency]

(bug 1) is DUP of Bug 237146.
But (bug 2) is different.

Steps to reproduce bug 2:
1. Create a new profile
2. Add an SMTP server with servername smtp.example.org and port 2525 and
username jdoe

> smtp1 is default SMTP server, because first defined SMTP.
> user_pref("mail.smtpserver.smtp1.auth_method", 1);
> user_pref("mail.smtpserver.smtp1.hostname", "smtp.example.org");
> user_pref("mail.smtpserver.smtp1.port", 2525);
> user_pref("mail.smtpserver.smtp1.username", "jdoe");
> user_pref("mail.smtpserver.smtp1.try_ssl", X);

3. Add another server with servername smtp.example.org and port 25 and no username

> user_pref("mail.smtpserver.smtp2.auth_method", 0);
> user_pref("mail.smtpserver.smtp2.hostname", "smtp.example.org");
> user_pref("mail.smtpserver.smtp2.port", 25);
> user_pref("mail.smtpserver.smtp2.username", "");
> user_pref("mail.smtpserver.smtp2.try_ssl", X);

4. Open the Advanced Account Settings dialog for an account and notice that the
entry for the second server shows port 2525
5. Edit the second server to include a username jsmith

> smtp1 is changed to ; (Please note that *NOT* smtp2)
> user_pref("mail.smtpserver.smtp1.auth_method", 1);
> user_pref("mail.smtpserver.smtp1.hostname", "smtp.example.org");
> user_pref("mail.smtpserver.smtp1.port", 2525);
> user_pref("mail.smtpserver.smtp1.username", "jsmith");
> user_pref("mail.smtpserver.smtp1.try_ssl", X);

6. Add another server with servername smtp.example.org and port 123 and no username

> user_pref("mail.smtpserver.smtp3.auth_method", 0);
> user_pref("mail.smtpserver.smtp3.hostname", "smtp.example.org");
> user_pref("mail.smtpserver.smtp3.port", 123);
> user_pref("mail.smtpserver.smtp3.username", "");
> user_pref("mail.smtpserver.smtp3.try_ssl", X);

7. Open the AAS dialog and notice that the second server now shows the proper
port but the third server shows port 2525

Three SMTP definitions at this point are as follows.

> user_pref("mail.smtpserver.smtp1.auth_method", 1);
> user_pref("mail.smtpserver.smtp1.hostname", "smtp.example.org");
> user_pref("mail.smtpserver.smtp1.port", 2525);
> user_pref("mail.smtpserver.smtp1.username", "jsmith");
> user_pref("mail.smtpserver.smtp1.try_ssl", X);

> user_pref("mail.smtpserver.smtp2.auth_method", 0);
> user_pref("mail.smtpserver.smtp2.hostname", "smtp.example.org");
> user_pref("mail.smtpserver.smtp2.port", 25);
> user_pref("mail.smtpserver.smtp2.username", "");
> user_pref("mail.smtpserver.smtp2.try_ssl", X);

> user_pref("mail.smtpserver.smtp3.auth_method", 0);
> user_pref("mail.smtpserver.smtp3.hostname", "smtp.example.org");
> user_pref("mail.smtpserver.smtp3.port", 123);
> user_pref("mail.smtpserver.smtp3.username", "");
> user_pref("mail.smtpserver.smtp3.try_ssl", X);

Displayed on which panel?
 (a) Outgoing server(SMTP)/Advanced?
 (b) Account Settings/Server Settings/Advanced/SMTP tab?

Displayed how?
All three SMTPs are displayed? Or only two SMTPs?

If (a) and all three are displayed, it is probably Bug 202045. 
> Bug 202045 : order of the smtp servers in the advanced outgoing server settings
>              changes from time to time

Comment 5

[Jason Chu]

I am talking about (b) and all three appear, the first two with the proper ports
but the third with port 2525.

And yes, I see that the first bug I mentioned is a dupe of bug 237146.  I
couldn't find it when I entered mine.

Comment 6

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #5)
> I am talking about (b) and all three appear, the first two with the proper ports
> but the third with port 2525.

Do you mean followings are displayed?
> smtp.example.org:2525
> smtp.example.org:123
> smtp.example.org:2525

Question on your real action.
> Steps to reproduce bug 2:
> 5. Edit the second server to include a username jsmith
Second in where and what?
Second display in (b)?
Second SMTP server(mail.smtpserver.smtp2.xxxx in prefs.js)?

Anyway, Bug 237146 already exists when no username is specified, and order in
display of Outgoing Server(SMTP)/Advanced is not fixed due to Bug 202045.
Try "Steps to reproduce bug 2" again, and check mail.smtpserver.smtp2.xxxx
entries in prefs.js after each step, and describe detail of what happend at
where, (a) or (b) or what's second.
And clalify what is the problem, please.

Comment 7

[WADA:World Anti-bad-Duping Agency]

> I couldn't find it when I entered mine.
The criminal is curent Product/Structure change which caused confusion of users
in searching Bugzilla.
See Bug 274365. 

Comment 8

[WADA:World Anti-bad-Duping Agency]

Reporter, report a problem per a bug.
Closing DUP of Bug 237146, according to main isseu in comment #0.

Reporter, if other problems still exist, see already mentioned bugs, and open
new bug(s), one bug per a independent problem, after careful Bugzilla search for
already opened or DUP or FIXED bugs.

*** This bug has been marked as a duplicate of 237146 ***