269893 - "Blank" password manager dialog

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Charles Fenwick]

After logging into a website, the password manager dialog comes up as expected.
 What is not expected is that the body of the dialog is blank (i.e. no text in
the area between the title and the buttons (which are all labled)).

Regression Window: Good on 20041110 nightly, bad on 20041111 nightly.

Comment 1

[Charles Fenwick]

Just tried this on a Linux nightly (20041124) and got the same results. 
Consequentialy, am changing OS to all. 

Re-reading my original report, I realize that it isn't exactly clear, so here's
some clarification.

Steps to Reproduce:

1.  Go to any site that requires logging-in that you do not have the password
stored for (https://sub.salon.com/login/ ,for example).

2.  Type in something for username and password.

3.  Click enter/login button.

4.  The 'Would you like to save this password' dialog comes up.  The problem is
that the body of the dialog is blank (so someone who has not used the program
before has no idea what is being asked of them.

Comment 2

[PikeUK]

*** Bug 272594 has been marked as a duplicate of this bug. ***

Comment 3

[Charles Fenwick]

Funny the stuff you think of when you actually look at the code while looking at
checkins.

After looking at 

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-11-10+08%3A00&maxdate=2004-11-11+08%3A00&cvsroot=%2Fcvsroot

and 

http://lxr.mozilla.org/mozilla/source/toolkit/components/passwordmgr/base/nsPasswordManager.cpp#1131

I decided to try reverting to v1.41 of 

http://lxr.mozilla.org/mozilla/source/intl/strres/src/nsStringBundle.cpp

Regression disappeared.

Comment 4

[Simon Montagu :smontagu]

I'm on this.

Comment 5

[Simon Montagu :smontagu]

Attachment: Remove over-enthusiastic null-checking

Comment 6

[Simon Montagu :smontagu]

Comment on attachment 167617 [details] [diff] [review]
Remove over-enthusiastic null-checking

Neil, I think rs should be sufficient here. I went too far in response to your
sr comment on bug 268832 "FormatStringFromName
doesn't have any error checking." :)

Comment 7

[[e-mail]]

Comment on attachment 167617 [details] [diff] [review]
Remove over-enthusiastic null-checking

rs=me to change this to an assertion.

Comment 8

[Tracy Walker [:tracy]]

for the record, this is happening on Mac too.

Comment 9

[Phil Ringnalda (:philor)]

*** Bug 273074 has been marked as a duplicate of this bug. ***

Comment 10

[Simon Montagu :smontagu]

Checked in.

Comment 11

[Bill Mason]

V fixed 20041205 PC/WinXP