271091 - Incorrect filename when downloading via "Save Link As..." or left click while holding down ALT

Status: RESOLVED DUPLICATE of bug 299372

(Firefox :: General, defect)

Description

[Norbert]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Please open the attached HTML-file that includes a link.

A left-click leads to the correct filename "der_Test.wav".
But a left-click while holding down ALT or right-click "Save Link As..." lead to
the incorrect filename "le.wav"!

In IE such problems do no exist.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Norbert]

Attachment: HTML-file to reproduce this bug

Comment 2

[Jesse Ruderman]

Might be a dup of bug 264757.

Comment 3

[Phil]

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0

Have you tested this with code after about 17th or 18th November? (I cannot
currently, sorry.) I think this is when a relevant fix was checked in for bug
263697 ...

Comment 4

[Norbert]

(In reply to comment #3)

> Have you tested this with code after about 17th or 18th November? (I cannot
> currently, sorry.) I think this is when a relevant fix was checked in for bug
> 263697 ...


I have tested it with the 1.0 final version. I guess that it is older than 17th
November.
I think a new final version is not available currently, or is it?
I have not tested trunk versions.

Comment 5

[Norbert]

typing error:
"a new final version" -> "a newer final version"

Comment 6

[Phil]

(In reply to comment #4)
> I have tested it with the 1.0 final version. I guess that it is older than 17th
> November.
> I think a new final version is not available currently, or is it?
> I have not tested trunk versions.

Ah. Firefox. 1.0. I missed that bit... 
The final patch for bug 160454 won't be in the production release of FF, but a
call was raised to get it merged into FF, which I guess may have happened
post-1.0 FF. I'm guessing that if you are seeing a regression because of that,
then the further patch for bug 263697 /hasn't/ been added to FF... yet...

Yeah, testing against a trunk version may be the way to go... Bz?

Comment 7

[Boris Zbarsky [:bzbarsky]]

The URL for testing is a 404, so I have no idea what's going on here -- it's
impossible to test.

Comment 8

[Phil]

(In reply to comment #7)
> The URL for testing is a 404, so I have no idea what's going on here -- it's
> impossible to test.

Yes... can you fix that please Norbert?

Bz - with head now removed in 1.8a5, is this broken URL now a good candidate for
reproducing bug 174167? ;-)

Comment 9

[Boris Zbarsky [:bzbarsky]]

Yes, it is.  But so's any other broken URL.... ;)

Comment 10

[Phil]

(In reply to comment #9)
> Yes, it is.  But so's any other broken URL.... ;)

Yeah I know, being sarcastic ;-) or something like that....
Just toying with the idea if spending some time on it.... maybe....

Comment 11

[Norbert]

To get such download-URLs, a english-german translation with the LEO-dictionary
has to be done. The wave files are these links that look like a speaker, on the
right side. (These are wave-files that contain the german words.)

Open (not download!) for example
http://dict.leo.org/?search=test&searchLoc=0&relink=on&spellToler=standard&sectHdr=on&tableBorder=1&cmpType=relaxed&lang=en
and download the speaker-link with save as...

Comment 12

[Phil]

(In reply to comment #11)
> To get such download-URLs, a english-german translation with the LEO-dictionary
> has to be done. The wave files are these links that look like a speaker, on the
> right side. (These are wave-files that contain the german words.)
> 
> Open (not download!) for example
>
http://dict.leo.org/?search=test&searchLoc=0&relink=on&spellToler=standard&sectHdr=on&tableBorder=1&cmpType=relaxed&lang=en
> and download the speaker-link with save as...

Well given the make-up of the URL, I don't think it's possible to come up with a
'correct' name without either
(a) doing a HEAD request ( ;-) ) or
(b) deciding on a name only after downloading the link (giving an option the
user can select so they are prompted when the link has been downloaded, or they
can choose to have the browser 'choose' for them - but then how are they to know
what the file was called?).

What does IE do? Opera?

Comment 13

[Norbert]

(In reply to comment #12)

> Well given the make-up of the URL, I don't think it's possible to come up with a
> 'correct' name without either
> (a) doing a HEAD request ( ;-) ) or
> (b) deciding on a name only after downloading the link (giving an option the
> user can select so they are prompted when the link has been downloaded, or they
> can choose to have the browser 'choose' for them - but then how are they to know
> what the file was called?).
> 
> What does IE do? Opera?


I have not tested Opera.



In IE it works fine:

It looks like they show the file-request-dialog after the protocol header lines
(http/ftp) are received and start downloading into temp-directory. And after the
download has finished they move the file to the directory and filename the user
has selected. So no HEAD request is needed...

Comment 14

[Boris Zbarsky [:bzbarsky]]

So for a slow (or unresponsive) server they take a long time to show the dialog?

Comment 15

[Norbert]

(In reply to comment #14)
> So for a slow (or unresponsive) server they take a long time to show the dialog?

Give me "a slow (or unresponsive)" URL and I will test it.

Comment 16

[Boris Zbarsky [:bzbarsky]]

http://www.example.com:400/index.txt will do just fine...

Comment 17

[Norbert]

(In reply to comment #16)
> http://www.example.com:400/index.txt will do just fine...

Both, Firefox and IE, need some seconds until the error message appears. I have
not measured the time, but it looks like there is no significant difference.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Right, but does IE allow selecting a place to save before the error message
appears?  Or do you do "save link as" and get no feedback at all until the error
message pops up?

Comment 19

[Dave Miller [:justdave]]

Save Link As... already appears to be delaying until the file starts downloading
for me in Firefox 1.0.  I've tried that when my bandwidth is soaked because of
something being uploaded from another computer at home here, and it delays
several seconds before the filename box pops up.  The problem is that is uses
the filename from the URL and not the one given in the Attachment-Disposition
line.  

Comment 20

[Nelson Chan]

I have similar problem when downloading attachments in yahoo mail.  The filename
chops off after characters like space and underscore.(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0
> 
> Please open the attached HTML-file that includes a link.
> 
> A left-click leads to the correct filename "der_Test.wav".
> But a left-click while holding down ALT or right-click "Save Link As..." lead to
> the incorrect filename "le.wav"!
> 
> In IE such problems do no exist.
> 
> Reproducible: Always
> Steps to Reproduce:

Comment 21

[OstGote!]

(In reply to comment #20)
> I have similar problem when downloading attachments in yahoo mail.  The filename
> chops off after characters like space and underscore.

That is bug 252309 (see bug 221028 too).

Comment 22

[Frank Wein [:mcsmurf]]

*** Bug 289436 has been marked as a duplicate of this bug. ***

Comment 23

[:Gavin Sharp [email: [e-mail]]]

*** Bug 308124 has been marked as a duplicate of this bug. ***

Comment 24

[Phil Ringnalda (:philor)]

(In reply to comment #18)
> Right, but does IE allow selecting a place to save before the error message
> appears?  Or do you do "save link as" and get no feedback at all until the error
> message pops up?

IE brings up a non-modal dialog, equivalent to Seamonkey's "Open a progress
dialog," that says "Getting file information:" with a bunch of animation to keep
you amused until it errors out.

Opera, on the other hand, explodes: it only changes the cursor to busy to tell
you anything's happening, then changes the whole page to a connection error
page, and if you then hit back and try again, saves some binary file, not sure
what it is, as index.htm. I wouldn't recommend emulating that.

Comment 25

[Elmar Ludwig]

Bug 299372 is essentially the same as this. I'm going to mark this as a duplicate
(though it is the older bug) since bug 299372 has more relevant information.

*** This bug has been marked as a duplicate of 299372 ***