271758 - Noresolveonopenblockers doesn't allow removing the dependency when fixing

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Jouni Heikniemi]

When noresolveonopenblockers is set to on and you have blockers on a bug, you
cannot simultaneously remove the last blocking relationship and mark the bug as
fixed. Instead, you have to remove the dependency first and then fix the bug
separately.

Comment 1

[Dave Miller [:justdave]]

As much as I'd love to see this in 2.18, I think this is going to require too
big of an overhaul to process_bug.cgi to fix to fit the low-risk criteria to go
into the 2.18 branch.  I'm pretty sure the only way to handle this is to move
the dependency processing code earlier in the process than the status change
processing code.

Comment 2

[Frédéric Buclin]

*** Bug 279943 has been marked as a duplicate of this bug. ***

Comment 3

[Greg Hendricks]

Likewise, if you have a bug that is already marked RESOLVED and then add open blockers with noresolveonopenblockers set, it will prevent you from making any future updates to the bug. At the very least we should not allow open bugs to be added as blockers to resolved bugs if noresolveonopenblockers is on.

Comment 4

[Frédéric Buclin]

(In reply to comment #3)
> Likewise, if you have a bug that is already marked RESOLVED and then add open
> blockers with noresolveonopenblockers set, it will prevent you from making any
> future updates to the bug.

This is bug 565314

Comment 5

[Frédéric Buclin]

Attachment: patch, v1

set_all() first sets dependencies, so $self->dependson already contains the updated list of blocking bugs.

Comment 6

[Max Kanat-Alexander]

Comment on attachment 472667 [details] [diff] [review]
patch, v1

Looks great and is a nice cleanup! :-)

Comment 7

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Bug.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 7466.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified Bugzilla/Bug.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 7397.