272566 - Security tab missing from Page Info

Status: VERIFIED FIXED

(Firefox :: Page Info Window, defect)

Description

[PikeUK]

The security tab has disappeared since the merge, it worked in a trunk build
from 2004-11-25 but does not appear in:

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a6) Gecko/20041201 Firefox/1.0+

Steps to Reproduce:
1. Visit https://bugzilla.mozilla.org/
2. Double-click the lock icon in the url bar.

Expected Result:
Page Info should open showing the security tab.

Actual Result:
Page Info opens at the General tab, the security tab is missing.

Comment 1

[PikeUK]

See:
http://lxr.mozilla.org/seamonkey/source/security/manager/pki/resources/content/contents.rdf#54
http://lxr.mozilla.org/aviarybranch/source/security/manager/pki/resources/content/contents.rdf#39

http://bonsai.mozilla.org/cvsquery.cgi?branch=&branchtype=match&date=explicit&mindate=2004-07-19+15%3A01&maxdate=2004-07-19+15%3A01

Looks like these files were unforked/switched-to-preprocessor on the branch but
not the trunk (I think).

Comment 2

[Steffen Wilberg]

Attachment: patch for contents.rdf

The change to mozilla/security/manager/pki/resources/content/contents.rdf is
the only one left to port from the branch.

Comment 3

[Benjamin Smedberg]

Comment on attachment 169313 [details] [diff] [review]
patch for contents.rdf

This kind of app-specific ifdef is not acceptable on the trunk. A more generic
solution must be found. I think that both overlays can be safely listed in the
manifest.

Comment 4

[Steffen Wilberg]

Attachment: all-in-one

Indeed, this is already used in
http://lxr.mozilla.org/seamonkey/source/calendar/resources/content/contents.rdf#57.

Comment 5

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20041219 Firefox/1.0+
(daihard: P4/SSE2)

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20041225 Firefox/1.0+
(daihard: P4/SSE2)

Both of these builds have a working Security tab. Was attachment 169355 [details] [diff] [review] checked
in yet?

Comment 6

[Steffen Wilberg]

It wasn't checked in. Why don't you ask daihard if he applied my patch to his
custom build?
Or try an official build?
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

Comment 7

[Peter van der Woude [:Peter6]]

(In reply to comment #6)
> It wasn't checked in. Why don't you ask daihard if he applied my patch to his
> custom build?
> Or try an official build?
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

It's not in the official trunk Steffen.
Acc. to http://forums.mozillazine.org/viewtopic.php?t=194893 
"Patches: Patch to bug 272566 applied "
Daihard is using your patch.

Comment 8

[Bradley Chapman (not reading bugmail, still gone but not forever)]

But the interesting part is that the two builds I mentioned above _did_ _not_
have the patch applied, and yet they still functioned.

Comment 9

[Bill Gianopoulos [:WG9s]]

I have built both Firefox and Seamonkey with this patch and can report that the
resultant builds  both worked and had operational Security tabs with no obvious
undesirable effects.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

*** Bug 278478 has been marked as a duplicate of this bug. ***

Comment 11

[Jerry Baker]

This is hurting secure pages in framesets (yes they still exist). One of my
customers has an explanation on a secure page to right-click and select
"Properties" or "Page Info" to see that the frame is secure. This doesn't work
in Firefox.

Comment 12

[Jeremy Priest]

yeah, I'm not getting any security info tab when viewing the page info of this
page using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b)
Gecko/20050206 Firefox/1.0+.

Comment 13

[Phil Ringnalda (:philor)]

*** Bug 281441 has been marked as a duplicate of this bug. ***

Comment 14

[Mike Connor [:mconnor]]

Comment on attachment 169355 [details] [diff] [review]
all-in-one

Neil, bz said you'd be a good person to r+sr this.

Comment 15

[Asaf Romano (gone)]

Checking in mozilla/security/manager/pki/resources/content/contents.rdf;
/cvsroot/mozilla/security/manager/pki/resources/content/contents.rdf,v  <-- 
contents.rdf
new revision: 1.25; previous revision: 1.24
done

Comment 16

[sairuh (rarely reading bugmail)]

vrfy'd fixed using recent firefox trunk builds on linux fc2 and mac os x 10.3.8.