272678 - allowed sites/exceptions list for popup-blocking/software install/imges/cookies empty

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Ryuichi KUBUKI]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041201 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041201 Firefox/1.0+

Exceptions list for both cookie and popup-blocking show empty.
When you try to add a new host name, nothing happens even if you push the 'Add'
button.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Ryuichi KUBUKI]

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6)
Gecko/20041201 Firefox/1.0+
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6)
Gecko/20041201 Firefox/1.0+
> 
> Exceptions list for both cookie and popup-blocking show empty.
> When you try to add a new host name, nothing happens even if you push the 'Add'
> button.

I meant the Allow/Block buttons, sorry for a spam

Comment 2

[Peter van der Woude [:Peter6]]

->new
keyword ->aviary-landing

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

The same applies to the Exceptions list for the software install (extensions etc).

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041203
Firefox/1.0+

I found that the data was still stored in hostperm.1 and was being used (so that
subsequent extension installs from the same site were not blocked), but the list
is always empty. There are no js warnings in the console when opening the
exceptions window or adding a new item.

Comment 4

[Steffen Wilberg]

Tweaking summary. It's always the same dialog, just with different options.

Comment 5

[Ed Chan]

The list appears to be empty but when I click in the empty space I can highlight
the different lines.  When I add a new site to the exception list, an additional
highlightable line is added.  Highlighted entries can be removed, but no text is
shown about the listed items even when highlighted.

Comment 6

[PikeUK]

More fallout from Bug 221619:

These two lines should be aColumn.id (the second argument to getCellText() is
now an nsITreeColumn not a string):

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/cookieviewer/content/CookieExceptions.js&mark=31,33#23

Comment 7

[Steffen Wilberg]

Attachment: patch

As suggested in comment 6. Works fine.

Comment 8

[PikeUK]

I forgot to add earlier that even with these changes, removing permissions still
doesn't work. I think we need to sync our view object with the seamonkey one,
specifically remove the getter from rowCount but it looks like the parameters
from some of the function stubs have changed as well (not that I suppose that
would break anything in JS).

http://lxr.mozilla.org/seamonkey/source/extensions/wallet/cookieviewer/resources/content/CookieViewer.js#488
http://lxr.mozilla.org/seamonkey/source/browser/components/cookieviewer/content/CookieExceptions.js#23

If you check attachment 143361 [details], it appears they missed the Firefox exception
viewer when they updated for the tree changes. Not sure if that is a job for
another bug or this one.

Comment 9

[Steffen Wilberg]

Removing permissions works fine here.

The trunk version of CookieExceptions.js didn't contain var gPermissionManager =
{}. That was introduced on the branch by bug 241705. So it wasn't fixed on the
trunk by bug 221619.

However, CookieViewer.js was fixed on the trunk. I guess we want to port that:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=CookieViewer.js&branch=&root=/cvsroot&subdir=mozilla/browser/components/cookieviewer/content&command=DIFF_FRAMESET&rev1=1.3&rev2=1.4

Comment 10

[PikeUK]

(In reply to comment #9)
> Removing permissions works fine here.

Sorry that was mis-remembered from this morning, it does work but it leaves a
blank line in the tree (since it tries to reduce the size of rowCount which only
has a getter, I think that was the cause anyway).

> That was introduced on the branch by bug 241705. So it wasn't fixed on the
> trunk by bug 221619.

OK that explains it.

Comment 11

[Steffen Wilberg]

Indeed, the js console shows this error though when removing a permission and
hovering over the blank line:

Error: gPermissionManager._addedPermissions[aRow] has no properties
Source File: chrome://browser/content/cookieviewer/CookieExceptions.js
Line: 32
(and line 34)

Comment 12

[Steffen Wilberg]

The error Pike mentioned in comment 10 is:
Error: setting a property that has only a getter
Source File: chrome://browser/content/cookieviewer/treeUtils.js
Line: 43

I see that in Firefox 1.0 as well, so that's another bug.

Comment 13

[Steffen Wilberg]

Attachment: port tree changes missed by bug 221619

The changes to fix this bug are those to getCellText().

I've ported more tree widget changes made by bug 221619 from bug
CookieViewer.js to CookieExceptions.js and from nsWalletTreeUtils.js to
treeUtils.js. It doesn't look like they're necessary, but who knows.

Comment 14

[Mike Connor [:mconnor]]

Comment on attachment 168196 [details] [diff] [review]
port tree changes missed by bug 221619

I knew we'd break somewhere for this stuff :)

Comment 15

[Steffen Wilberg]

Checking in mozilla/browser/components/cookieviewer/content/CookieExceptions.js;
/cvsroot/mozilla/browser/components/cookieviewer/content/CookieExceptions.js,v 
<--  CookieExceptions.js
new revision: 1.9; previous revision: 1.8
done
Checking in mozilla/browser/components/cookieviewer/content/treeUtils.js;
/cvsroot/mozilla/browser/components/cookieviewer/content/treeUtils.js,v  <-- 
treeUtils.js
new revision: 1.8; previous revision: 1.7
done

I filed bug 273698 for the problem mentioned in comment 10 - 12.

Comment 16

[PikeUK]

*** Bug 273887 has been marked as a duplicate of this bug. ***

Comment 17

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change